From 8e975ecb785939d7dfce7404511ab3c4d8cd3059 Mon Sep 17 00:00:00 2001 From: tannevaled Date: Sun, 15 Nov 2026 16:24:17 +0100 Subject: [PATCH] go 1.27.4 for GO-2026-6859, and the CI pin reads go.mod instead of an env var MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GO-2026-6859, published 2026-11-11, CVE-2026-97054: "HTTP/1 server crash due to MaxBytesReader header race in net/http", standard library, fixed in 1.26.11 and 1.27.4. Read at https://vuln.go.dev/ID/GO-2026-6859.json rather than quoted from notes. The `go` directive is the only one of the three Go pins a CONSUMER reads: the CI pin builds our artefacts, the toolchain stamped in a binary says what one installed executable was built with, and this line is what `go install` honours under GOTOOLCHAIN=local. `modfloor --floor 1.27.4` read the directive this module PUBLISHED at v0.2.1 as `go 1.27.3`. ⛔ AND THIS ONE IS A PROXY: it serves HTTP as well as fetching it, so an advisory about an HTTP/1 SERVER is this program's own class rather than a contract detail. Reachability remains govulncheck's question, not this line's. WHY THIS REPOSITORY NOW: it is named in go-fleettools/fleettools/.github/vulnscan-exposed.txt, the nine repositories with a NETWORK SURFACE — a list that file says was cut BY EXPOSURE rather than by convenience, because both repositories that actually REACHED an advisory in the fleet's 58 decoders were network-facing, and this was one of the two. ⛔⛔ THE SECOND HALF, AND THE WORKFLOW ASKED FOR IT IN WRITING. `env.GO_VERSION` carried the literal "1.27.3" with this comment above it: KEEP THIS EQUAL TO go.mod's `go` DIRECTIVE. [...] Raising go.mod alone would leave the lane building the vulnerable one. That was right, and it was a rule with nothing to enforce it — two weeks later the raise arrives and the pin still says 1.27.3. The failure is not a quiet older build either: `setup-go` sets GOTOOLCHAIN=local, so the lane REFUSES with `go.mod requires go >= 1.27.4`. Measured the same day on five of six go-filesystems repositories, every job red at once. So the three steps now read `go-version-file: go.mod` and GO_VERSION is gone. The equality the comment requested is structural instead of requested, and the next raise needs no edit here. `vuln.yml` already read the file, which is where the shape came from. ⚠ WORTH KNOWING, because it is why nothing flagged this: `gofloor` reports a hard-coded `go-version` as a finding, and classifies `${{ env.GO_VERSION }}` merely as "expression". A literal one indirection away was invisible to the auditor written to find exactly this drift. Filing separately. actionlint clean, gofmt silent, go build and go test ./... pass, no `go-version:` literal left in any workflow. MINOR, not patch: a raised floor is a genuine break for a consumer pinned below it with GOTOOLCHAIN=local — their build stops instead of quietly producing a vulnerable binary. Co-Authored-By: Claude Opus 5 --- .github/workflows/ci.yml | 30 +++++++++++++++++++++--------- go.mod | 26 +++++++++++++++++++++++++- 2 files changed, 46 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2d6f81a..1101884 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,12 +23,24 @@ permissions: env: CGO_ENABLED: "0" - # ⛔ KEEP THIS EQUAL TO go.mod's `go` DIRECTIVE. It is the toolchain the - # artefacts are built with, and the standard library is judged by it: on - # 2026-10-31 this said 1.27.2 while GO-2026-6809 (crypto/x509 - # Certificate.Verify) was reachable from cmd/browserproxy, fixed in go1.27.3. - # Raising go.mod alone would leave the lane building the vulnerable one. - GO_VERSION: "1.27.3" + # ⛔ GO_VERSION IS GONE, AND THE COMMENT IT CARRIED IS WHY. It said: + # + # KEEP THIS EQUAL TO go.mod's `go` DIRECTIVE. [...] Raising go.mod alone + # would leave the lane building the vulnerable one. + # + # That was right, and it was a rule with nothing to enforce it. On 2026-11-15 + # the directive moved to 1.27.4 for GO-2026-6859 while this still said + # "1.27.3" — the note's own warning, two weeks later. `setup-go` sets + # GOTOOLCHAIN=local, so the lane does not build the older toolchain quietly: + # it REFUSES with `go.mod requires go >= 1.27.4`. Measured the same day on + # five of six go-filesystems repositories, every job red at once. + # + # So each step now reads `go-version-file: go.mod` instead. The equality the + # comment asked for is structural rather than requested, and the next raise + # needs no edit here. ⚠ An expression like `${{ env.GO_VERSION }}` also hid + # this from `gofloor`, which classifies a hard-coded pin as a finding but an + # expression as merely "expression" — a literal one indirection away was + # invisible to the auditor written to find exactly this. jobs: test: @@ -39,7 +51,7 @@ jobs: - uses: actions/setup-go@v7 with: - go-version: ${{ env.GO_VERSION }} + go-version-file: go.mod check-latest: true - name: Build (CGO_ENABLED=0) @@ -68,7 +80,7 @@ jobs: - uses: actions/setup-go@v7 with: - go-version: ${{ env.GO_VERSION }} + go-version-file: go.mod check-latest: true - name: Build for linux/${{ matrix.goarch }} @@ -85,7 +97,7 @@ jobs: - uses: actions/setup-go@v7 with: - go-version: ${{ env.GO_VERSION }} + go-version-file: go.mod check-latest: true - uses: actions/setup-node@v7 diff --git a/go.mod b/go.mod index 5904d19..602d804 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,30 @@ module github.com/go-webengine/browserproxy -go 1.27.3 +// ⛔ THE PATCH, AND THIS REPOSITORY IS ONE OF THE NINE THE FLEET SWEEPS FOR +// EXPOSURE: it is the browser proxy, network in, untrusted HTML parsed. This +// line is the only one of the three Go pins a CONSUMER honours — `go install` +// with GOTOOLCHAIN=local obeys it, while the CI pin merely builds our artefacts +// and the toolchain stamped in a binary describes one executable. +// +// Raised to 1.27.4 on 2026-11-15 for GO-2026-6859 — published 2026-11-11, +// CVE-2026-97054, "HTTP/1 server crash due to MaxBytesReader header race in +// net/http", stdlib, fixed in 1.26.11 and 1.27.4. Read at +// https://vuln.go.dev/ID/GO-2026-6859.json rather than quoted from notes. +// +// ⛔ AND THIS ONE IS A PROXY: it SERVES HTTP as well as fetching it, so an +// advisory about an HTTP/1 server is this program's own class rather than a +// contract detail. (Whether its handlers reach the racing path is a +// REACHABILITY question, which govulncheck answers and this line does not.) +// +// Measured, not assumed: `modfloor --floor 1.27.4` read the directive this +// module PUBLISHED at v0.2.1 as `go 1.27.3`. Eight of the nine network-facing +// modules read BELOW; only go-webengine/engine was already at 1.27.4. This is +// the second-to-last of the eight. +// +// Previous raise, kept because the record is the point: 1.27.2 -> 1.27.3 on +// 2026-10-31 for GO-2026-6809 (crypto/x509 Certificate.Verify), which was +// REACHABLE from cmd/browserproxy — not merely required. +go 1.27.4 require ( github.com/go-webengine/engine v0.18.1