From ce80213a4f87afe3ebf52802c902d3878be3fe22 Mon Sep 17 00:00:00 2001 From: Doug Waldron Date: Wed, 22 Jul 2026 11:06:04 -0400 Subject: [PATCH 1/2] Address package vulnerability warnings --- Directory.Packages.props | 2 ++ package-readme.md | 9 +++++++++ samples/Sample.WebApp/Sample.WebApp.csproj | 1 + src/EmailQueue.API/EmailQueue.API.csproj | 2 ++ tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs | 8 +++++--- 5 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 package-readme.md diff --git a/Directory.Packages.props b/Directory.Packages.props index 7c9c4f6..ac388c2 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -14,6 +14,7 @@ + @@ -25,6 +26,7 @@ + \ No newline at end of file diff --git a/package-readme.md b/package-readme.md new file mode 100644 index 0000000..5830bf2 --- /dev/null +++ b/package-readme.md @@ -0,0 +1,9 @@ +# NuGet Package maintenance + +Some transitive NuGet packages have been updated directly to work around vulnerable dependencies in other packages. + +- `Microsoft.OpenApi` 2.11.0 has added to `EmailQueue.API` to avoid a vulnerable version in + `Microsoft.AspNetCore.OpenApi`. + +- `SQLitePCLRaw.lib.e_sqlite3` 2.1.12 has added to `EmailQueue.API` to avoid a vulnerable version in + `Microsoft.EntityFrameworkCore.Sqlite`. \ No newline at end of file diff --git a/samples/Sample.WebApp/Sample.WebApp.csproj b/samples/Sample.WebApp/Sample.WebApp.csproj index 69b1ec8..cede26e 100644 --- a/samples/Sample.WebApp/Sample.WebApp.csproj +++ b/samples/Sample.WebApp/Sample.WebApp.csproj @@ -10,6 +10,7 @@ + diff --git a/src/EmailQueue.API/EmailQueue.API.csproj b/src/EmailQueue.API/EmailQueue.API.csproj index 8d2a9c9..363a91a 100644 --- a/src/EmailQueue.API/EmailQueue.API.csproj +++ b/src/EmailQueue.API/EmailQueue.API.csproj @@ -15,6 +15,8 @@ runtime; build; native; contentfiles; analyzers; buildtransitive + + diff --git a/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs b/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs index 94e5ae7..4c0dc26 100644 --- a/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs +++ b/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs @@ -160,15 +160,17 @@ public async Task ProcessEmailAsync_WhenSuccessful_MarksAsSentAndSavesChanges() using var scope = new AssertionScope(); _emailTask.Status.Should().Be("Sent"); await _emailService.Received(1).SendEmailAsync(Arg.Is(m => - m.SenderEmail == _emailTask.From && + m!.SenderEmail == _emailTask.From && m.SenderName == _emailTask.FromName && m.Recipients.Contains(_emailTask.Recipients[0]) && m.CopyRecipients.Contains(_emailTask.CopyRecipients![0]) && m.Subject == _emailTask.Subject && m.TextBody == _emailTask.Body && m.HtmlBody == null)); +#pragma warning disable CA1873 _logger.Received(2).Log(LogLevel.Information, Arg.Any(), Arg.Any(), null, Arg.Any>()); +#pragma warning restore CA1873 } [Test] @@ -186,7 +188,7 @@ public async Task ProcessEmailAsyncWithNullFromName_WhenSuccessful_SendsMessageW await _sut.ProcessEmailAsync(emailTask); // Assert - await _emailService.Received(1).SendEmailAsync(Arg.Is(m => m.SenderName == null)); + await _emailService.Received(1).SendEmailAsync(Arg.Is(m => m!.SenderName == null)); } [Test] @@ -204,6 +206,6 @@ public async Task ProcessEmailAsyncWithEmptyFromName_WhenSuccessful_SendsMessage await _sut.ProcessEmailAsync(emailTask); // Assert - await _emailService.Received(1).SendEmailAsync(Arg.Is(m => m.SenderName == string.Empty)); + await _emailService.Received(1).SendEmailAsync(Arg.Is(m => m!.SenderName == string.Empty)); } } From 9605c013d6e7625e68f4a2bfa83532701d230b25 Mon Sep 17 00:00:00 2001 From: Doug Waldron Date: Wed, 22 Jul 2026 11:13:29 -0400 Subject: [PATCH 2/2] Suppress CA1873 in unit tests --- tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs b/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs index 4c0dc26..ffda471 100644 --- a/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs +++ b/tests/EmailQueue.API.Tests/EmailProcessorServiceTests.cs @@ -11,6 +11,7 @@ namespace EmailQueue.API.Tests; +#pragma warning disable CA1873 [TestFixture] public class EmailProcessorServiceTests { @@ -167,10 +168,8 @@ await _emailService.Received(1).SendEmailAsync(Arg.Is(m => m.Subject == _emailTask.Subject && m.TextBody == _emailTask.Body && m.HtmlBody == null)); -#pragma warning disable CA1873 _logger.Received(2).Log(LogLevel.Information, Arg.Any(), Arg.Any(), null, Arg.Any>()); -#pragma warning restore CA1873 } [Test] @@ -209,3 +208,4 @@ public async Task ProcessEmailAsyncWithEmptyFromName_WhenSuccessful_SendsMessage await _emailService.Received(1).SendEmailAsync(Arg.Is(m => m!.SenderName == string.Empty)); } } +#pragma warning restore CA1873