Skip to content

Renaming Favorites #14

Description

@AlexKempen

We should add the ability to rename favorites.

I think the logical place to start is renaming in-line, so a context menu option that makes the favorite title editable. I think for routes you can probably delete the current set-default-configuration endpoint and instead add the defaultConfiguration and name as optional parameters to the endpoint, similar to what we do for user settings today.

That also makes it possible for new favorites (from the insert menu) to have the current configuration automatically set as their default configuration, which I think is a nice bonus.

Also, don't forget to hide the rename favorite option in the insert menu (which will become an option once #10 is implemented.)

In the future I could also see being able to rename a favorite in the insert (and/or set-default-configuration menu, which should probably just get moved into the regular insert menu), but one caveat there is we probably need to first update to start drawing the distinction between inserting a favorite and inserting a part that you've favorited (since renaming makes sense in the former case but not the latter, and the distinction becomes relevant once we add the ability to favorite the same part multiple times).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions