Skip to content

Commit d9ae7e4

Browse files
committed
Sync the shared review stopping rules
The commit, pull request, review, and landing rules are shared with firstdraft/firstdraft and firstdraft/skills, and the service repository is changing two of them to cut duplicate review sessions. An amendment that only applies accepted findings no longer needs a re-review, and a review whose only trigger is an instruction-policy change runs once at high effort instead of max. Keep this copy in step so following it does not bring the extra sessions back.
1 parent 6fb3c19 commit d9ae7e4

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ codex plugin add claude-review@cross-review
7070
To run a review:
7171

7272
1. Start a `new` session over the branch, such as `new branch main`, or over an explicit range with
73-
`new range <base>..<head>`.
73+
`new range <base>..<head>`. When an instruction-policy change is the only reason for review, run that one session
74+
with `--effort high` instead of the default `max`.
7475
2. Pass the service repository's `docs/review-focus.md` with `--focus-file`, from a sibling `firstdraft/firstdraft`
7576
checkout or fetched into the ignored `tmp/`:
7677

@@ -84,8 +85,9 @@ To run a review:
8485

8586
3. When the review finishes, the host agent runs `cite` and checks each finding against the cited lines before
8687
relaying it.
87-
4. Record each decision after `--` as `reject F-...: reason`, `accept F-...`, or `defer F-...`. Review an amendment
88-
in the same session with `range <reviewed-head>..HEAD`.
88+
4. Record each decision after `--` as `reject F-...: reason`, `accept F-...`, or `defer F-...`. Re-review an
89+
amendment only when it does more than apply accepted findings, in the same session with
90+
`range <reviewed-head>..HEAD`.
8991

9092
Do not merge while a required review is still running. Review third-party changes, such as Dependabot or outside
9193
pull requests, with `--capability read-only`.

0 commit comments

Comments
 (0)