From df3ff15347fd7fc6336f3efa0386f0a51f6dceef Mon Sep 17 00:00:00 2001
From: Safal Shrestha <safal@sociair.com>
Date: Thu, 20 Aug 2026 08:51:32 +0545
Subject: [PATCH] Cover the ordering lock release in cfworkers

processMessage() hands back a release() callback after it takes an
ordering key lock, and the point of that callback is to delete the lock
so the next message for the same key can run.  Nothing checked it, so a
release() that quietly stopped deleting would have stalled every ordered
queue without failing a test.

Rather than only asserting the key is gone, the test pushes a second
message through the same ordering key and expects it to be processed,
which is the behaviour users actually depend on.

MockKvNamespace.get() threw unless it was called in JSON mode, while
processMessage() reads the lock as a plain string, so the mock now
returns the raw value for an untyped get().

See https://github.com/fedify-dev/fedify/issues/880

Changelog: none
Assisted-by: Claude Code:claude-opus-5
---
 packages/cfworkers/src/mod.test.ts | 33 ++++++++++++++++++++++++++----
 1 file changed, 29 insertions(+), 4 deletions(-)

diff --git a/packages/cfworkers/src/mod.test.ts b/packages/cfworkers/src/mod.test.ts
index 9a0c78d6d..0ed720606 100644
--- a/packages/cfworkers/src/mod.test.ts
+++ b/packages/cfworkers/src/mod.test.ts
@@ -64,12 +64,9 @@ class MockKvNamespace implements WorkersKvNamespaceLike {
     type: "json",
   ): Promise<ExpectedValue | null>;
   get(key: string, type?: "json") {
-    if (type !== "json") {
-      throw new Error("MockKvNamespace only uses the JSON mode of get().");
-    }
-
     const entry = this.entries.get(key);
     if (entry == null) return Promise.resolve(null);
+    if (type !== "json") return Promise.resolve(entry.value);
     return Promise.resolve(JSON.parse(entry.value));
   }
 
@@ -326,4 +323,32 @@ describe("WorkersMessageQueue", () => {
         "Use Federation.processQueuedTask() method instead.",
     );
   });
+
+  it("processMessage() - release() frees the ordering lock", async () => {
+    const orderingKv = new MockKvNamespace();
+    const queue = new WorkersMessageQueue(mockQueue, { orderingKv });
+
+    const first = await queue.processMessage({
+      __fedify_ordering_key__: "actor-1",
+      __fedify_payload__: { id: "first" },
+    });
+
+    expect(first.shouldProcess).toBe(true);
+    expect(first.message).toEqual({ id: "first" });
+    expect(orderingKv.entries.has("__fedify_ordering_actor-1")).toBe(true);
+
+    await first.release?.();
+
+    expect(orderingKv.entries.has("__fedify_ordering_actor-1")).toBe(false);
+
+    // Releasing is only meaningful if it lets the next message through, so
+    // check the queue actually moves rather than just that the key is gone.
+    const second = await queue.processMessage({
+      __fedify_ordering_key__: "actor-1",
+      __fedify_payload__: { id: "second" },
+    });
+
+    expect(second.shouldProcess).toBe(true);
+    expect(second.message).toEqual({ id: "second" });
+  });
 });