From df2b5e1df4308a9d2d92313173ecd21d389e5eca Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:32:50 -0700 Subject: [PATCH 01/31] Use latest eisop --- guava/cfMavenCentral.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guava/cfMavenCentral.xml b/guava/cfMavenCentral.xml index e47a4da8cefb..a29cf98402bf 100644 --- a/guava/cfMavenCentral.xml +++ b/guava/cfMavenCentral.xml @@ -67,7 +67,7 @@ io.github.eisop checker-qual - 3.42.0-eisop5 + 3.49.1-eisop1 com.google.errorprone From 4f0811bcbb329c47c89fe65d99e64198881df50a Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:32:59 -0700 Subject: [PATCH 02/31] Add versions --- guava/pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/guava/pom.xml b/guava/pom.xml index 5ae03223aef3..bce18d920c43 100644 --- a/guava/pom.xml +++ b/guava/pom.xml @@ -64,14 +64,17 @@ io.github.eisop checker-qual + 0.0.0 io.github.eisop checker-util + 0.0.0 io.github.eisop checker + 0.0.0 com.google.errorprone From ba7deeb18fb43985d25e0824cd644ec5e5358bdf Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:35:42 -0700 Subject: [PATCH 03/31] Add more versions --- android/guava-tests/pom.xml | 1 + guava-testlib/pom.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/android/guava-tests/pom.xml b/android/guava-tests/pom.xml index 69d9bcc13727..6e7047b6cc1b 100644 --- a/android/guava-tests/pom.xml +++ b/android/guava-tests/pom.xml @@ -28,6 +28,7 @@ org.checkerframework checker-qual + 0.0.0 com.google.errorprone diff --git a/guava-testlib/pom.xml b/guava-testlib/pom.xml index 16f1310b4647..8b1d678c4b1b 100644 --- a/guava-testlib/pom.xml +++ b/guava-testlib/pom.xml @@ -21,6 +21,7 @@ io.github.eisop checker-qual + 0.0.0 com.google.errorprone From 25fd508a21081e16ac453e852bdda85c206a5e1b Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:37:03 -0700 Subject: [PATCH 04/31] Add more versions --- guava-tests/pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/guava-tests/pom.xml b/guava-tests/pom.xml index 487402a7ec1f..bae7aa41c0d1 100644 --- a/guava-tests/pom.xml +++ b/guava-tests/pom.xml @@ -28,6 +28,7 @@ io.github.eisop checker-qual + 0.0.0 com.google.errorprone From 66a2422b281ffc1ae143838c98f0c592ea5638c2 Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:40:43 -0700 Subject: [PATCH 05/31] Add more versions --- android/guava-testlib/pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/android/guava-testlib/pom.xml b/android/guava-testlib/pom.xml index 044d5cdd8433..c3671839b7bd 100644 --- a/android/guava-testlib/pom.xml +++ b/android/guava-testlib/pom.xml @@ -21,6 +21,7 @@ org.checkerframework checker-qual + 0.0.0 com.google.errorprone From 8ce33c7e140d492022c8226e6ff0f8adfdc1b0b8 Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:44:56 -0700 Subject: [PATCH 06/31] Use latest eisop --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 44d8ccf374c4..0c9a581be237 100644 --- a/pom.xml +++ b/pom.xml @@ -16,7 +16,7 @@ %regex[.*.class] 1.4.2 3.0.2 - 3.42.0-eisop5 + 3.49.1-eisop1 2.26.1 3.0.0 9+181-r4173-1 From 354ab44cf18d3f8d558ef5e794b9099d105cddaf Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:50:19 -0700 Subject: [PATCH 07/31] Use checker.version --- android/guava-testlib/pom.xml | 2 +- android/guava-tests/pom.xml | 2 +- guava-testlib/pom.xml | 2 +- guava-tests/pom.xml | 2 +- guava/pom.xml | 6 +++--- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/android/guava-testlib/pom.xml b/android/guava-testlib/pom.xml index c3671839b7bd..e11380b403ee 100644 --- a/android/guava-testlib/pom.xml +++ b/android/guava-testlib/pom.xml @@ -21,7 +21,7 @@ org.checkerframework checker-qual - 0.0.0 + ${checker.version} com.google.errorprone diff --git a/android/guava-tests/pom.xml b/android/guava-tests/pom.xml index 6e7047b6cc1b..3b3ac6f6a34e 100644 --- a/android/guava-tests/pom.xml +++ b/android/guava-tests/pom.xml @@ -28,7 +28,7 @@ org.checkerframework checker-qual - 0.0.0 + ${checker.version} com.google.errorprone diff --git a/guava-testlib/pom.xml b/guava-testlib/pom.xml index 8b1d678c4b1b..f7cc02790724 100644 --- a/guava-testlib/pom.xml +++ b/guava-testlib/pom.xml @@ -21,7 +21,7 @@ io.github.eisop checker-qual - 0.0.0 + ${checker.version} com.google.errorprone diff --git a/guava-tests/pom.xml b/guava-tests/pom.xml index bae7aa41c0d1..20c1e543361f 100644 --- a/guava-tests/pom.xml +++ b/guava-tests/pom.xml @@ -28,7 +28,7 @@ io.github.eisop checker-qual - 0.0.0 + ${checker.version} com.google.errorprone diff --git a/guava/pom.xml b/guava/pom.xml index bce18d920c43..f27eb73d3e9e 100644 --- a/guava/pom.xml +++ b/guava/pom.xml @@ -64,17 +64,17 @@ io.github.eisop checker-qual - 0.0.0 + ${checker.version} io.github.eisop checker-util - 0.0.0 + ${checker.version} io.github.eisop checker - 0.0.0 + ${checker.version} com.google.errorprone From 6dfe27b8ff7a8e2158c182d5092bf1f9bbd03e89 Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:50:29 -0700 Subject: [PATCH 08/31] Use latest eisop --- android/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/pom.xml b/android/pom.xml index 309297a700e4..97832b9fd632 100644 --- a/android/pom.xml +++ b/android/pom.xml @@ -16,7 +16,7 @@ %regex[.*.class] 1.4.2 3.0.2 - 3.34.0-eisop1 + 3.49.1-eisop1 2.26.1 3.0.0 9+181-r4173-1 From 92a706861f1483d2b7b3f55e1b6666174b1ab55e Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 14:58:49 -0700 Subject: [PATCH 09/31] Try latest errorprone --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0c9a581be237..fc28de93d979 100644 --- a/pom.xml +++ b/pom.xml @@ -17,7 +17,7 @@ 1.4.2 3.0.2 3.49.1-eisop1 - 2.26.1 + 2.42.0 3.0.0 9+181-r4173-1 From 5b404bbdd32816dda893e3b60b33687f223343c9 Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Mon, 6 Oct 2025 15:01:39 -0700 Subject: [PATCH 10/31] Try disable errorprone --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fc28de93d979..8189642d7138 100644 --- a/pom.xml +++ b/pom.xml @@ -465,7 +465,7 @@ be passed as part of the same as -Xplugin:ErrorProne, and I gave up trying to figure out how to do that for test compilation only. --> - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + - + -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR - + -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + - - + -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR - - + -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR From 3d7073a2c7332c1b3565b87f2134fdf6d2707246 Mon Sep 17 00:00:00 2001 From: Aosen Xiong Date: Sat, 1 Aug 2026 01:37:14 -0400 Subject: [PATCH 27/31] Scope Error Prone away from guava-tests --- android/guava-tests/pom.xml | 7 +++++++ android/pom.xml | 3 ++- guava-tests/pom.xml | 7 +++++++ pom.xml | 3 ++- 4 files changed, 18 insertions(+), 2 deletions(-) diff --git a/android/guava-tests/pom.xml b/android/guava-tests/pom.xml index e6bbd464cbc2..4030f8a895dd 100644 --- a/android/guava-tests/pom.xml +++ b/android/guava-tests/pom.xml @@ -69,6 +69,13 @@ maven-compiler-plugin + + + -sourcepath + doesnotexist + -XDcompilePolicy=simple + + maven-source-plugin diff --git a/android/pom.xml b/android/pom.xml index 8345bafe9d11..7f40197ca995 100644 --- a/android/pom.xml +++ b/android/pom.xml @@ -18,6 +18,7 @@ 3.0.2 3.49.5-eisop1 2.26.1 + -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR 3.0.0 9+181-r4173-1 @@ -463,7 +464,7 @@ be passed as part of the same as -Xplugin:ErrorProne, and I gave up trying to figure out how to do that for test compilation only. --> - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + ${errorprone.compiler.arg} @@ -468,7 +469,7 @@ be passed as part of the same as -Xplugin:ErrorProne, and I gave up trying to figure out how to do that for test compilation only. --> - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + ${errorprone.compiler.arg} @@ -464,7 +463,7 @@ be passed as part of the same as -Xplugin:ErrorProne, and I gave up trying to figure out how to do that for test compilation only. --> - ${errorprone.compiler.arg} + -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR @@ -469,7 +468,7 @@ be passed as part of the same as -Xplugin:ErrorProne, and I gave up trying to figure out how to do that for test compilation only. --> - ${errorprone.compiler.arg} + -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR + + - -Xplugin:ErrorProne -Xep:NullArgumentForNonNullParameter:OFF -Xep:Java8ApiChecker:ERROR +