Webhooks not getting created

[dgrigg]

Description

I have setup all the required Shopify ENV vars and locally when creating webhooks (via an Expose url) they are registered and show up in the CP / Shopify / Webhooks list. I can see those registered webhook endpoints on both the local website and the live website. When I go to the live website CP and try to register webhooks for that url I get the flash message saying the webhooks were created but none show up in the webhooks list.

Additional info

• Craft version: 5.8.18
• PHP version: 8.3.28
• Database driver & version: Mysql 8.0.36
• Plugins & versions: Craft Shopify 6.1.2

[linear]

PT-3016

[dgrigg]

Doing some digging, it looks like the WebhooksController actionCreate is not properly catching the userErrors in the response body

{
  "data": {
    "webhookSubscriptionCreate": {
      "webhookSubscription": null,
      "userErrors": [
        {
          "field": [
            "webhookSubscription",
            "callbackUrl"
          ],
          "message": "Address cannot be any of the domains: [redacted].myshopify.com, [redacted].com, www.[redacted].com, checkout.[redacted].com, [redacted].account.myshopify.com"
        }
      ]
    }
  },
  "extensions": {
    "cost": {
      "requestedQueryCost": 10,
      "actualQueryCost": 10,
      "throttleStatus": {
        "maximumAvailable": 20000,
        "currentlyAvailable": 19990,
        "restoreRate": 1000
      }
    }
  }
} {
  "memory": 7106336
}

[AugustMiller]

As part of our new authentication scheme work, we've greatly improved how our API client handles errors on the 7.x branch.

I'm curious what triggered this particular error, though—was the plugin actually trying to create webhook subscriptions under one of these forbidden hostnames, or was that a red herring?