Skip to content

orchestrate: Phase 4 review is one sentence — give it a fixed four-lens pass #82

Description

@choiyounggi

Problem

skills/orchestrate/SKILL.md:479-482 is the entire Phase 4 review method:

Review each worktree diff (git -C <wt> diff <integ>...HEAD); if a session's
tests look weak, cross-call test-quality-auditor yourself.

No checklist, no wiki grounding, no obligation to look across worktrees. The only
mechanised part is test quality — code correctness and design get whatever the
coordinator improvises.

Proposal

Replace the sentence with a fixed pass of four lenses:

  1. Plan conformance — diff against the plan's decision→page map and the brief's
    <scope_boundaries> / <out_of_scope>. A decision silently made differently at
    implement time is a defect even when the code works.
  2. Wiki re-route from the diff — the pass from review: route the wiki from the diff, not only from the plan's intent #81; report the page set the
    reviewer reached that the plan never named.
  3. Execution-environment reality — for any newly introduced flag, subcommand,
    API or dependency: confirm it exists in the version present where the code
    actually runs
    (CI image, the worker's runtime, the user's shell), not on the
    machine that wrote it.
  4. Multi-object write ordering — any change writing 2+ files/objects/rows
    without a transaction, and any ordering a concurrent reader can observe
    mid-flight.

Lens 4 is coordinator-only leverage: the coordinator is the single reviewer that
sees every worktree at once.
A worker reviewing its own worktree structurally
cannot see a cross-task ordering hazard.

Why these four

Lenses 3 and 4 are the two defect classes from
"Reviewing code is a skill"
that the LLM reviewer missed and the human caught (--progress-seconds absent in
the CI's older AWS CLI; a tarball uploaded before its sidecar checksum, so a reader
that fails closed breaks if the job dies between the two writes).

Scope

Evidence status

The gap is verified (the quoted lines are the whole method). The four-lens
decomposition is a design proposal.

Source

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions