Sonar: duplication — 9,792 duplicated lines (4.8%) across 139 files in 439 blocks

[sirdeggen]

Tracking issue for #38.

SonarCloud reports:

• 9,792 duplicated lines (4.8% density)
• 439 duplicated blocks
• 139 duplicated files

Suggested approach

1. Pull the duplications report from SonarCloud UI for top-offending file pairs.
2. Extract shared helpers into a utils or internal module per package.
3. For cross-package duplication (e.g. similar transaction-builder logic in helpers/bsv-wallet-helper and wallet/wallet-toolbox), evaluate whether a shared internal package is appropriate.

Reproduce

SonarCloud UI: https://sonarcloud.io/component_measures?id=bsv-blockchain_ts-stack&metric=duplicated_lines_density

Refs: #38

[sirdeggen]

Progress update (post-merge)

PR #55 merged (5f95c80). Extracted StorageClientBase + entityValidationHelpers + validateSyncChunkEntities. ~840 dup lines consolidated across StorageClient, StorageMobile, StorageServer in packages/wallet/wallet-toolbox/src/storage/remoting/.

Sonar metrics for that PR: new_duplicated_lines_density 7.5% → 0%.

Follow-up needed

Sonar QG flagged new_coverage = 0% on the extracted helpers. The helpers are pure utility functions that lend themselves to unit tests (no DB/storage dep needed). Suggest a follow-up PR to add coverage for:

• entityValidationHelpers.ts — validateDate, validateEntity, validateEntities, validateSyncChunkEntities
• StorageClientBase (test through one concrete subclass with mocks)

Remaining repo-wide

Sonar's overall duplication metrics still apply (439 blocks, 139 files, 4.8% density). One pair done as proof-of-pattern; many more candidates remain. Keep open.

[ty-everett]

Deferred by operator instruction; keeping this issue open for any genuinely needed Sonar baseline work. PR #320 passed the CI Sonar quality gate with zero new issues, 0.0% new-code duplication, A ratings for new reliability/security/maintainability, and 100% reviewed new-code hotspots. No Sonar organization setting was changed. The remaining decision is the organization-admin switch from Automatic Analysis to the CI scanner and whether legacy baseline cleanup is still worthwhile after that switch.

[ty-everett]

Wave 31 exact-main update (2026-07-29): PR #390 moved duplication from 9,383 to 9,376 lines while density remained 1.5% on main@f9f2ecdd4910d48ead2ce6db560cdc886ee60d4a; the strict PR gate also passed at 0.9% new-code duplication. Keep this issue open for the measured consolidation backlog in #324. Any consolidation must improve auditability and retain exact public API/protocol/storage/error/order/default behavior; intentionally parallel tests, service-local telemetry, generated policy copies, and consensus dispatch are not to be forced into unsafe abstractions merely to reduce the metric. Nothing was published.

[ty-everett]

Closing this legacy duplication ledger after Wave 37 / #398 completed the review and durable governance of the named clusters. Exact main@2acc82b0b measures 9,646 duplicated lines at 1.5% (down from the issue's 9,792 / 4.8% baseline). Actionable unsafe duplication was consolidated; retained cryptographic fixtures and service/package/protocol boundaries are now recorded with owner, rationale, review date, and removal/equivalence conditions in governance/duplication-policy.json, enforced by CI and documented in docs/reference/duplication-governance.md. Closure therefore reflects full disposition and ongoing control—not an inappropriate target of zero textual duplication.