Skip to content

Bug - port not being cross-checked in binary stdout #8

Description

@ptrckbp

The issue is :

  • use a service on port 3000, say express.js.
  • launch Botpress
  • for some reason, during Botpress's port-checking step, it doesn't detect the port as occupied.
  • Botpress will run the binary on port 3000, but the binary will auto-fix on 3001 (or the next available port)
  • Botpress will open port 3000

You can also cause this issue by running a service on port 3000 right after Botpress checks the port.

I'm not sure how common this is. I haven't seen it yet in testing, but the fix isn't that difficult. Just grab the "botpress is listening on localhost:3001" message and regex the port from it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions