Skip to content

assert.Equal panics on unexported fields #8

Description

@sparks

Given two unequal structs from another package with unexported fields assert.Equal will panic.

Example with time package

package asserttest

import (
    "github.com/bmizerany/assert"
    "testing"
    "time"
)

func TestBreakAssert(t *testing.T) {
    assert.Equal(t, time.Now(), time.Unix(0, 0))
}

Example with an invented struct

asserttest/assert_test.go

package asserttest

import (
    "other"
    "github.com/bmizerany/assert"
    "testing"
)

func TestBreakAssert2(t *testing.T) {
    a := new(other.Other)
    a.Outer = 2
    b := new(other.Other)
    b.Outer = 4
    assert.Equal(t, a, b)
}

other/other.go

package other

type Other struct {
    Outer int
    inner int
}

Both these snippets panic like so

panic: reflect.Value.Interface: cannot return value obtained from unexported field or method [recovered]
panic: reflect.Value.Interface: cannot return value obtained from unexported field or method
etc ...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions