From b22a047abf76183b92a5f70f768db2c63f9e3177 Mon Sep 17 00:00:00 2001 From: ZeKraken <79888567+zekraken-bot@users.noreply.github.com> Date: Tue, 18 Aug 2026 13:00:35 -0400 Subject: [PATCH] remove kelp l2 rps --- .../RsETHWrapperRateProviderReview717e.md | 31 -------- .../RsETHWrapperRateProviderReviewacb1.md | 31 -------- rate-providers/registry.json | 64 --------------- rate-providers/rsETHRateProviderArbitrum.md | 79 ------------------- rate-providers/rsETHRateProviderOptimism.md | 79 ------------------- 5 files changed, 284 deletions(-) delete mode 100644 rate-providers/RsETHWrapperRateProviderReview717e.md delete mode 100644 rate-providers/RsETHWrapperRateProviderReviewacb1.md delete mode 100644 rate-providers/rsETHRateProviderArbitrum.md delete mode 100644 rate-providers/rsETHRateProviderOptimism.md diff --git a/rate-providers/RsETHWrapperRateProviderReview717e.md b/rate-providers/RsETHWrapperRateProviderReview717e.md deleted file mode 100644 index 0db0b89e..00000000 --- a/rate-providers/RsETHWrapperRateProviderReview717e.md +++ /dev/null @@ -1,31 +0,0 @@ - -# Rate Provider: rsETHWrapper rate provider - -## Details -This report was autogenerated on 04/09/2025. - -- Deployed at: - - [Sonic:0x5c08Bbc2C47447854958060725e437E6Dd003332](https://sonicscan.org/address/0x5c08Bbc2C47447854958060725e437E6Dd003332) -- Audit report(s): - - [Audits]() - -## Context - - -## Review Checklist: Bare Minimum Compatibility -Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. - -- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. -- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. - -### Administrative Privileges -- [ ] The Rate Provider is upgradeable** (e.g., via a proxy architecture). -- [ ] Other contracts which are part of the `getRate` callchain are upgradeable**. You can find more information - about the involved contracts in this [tenderly simulation](https://www.tdly.co/shared/simulation/cdb31da2-0ea5-4155-a30f-eaeff42c4b79) - -## Conclusion -**Summary judgment: USABLE** - -** upgradeable in this context means that: -- The contract is a proxy contract with an implementation sourced from Etherscan and the proxy emitted an "Upgraded" event. - diff --git a/rate-providers/RsETHWrapperRateProviderReviewacb1.md b/rate-providers/RsETHWrapperRateProviderReviewacb1.md deleted file mode 100644 index 7a6a3967..00000000 --- a/rate-providers/RsETHWrapperRateProviderReviewacb1.md +++ /dev/null @@ -1,31 +0,0 @@ - -# Rate Provider: rsETHWrapper rate provider - -## Details -This report was autogenerated on 29/09/2025. - -- Deployed at: - - [Plasma:0xF1fD29270e61D4a7885E9B4EF6476Daf2Ab6F85D](https://plasmascan.to//address/0xF1fD29270e61D4a7885E9B4EF6476Daf2Ab6F85D) -- Audit report(s): - - [Audits](https://kelp.gitbook.io/kelp/audits) - -## Context -rsETH is a Liquid Restaked Token (LRT) issued by Kelp DAO designed to offer liquidity to illiquid assets deposited into restaking platforms,such as EigenLayer. It aims to address the risks and challenges posed by the current offering of restaking - -## Review Checklist: Bare Minimum Compatibility -Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. - -- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. -- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. - -### Administrative Privileges -- [ ] The Rate Provider is upgradeable** (e.g., via a proxy architecture). -- [ ] Other contracts which are part of the `getRate` callchain are upgradeable**. You can find more information - about the involved contracts in this [tenderly simulation](https://www.tdly.co/shared/simulation/9bf44d2d-290e-46a0-8076-c5df25b3b73c) - -## Conclusion -**Summary judgment: USABLE** - -** upgradeable in this context means that: -- The contract is a proxy contract with an implementation sourced from Etherscan and the proxy emitted an "Upgraded" event. - diff --git a/rate-providers/registry.json b/rate-providers/registry.json index e3a85772..6f8ceff0 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -240,38 +240,6 @@ } ] }, - "0x3222d3De5A9a3aB884751828903044CC4ADC627e": { - "asset": "0x4186BFC76E2E237523CBC30FD220FE055156b41F", - "name": "RsETHRateProvider", - "summary": "safe", - "review": "./rsETHRateProviderArbitrum.md", - "warnings": [ - "donation" - ], - "factory": "", - "upgradeableComponents": [ - { - "entrypoint": "0x349A73444b1a310BAe67ef67973022020d70020d", - "implementationReviewed": "0x8B9991f89Fc31600DCE064566ccE28dC174Fb8E4" - }, - { - "entrypoint": "0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7", - "implementationReviewed": "0xc5cD38d47D0c2BD7Fe18c64a50c512063DC29700" - }, - { - "entrypoint": "0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7", - "implementationReviewed": "0x60FF20BACD9A647e4025Ed8b17CE30e40095A1d2" - }, - { - "entrypoint": "0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2", - "implementationReviewed": "0x0379E85188BC416A1D43Ab04b28F38B5c63F129E" - }, - { - "entrypoint": "0x8546A7C8C3C537914C3De24811070334568eF427", - "implementationReviewed": "0xD7DB9604EF925aF96CDa6B45026Be64C691C7704" - } - ] - }, "0x3a216B01db971Bf28D171C9dA44Cc8C89867697F": { "asset": "0xCA5d8F8a8d49439357d3CF46Ca2e720702F132b8", "name": "ConstantRateProvider", @@ -3394,20 +3362,6 @@ "factory": "0x83E443EF4f9963C77bd860f94500075556668cb8", "upgradeableComponents": [] }, - "0x1373A61449C26CC3F48C1B4c547322eDAa36eB12": { - "asset": "0x4186BFC76E2E237523CBC30FD220FE055156b41F", - "name": "RSETHRateReceiver", - "summary": "safe", - "review": "./rsETHRateProviderOptimism.md", - "warnings": [], - "factory": "", - "upgradeableComponents": [ - { - "entrypoint": "0x1373A61449C26CC3F48C1B4c547322eDAa36eB12", - "implementationReviewed": "0x1373A61449C26CC3F48C1B4c547322eDAa36eB12" - } - ] - }, "0x0643b504c2fa33b7f98a99b92138d94d372998de": { "asset": "0x61b620FAd391b53A2D0973b10a3Ed69558d5c66E", "name": "WrappedAaveOptimism DAIRateProvider.md", @@ -4116,15 +4070,6 @@ "factory": "", "upgradeableComponents": [] }, - "0x5c08Bbc2C47447854958060725e437E6Dd003332": { - "asset": "0x7c050be1dded733bd44116b60a8a35125ba47459", - "name": "RsETHWrapperRateProvider.md", - "summary": "safe", - "review": "./RsETHWrapperRateProviderReview717e.md", - "warnings": [], - "factory": "", - "upgradeableComponents": [] - }, "0xc76995054ce51dfbbc954840d699b2f33d2538ee": { "asset": "0xc76995054ce51dfbbc954840d699b2f33d2538ee", "name": "BeetsLoopedSonicRateProvider.md", @@ -4734,15 +4679,6 @@ "factory": "", "upgradeableComponents": [] }, - "0xF1fD29270e61D4a7885E9B4EF6476Daf2Ab6F85D": { - "asset": "0xe561fe05c39075312aa9bc6af79ddae981461359", - "name": "RsETHWrapperRateProvider.md", - "summary": "safe", - "review": "./RsETHWrapperRateProviderReviewacb1.md", - "warnings": [], - "factory": "", - "upgradeableComponents": [] - }, "0x2b0d44eD7D1A940bE7c19a1d46569c08a5Fb6978": { "asset": "0xC4374775489CB9C56003BF2C9b12495fC64F0771", "name": "SyrupUSDTRateProvider.md", diff --git a/rate-providers/rsETHRateProviderArbitrum.md b/rate-providers/rsETHRateProviderArbitrum.md deleted file mode 100644 index 14c8334c..00000000 --- a/rate-providers/rsETHRateProviderArbitrum.md +++ /dev/null @@ -1,79 +0,0 @@ -# Rate Provider: `RSETHRateReceiver` - -## Details -- Reviewed by: @mkflow27 -- Checked by: @danielmkm -- Deployed at: - - [arbitrum:0x3222d3De5A9a3aB884751828903044CC4ADC627e](https://arbiscan.io/address/0x3222d3de5a9a3ab884751828903044cc4adc627e#code) -- Audit report(s): - - [Kelp audits](https://kelp.gitbook.io/kelp/audits) - -## Context -rsETH is a Liquid Restaked Token (LRT) issued by Kelp DAO designed to offer liquidity to illiquid assets deposited into restaking platforms, such as EigenLayer. It aims to address the risks and challenges posed by the current offering of restaking. The Rate Provider reports the exchange Rate of rsETH - ETH. - -## Review Checklist: Bare Minimum Compatibility -Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. - -- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. -- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. - -## Review Checklist: Common Findings -Each of the items below represents a common red flag found in Rate Provider contracts. - -If none of these is checked, then this might be a pretty great Rate Provider! If any of these is checked, we must thoroughly elaborate on the conditions that lead to the potential issue. Decision points are not binary; a Rate Provider can be safe despite these boxes being checked. A check simply indicates that thorough vetting is required in a specific area, and this vetting should be used to inform a holistic analysis of the Rate Provider. - -### Administrative Privileges -- [x] The Rate Provider is upgradeable (e.g., via a proxy architecture or an `onlyOwner` function that updates the price source address). - - admin address: [arbitrum:0x96D97D66d4290C9182A09470a5775FF90DAf922c](https://arbiscan.io/address/0x96D97D66d4290C9182A09470a5775FF90DAf922c) - - admin type: multisig - - multisig threshold/signers: 2/4 - - comment: The main access control check is done by comparing the `msg.sender` against the `layerZeroEndpoint`. The `layerZeroEndpoint` endpoint address can be upgraded by the RateProviders admin via: `updateLayerZeroEndpoint`. - -- [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). - - upgradeable component: `LRTOracle` ([ethereum:0x349A73444b1a310BAe67ef67973022020d70020d](https://etherscan.io/address/0x349A73444b1a310BAe67ef67973022020d70020d)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - - - upgradeable component: `LRTConfig` ([ethereum:0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7](https://etherscan.io/address/0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7#code)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - - - upgradeable component: `RSETH` ([ethereum:0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7](https://etherscan.io/address/0xa1290d69c65a6fe4df752f95823fae25cb99e5a7)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - - - upgradeable component: `EthXPriceOracle` ([ethereum:0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2](https://etherscan.io/address/0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2#readProxyContract)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - - - upgradeable component: `SfrxETHPriceOracle` ([ethereum:0x8546A7C8C3C537914C3De24811070334568eF427](https://etherscan.io/address/0x8546A7C8C3C537914C3De24811070334568eF427#readProxyContract)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - - - -### Oracles -- [ ] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). - -- [ ] Price data is expected to be volatile (e.g., because it represents an open market price instead of a (mostly) monotonically increasing price). - -### Common Manipulation Vectors -- [ ] The Rate Provider is susceptible to donation attacks. - - -## Additional Findings -To save time, we do not bother pointing out low-severity/informational issues or gas optimizations (unless the gas usage is particularly egregious). Instead, we focus only on high- and medium-severity findings which materially impact the contract's functionality and could harm users. - -### M-01: Hardcoded stETH price -The rsETH pricing logic loops over the involved assets pricing oracles. This includes the [pricing oracle for stETH](https://etherscan.io/address/0x4cB8d6DCd56d6b371210E70837753F2a835160c4#code). The price of stETH in the Rate Provider pricing system is set to 1e18 which can pose a risk depending on LIDOs operational staking integrity. -Recommendation: Consider replacing the hardcoded value to incorporate for example a stETH/ETH Chainlink price feed. - -## Conclusion -**Summary judgment: SAFE** - -This rate Provider can be considered fit for pool operations under the assumption that the stETH/ETH peg holds at 1:1. This should be made clear to users in the Balancer Pool. diff --git a/rate-providers/rsETHRateProviderOptimism.md b/rate-providers/rsETHRateProviderOptimism.md deleted file mode 100644 index 881a0309..00000000 --- a/rate-providers/rsETHRateProviderOptimism.md +++ /dev/null @@ -1,79 +0,0 @@ -# Rate Provider: `RSETHRateReceiver` - -## Details -- Reviewed by: @mkflow27 -- Checked by: @danielmkm -- Deployed at: - - [optimism:0x1373A61449C26CC3F48C1B4c547322eDAa36eB12](https://optimistic.etherscan.io/address/0x1373A61449C26CC3F48C1B4c547322eDAa36eB12#code) -- Audit report(s): - - [Kelp audits](https://kelp.gitbook.io/kelp/audits) - -## Context -rsETH is a Liquid Restaked Token (LRT) issued by Kelp DAO designed to offer liquidity to illiquid assets deposited into restaking platforms, such as EigenLayer. It aims to address the risks and challenges posed by the current offering of restaking. The Rate Provider reports the exchange Rate of rsETH - ETH. - -## Review Checklist: Bare Minimum Compatibility -Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. - -- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. -- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. - -## Review Checklist: Common Findings -Each of the items below represents a common red flag found in Rate Provider contracts. - -If none of these is checked, then this might be a pretty great Rate Provider! If any of these is checked, we must thoroughly elaborate on the conditions that lead to the potential issue. Decision points are not binary; a Rate Provider can be safe despite these boxes being checked. A check simply indicates that thorough vetting is required in a specific area, and this vetting should be used to inform a holistic analysis of the Rate Provider. - -### Administrative Privileges -- [x] The Rate Provider is upgradeable (e.g., via a proxy architecture or an `onlyOwner` function that updates the price source address). - - admin address: [optimism:0x0d30A563e38Fe2926b37783A046004A7869adE6C](https://optimistic.etherscan.io/address/0x0d30A563e38Fe2926b37783A046004A7869adE6C) - - admin type: multisig - - multisig threshold/signers: 2/4 - - comment: The main access control check is done by comparing the `msg.sender` against the `layerZeroEndpoint`. The `layerZeroEndpoint` endpoint address can be upgraded by the RateProviders admin via: `updateLayerZeroEndpoint`. - -- [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). -- upgradeable component: `LRTOracle` ([ethereum:0x349A73444b1a310BAe67ef67973022020d70020d](https://etherscan.io/address/0x349A73444b1a310BAe67ef67973022020d70020d)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `LRTConfig` ([ethereum:0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7](https://etherscan.io/address/0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7#code)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `RSETH` ([ethereum:0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7](https://etherscan.io/address/0xa1290d69c65a6fe4df752f95823fae25cb99e5a7)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `EthXPriceOracle` ([ethereum:0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2](https://etherscan.io/address/0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2#readProxyContract)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `SfrxETHPriceOracle` ([ethereum:0x8546A7C8C3C537914C3De24811070334568eF427](https://etherscan.io/address/0x8546A7C8C3C537914C3De24811070334568eF427#readProxyContract)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - - - -### Oracles -- [ ] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). - -- [ ] Price data is expected to be volatile (e.g., because it represents an open market price instead of a (mostly) monotonically increasing price). - -### Common Manipulation Vectors -- [ ] The Rate Provider is susceptible to donation attacks. - - -## Additional Findings -To save time, we do not bother pointing out low-severity/informational issues or gas optimizations (unless the gas usage is particularly egregious). Instead, we focus only on high- and medium-severity findings which materially impact the contract's functionality and could harm users. - -### M-01: Hardcoded stETH price -The rsETH pricing logic loops over the involved assets pricing oracles. This includes the [pricing oracle for stETH](https://etherscan.io/address/0x4cB8d6DCd56d6b371210E70837753F2a835160c4#code). The price of stETH in the Rate Provider pricing system is set to 1e18 which can pose a risk depending on LIDOs operational staking integrity. -Recommendation: Consider replacing the hardcoded value to incorporate for example a stETH/ETH Chainlink price feed. - -## Conclusion -**Summary judgment: SAFE** - -This rate Provider can be considered fit for pool operations under the assumption that the stETH/ETH peg holds at 1:1. This should be made clear to users in the Balancer Pool.