From 63f38781da4ed9ee51abe361af45874e39eebe92 Mon Sep 17 00:00:00 2001
From: "Amy J. Ko" <ajko@uw.edu>
Date: Sat, 7 Nov 2026 14:49:20 -0800
Subject: [PATCH] Hide role assignments from viewers who can't see the org's
 roles.

Roles are only readable by members, or by anyone if the org is public.
Everyone else got an empty role list, so each ARCI chart and the
accountable line rendered as red "Unknown role" badges. Hide them under
the same rule as the RLS policy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 CHANGELOG                                     |   6 +
 package-lock.json                             |   4 +-
 package.json                                  |   2 +-
 src/lib/ARCI.svelte                           | 293 +++++++++---------
 .../[orgid]/process/[processid]/+page.svelte  |  88 +++---
 5 files changed, 206 insertions(+), 187 deletions(-)

diff --git a/CHANGELOG b/CHANGELOG
index e70eebf..1a04e00 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -3,6 +3,12 @@
 We'll document all notable changes in this file, including bug fixes, enhancements, and dependency updates.
 Dates should be in`YYYY-MM-DD` format and versions are in [semantic versioning](http://semver.org/) format.
 
+## v0.10.6 2026-11-07
+
+### Fixed
+
+- Process pages no longer show "Unknown role" to people who aren't logged in.
+
 ## v0.10.5 2026-11-07
 
 ### Fixed
diff --git a/package-lock.json b/package-lock.json
index d6f8e89..758162f 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
 	"name": "adminima",
-	"version": "0.10.5",
+	"version": "0.10.6",
 	"lockfileVersion": 3,
 	"requires": true,
 	"packages": {
 		"": {
 			"name": "adminima",
-			"version": "0.10.5",
+			"version": "0.10.6",
 			"dependencies": {
 				"@supabase/ssr": "^0",
 				"@sveltejs/adapter-vercel": "^7",
diff --git a/package.json b/package.json
index 5c49a0c..cb28860 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "adminima",
-	"version": "0.10.5",
+	"version": "0.10.6",
 	"private": true,
 	"scripts": {
 		"dev": "vite dev",
diff --git a/src/lib/ARCI.svelte b/src/lib/ARCI.svelte
index bc5f50e..49e02a1 100644
--- a/src/lib/ARCI.svelte
+++ b/src/lib/ARCI.svelte
@@ -7,6 +7,7 @@
 	import { getDB } from '#routes/+layout.svelte';
 	import Options from './Options.svelte';
 	import { mutate } from '#routes/errors.svelte.ts';
+	import { getOrg } from '#routes/org/[orgid]/+layout.svelte';
 
 	interface Props {
 		how: HowRow;
@@ -17,6 +18,12 @@
 
 	let { roles, how, verbose, editable }: Props = $props();
 
+	const orgContext = getOrg();
+
+	// Mirrors the roles RLS policy: only members, or anyone if the org is public, can see its roles.
+	// Without them, every assignment would render as "Unknown role", so show nothing instead.
+	let canSeeRoles = $derived(orgContext().member || orgContext().org.visibility === 'public');
+
 	const dbContext = getDB();
 	const db = $derived(dbContext());
 
@@ -50,152 +57,154 @@
 	};
 </script>
 
-<div class="arci" class:verbose>
-	<div class="slot">
-		<div class="control">
-			{#if !verbose}
-				<Level level="responsible" />
-			{/if}
-			{#if editable}
-				<Options
-					id="responsible-chooser"
-					tip="Add a role to be responsible for completing this step."
-					{options}
-					view={{ snippet: RoleItem, data: roles }}
-					empty={false}
-					searchable={roleSearch}
-					active={options.length >= 1}
-					bind:selection={responsible}
-					change={async (value) => {
-						if (value) {
-							const { error } = await mutate(
-								db.addHowRCI(how, value, 'responsible'),
-								"Couldn't add role."
-							);
-							if (error) return false;
-							responsible = undefined;
-						}
-						return true;
-					}}
-				/>
-			{/if}
+{#if canSeeRoles}
+	<div class="arci" class:verbose>
+		<div class="slot">
+			<div class="control">
+				{#if !verbose}
+					<Level level="responsible" />
+				{/if}
+				{#if editable}
+					<Options
+						id="responsible-chooser"
+						tip="Add a role to be responsible for completing this step."
+						{options}
+						view={{ snippet: RoleItem, data: roles }}
+						empty={false}
+						searchable={roleSearch}
+						active={options.length >= 1}
+						bind:selection={responsible}
+						change={async (value) => {
+							if (value) {
+								const { error } = await mutate(
+									db.addHowRCI(how, value, 'responsible'),
+									"Couldn't add role."
+								);
+								if (error) return false;
+								responsible = undefined;
+							}
+							return true;
+						}}
+					/>
+				{/if}
+			</div>
+			<div class="roles">
+				{#each how.responsible as responsible}
+					<RoleLink role={roles.find((r) => r.id === responsible)}
+						>{#if editable}
+							<Button
+								chromeless
+								tip="Remove this role from the responsible list."
+								action={() =>
+									mutate(db.removeHowRCI(how, responsible, 'responsible'), "Couldn't remove role.")}
+								>{Delete}</Button
+							>
+						{/if}</RoleLink
+					>
+				{/each}
+				{#if verbose}
+					is <Level level="responsible" verbose /> for completing this process.
+				{/if}
+			</div>
 		</div>
-		<div class="roles">
-			{#each how.responsible as responsible}
-				<RoleLink role={roles.find((r) => r.id === responsible)}
-					>{#if editable}
-						<Button
-							chromeless
-							tip="Remove this role from the responsible list."
-							action={() =>
-								mutate(db.removeHowRCI(how, responsible, 'responsible'), "Couldn't remove role.")}
-							>{Delete}</Button
-						>
-					{/if}</RoleLink
-				>
-			{/each}
-			{#if verbose}
-				is <Level level="responsible" verbose /> for completing this process.
-			{/if}
-		</div>
-	</div>
-	<div class="slot">
-		<div class="control">
-			{#if !verbose}
-				<Level level="consulted" />
-			{/if}
-			{#if editable}
-				<Options
-					id="consulted-chooser"
-					tip="Add a role to be consulted in this step."
-					{options}
-					view={{ snippet: RoleItem, data: roles }}
-					empty={false}
-					active={options.length >= 1}
-					bind:selection={consulted}
-					searchable={roleSearch}
-					change={async (value) => {
-						if (value) {
-							const { error } = await mutate(
-								db.addHowRCI(how, value, 'consulted'),
-								"Couldn't add role."
-							);
-							if (error) return false;
-							consulted = undefined;
-						}
-						return true;
-					}}
-				/>
-			{/if}
-		</div>
-		<div class="roles">
-			{#each how.consulted as consulted}
-				<RoleLink role={roles.find((r) => r.id === consulted)}
-					>{#if editable}
-						<Button
-							chromeless
-							tip="Remove this role from the consulted list."
-							action={() =>
-								mutate(db.removeHowRCI(how, consulted, 'consulted'), "Couldn't remove role.")}
-							>{Delete}</Button
-						>
-					{/if}</RoleLink
-				>
-			{/each}
-			{#if verbose}
-				is <Level level="consulted" verbose /> to complete this process.
-			{/if}
-		</div>
-	</div>
-	<div class="slot">
-		<div class="controls">
-			{#if !verbose}
-				<Level level="informed" />
-			{/if}
-			{#if editable}
-				<Options
-					id="informed-chooser"
-					tip="Add a role to be informed in this step."
-					{options}
-					view={{ snippet: RoleItem, data: roles }}
-					empty={false}
-					searchable={roleSearch}
-					bind:selection={informed}
-					active={options.length >= 1}
-					change={async (value) => {
-						if (value) {
-							const { error } = await mutate(
-								db.addHowRCI(how, value, 'informed'),
-								"Couldn't add role."
-							);
-							if (error) return false;
-							informed = undefined;
-						}
-						return true;
-					}}
-				/>
-			{/if}
+		<div class="slot">
+			<div class="control">
+				{#if !verbose}
+					<Level level="consulted" />
+				{/if}
+				{#if editable}
+					<Options
+						id="consulted-chooser"
+						tip="Add a role to be consulted in this step."
+						{options}
+						view={{ snippet: RoleItem, data: roles }}
+						empty={false}
+						active={options.length >= 1}
+						bind:selection={consulted}
+						searchable={roleSearch}
+						change={async (value) => {
+							if (value) {
+								const { error } = await mutate(
+									db.addHowRCI(how, value, 'consulted'),
+									"Couldn't add role."
+								);
+								if (error) return false;
+								consulted = undefined;
+							}
+							return true;
+						}}
+					/>
+				{/if}
+			</div>
+			<div class="roles">
+				{#each how.consulted as consulted}
+					<RoleLink role={roles.find((r) => r.id === consulted)}
+						>{#if editable}
+							<Button
+								chromeless
+								tip="Remove this role from the consulted list."
+								action={() =>
+									mutate(db.removeHowRCI(how, consulted, 'consulted'), "Couldn't remove role.")}
+								>{Delete}</Button
+							>
+						{/if}</RoleLink
+					>
+				{/each}
+				{#if verbose}
+					is <Level level="consulted" verbose /> to complete this process.
+				{/if}
+			</div>
 		</div>
-		<div class="roles">
-			{#each how.informed as informed}
-				<RoleLink role={roles.find((r) => r.id === informed)}
-					>{#if editable}
-						<Button
-							chromeless
-							tip="Remove this role from the informed list"
-							action={() =>
-								mutate(db.removeHowRCI(how, informed, 'informed'), "Couldn't remove role.")}
-							>{Delete}</Button
-						>
-					{/if}</RoleLink
-				>
-			{/each}
-			{#if verbose}
-				is <Level level="informed" verbose /> about this process and its outcomes.
-			{/if}
+		<div class="slot">
+			<div class="controls">
+				{#if !verbose}
+					<Level level="informed" />
+				{/if}
+				{#if editable}
+					<Options
+						id="informed-chooser"
+						tip="Add a role to be informed in this step."
+						{options}
+						view={{ snippet: RoleItem, data: roles }}
+						empty={false}
+						searchable={roleSearch}
+						bind:selection={informed}
+						active={options.length >= 1}
+						change={async (value) => {
+							if (value) {
+								const { error } = await mutate(
+									db.addHowRCI(how, value, 'informed'),
+									"Couldn't add role."
+								);
+								if (error) return false;
+								informed = undefined;
+							}
+							return true;
+						}}
+					/>
+				{/if}
+			</div>
+			<div class="roles">
+				{#each how.informed as informed}
+					<RoleLink role={roles.find((r) => r.id === informed)}
+						>{#if editable}
+							<Button
+								chromeless
+								tip="Remove this role from the informed list"
+								action={() =>
+									mutate(db.removeHowRCI(how, informed, 'informed'), "Couldn't remove role.")}
+								>{Delete}</Button
+							>
+						{/if}</RoleLink
+					>
+				{/each}
+				{#if verbose}
+					is <Level level="informed" verbose /> about this process and its outcomes.
+				{/if}
+			</div>
 		</div>
 	</div>
-</div>
+{/if}
 
 <style>
 	.arci {
diff --git a/src/routes/org/[orgid]/process/[processid]/+page.svelte b/src/routes/org/[orgid]/process/[processid]/+page.svelte
index a9ea82b..7e1d464 100644
--- a/src/routes/org/[orgid]/process/[processid]/+page.svelte
+++ b/src/routes/org/[orgid]/process/[processid]/+page.svelte
@@ -68,6 +68,8 @@
 	// This mirrors the row-level security policy: only admins and people with an accountable or responsible role can edit this policy.
 	let isAdmin = $derived(orgContext().admin);
 	let isMember = $derived(orgContext().member);
+	// Mirrors the roles RLS policy; without roles, assignments would all render as "Unknown role".
+	let canSeeRoles = $derived(isMember || orgContext().org.visibility === 'public');
 	let accountable = $derived(
 		$user !== null &&
 			process !== null &&
@@ -327,48 +329,50 @@
 			: undefined}
 	/>
 
-	<Header>Who</Header>
-
-	<div>
-		{#if editable}
-			{@const sortedRoles = roles.toSorted((a, b) => a.title.localeCompare(b.title))}
-			<Options
-				id="choose-accountable"
-				tip="Choose a role to be accountable for the processes outcomes."
-				options={[
-					undefined,
-					...sortedRoles.toSorted((a, b) => a.title.localeCompare(b.title)).map((role) => role.id)
-				]}
-				searchable={{
-					placeholder: 'role',
-					include: (item: string, query: string) =>
-						sortedRoles
-							.find((r) => r.id === item)
-							?.title.toLowerCase()
-							.includes(query.toLowerCase()) === true
-				}}
-				view={{ snippet: RoleItem, data: roles }}
-				selection={process.accountable ?? undefined}
-				change={async (value) =>
-					(
-						await mutate(
-							db.updateProcessAccountable(process, value ?? null),
-							"Couldn't update who's accountable."
-						)
-					).error === null}
-			/>
-		{:else if process.accountable}
-			<RoleLink role={roles.find((r) => r.id === process.accountable)} />
-		{:else}
-			No one
-		{/if}
-		is
-		<Level level="accountable" verbose /> for this processes outcomes
-		{#if how.responsible.length === 0}
-			&nbsp;(and <Level level="responsible" verbose /> for completing it, as no one else is responsible)
-		{/if}
-	</div>
-	<ARCI {how} {roles} verbose {editable} />
+	{#if canSeeRoles}
+		<Header>Who</Header>
+
+		<div>
+			{#if editable}
+				{@const sortedRoles = roles.toSorted((a, b) => a.title.localeCompare(b.title))}
+				<Options
+					id="choose-accountable"
+					tip="Choose a role to be accountable for the processes outcomes."
+					options={[
+						undefined,
+						...sortedRoles.toSorted((a, b) => a.title.localeCompare(b.title)).map((role) => role.id)
+					]}
+					searchable={{
+						placeholder: 'role',
+						include: (item: string, query: string) =>
+							sortedRoles
+								.find((r) => r.id === item)
+								?.title.toLowerCase()
+								.includes(query.toLowerCase()) === true
+					}}
+					view={{ snippet: RoleItem, data: roles }}
+					selection={process.accountable ?? undefined}
+					change={async (value) =>
+						(
+							await mutate(
+								db.updateProcessAccountable(process, value ?? null),
+								"Couldn't update who's accountable."
+							)
+						).error === null}
+				/>
+			{:else if process.accountable}
+				<RoleLink role={roles.find((r) => r.id === process.accountable)} />
+			{:else}
+				No one
+			{/if}
+			is
+			<Level level="accountable" verbose /> for this processes outcomes
+			{#if how.responsible.length === 0}
+				&nbsp;(and <Level level="responsible" verbose /> for completing it, as no one else is responsible)
+			{/if}
+		</div>
+		<ARCI {how} {roles} verbose {editable} />
+	{/if}
 
 	<Header>When</Header>