Repository navigation
DO NOT MERGE: revert #1389 to reproduce the get_agent_skill_docs misuse in evals - #1399
Draft
Alexandre Girard (girarda) wants to merge 1 commit into
Draft
Alexandre Girard (girarda) wants to merge 1 commit into
Alexandre Girard (girarda) wants to merge 1 commit into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792192459-revert-skill-docs-guidance-eval' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1792192459-revert-skill-docs-guidance-eval'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
Contributor
|
/evals |
Contributor
Code coverage overviewLanguages: Python Python / code-coverage/pytest-no-creds
View coverage of the 10 most impacted files.
Python / code-coverage/pytest
View coverage of the 10 most impacted files.
Python / code-coverage/pytest-unit
Line coverage data for the release-candidate/v1 branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
This was referenced Oct 16, 2026
Contributor
|
/evals
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not merge. Eval-only branch: it reverts #1389 (the
get_agent_skill_docsguidance rewrite) on top ofrelease-candidate/v1, so/evalscan show thecloud-mcp-evalsregression scenarios failing without the fix:scenarios/regressions/no-skill-docs-for-general-guidance.yaml: a general "load Airbyte's agent guidance on setting up a connection" request must not callget_agent_skill_docs.scenarios/regressions/no-skill-docs-with-definition-id.yaml: a registry connector definition ID must not be passed asconnector_id.Both come from a 2026-10-13 production Cloud MCP session on rc.28 where
get_agent_skill_docsfailed twice (no-args call for general guidance; definition ID → 403). The comparison run isrelease-candidate/v1with the fix. Close this PR once the comparison is recorded.Link to Devin session: https://app.devin.ai/sessions/d7c7d8e7ea9a4d49a9180b295cdcf06b
Open in Devin Desktop: https://app.devin.ai/desktop/session/d7c7d8e7ea9a4d49a9180b295cdcf06b?variant=devin
Requested by: Alexandre Girard (@girarda)