Found while adding the FR-035 manifest gate (#8, PR #9).
The measurement
make test reports:
Every one of the 24 is tests/test_skeletons_and_validate.py, skipping with:
SKIPPED [23] tests/test_skeletons_and_validate.py:220: quire wheel lacks validate_document
SKIPPED [1] tests/test_skeletons_and_validate.py:230: quire wheel lacks validate_document
The message is wrong. quire is not a dependency of this repository at all:
$ poetry run python -c "import quire"
ModuleNotFoundError: No module named 'quire'
So the guard reads "the installed wheel is too old" when the truth is "the package was never installed." Anyone reading the output would go looking for a version bump.
Why it matters
This module ships 23 skeletons. They are the authoring templates every consumer starts from, and validate_document is what proves a filled skeleton satisfies its own object type's contract.
All 23 are validated by nothing, and the suite reports green.
This is the same defect shape as #8 — a gate that does not run, reporting success — on a different surface. #8 was the manifest; this is the skeletons.
Work
- Add
quire as a dev dependency, from internal-pypi, at a version exposing validate_document (quire-rs has shipped it since the FR-032 work; v0.30.1 is current).
- Run the 24. Expect them to fire. That is the point — 23 unvalidated skeletons is not a state that arrives clean.
- Every failure is a real finding about a skeleton or an object type's
data_schema, to be fixed rather than skipped around.
- Correct the guard's message so a genuinely-old wheel and an absent package are distinguishable. If the intent is that this suite requires
quire, the guard should be removed entirely rather than reworded — a dev dependency that is declared is present.
Not a reason to soften anything
Per CLAUDE.md's check-quality rule: a large number of newly-failing tests here would be a bad corpus result, not a bad check. The skeletons have never been validated; whatever they turn up is real.
Related
Found while adding the FR-035 manifest gate (#8, PR #9).
The measurement
make testreports:Every one of the 24 is
tests/test_skeletons_and_validate.py, skipping with:The message is wrong.
quireis not a dependency of this repository at all:So the guard reads "the installed wheel is too old" when the truth is "the package was never installed." Anyone reading the output would go looking for a version bump.
Why it matters
This module ships 23 skeletons. They are the authoring templates every consumer starts from, and
validate_documentis what proves a filled skeleton satisfies its own object type's contract.All 23 are validated by nothing, and the suite reports green.
This is the same defect shape as #8 — a gate that does not run, reporting success — on a different surface. #8 was the manifest; this is the skeletons.
Work
quireas a dev dependency, frominternal-pypi, at a version exposingvalidate_document(quire-rs has shipped it since the FR-032 work; v0.30.1 is current).data_schema, to be fixed rather than skipped around.quire, the guard should be removed entirely rather than reworded — a dev dependency that is declared is present.Not a reason to soften anything
Per
CLAUDE.md's check-quality rule: a large number of newly-failing tests here would be a bad corpus result, not a bad check. The skeletons have never been validated; whatever they turn up is real.Related