satellite.nvim scrollbar not faded

[shyun3]

I noticed that the satellite.nvim scrollbar does not get faded. In the following screenshots, the scrollbar is located in the upper right:

The marks in the scrollbar do get faded however, albeit very slightly.

[TaDaa]

this one is a doozy lol... things to look into in multiple places:/

On the neovim side:

• highlight namespace is being cleared for some reason when nvim_win_set_config is called. Unsure if intentional behavior atm

On the satellite side:

• Everything is wrapped in noautocmd and no exposed user events, which limits our options. Not sure if we need changes here or if getting nvim_win_set_config fixed is enough atm. We could also ask satellite maintainer to store and set the highlight namespace when calling that function, but there are probably other plugins as well & probably best for neovim to handle.

On vimade side:

• We (purposely) don't update the highlight namespace if its been overridden by another namespace. So vimade does fade it, but then satellite calls nvim_win_set_config, which clears it, and then vimade doesn't set it again. The reason for this decision was to prevent circular fighting for control of the namespace.
• The blocklist and link need to be modified to support win owners. Maybe there is a logical default here, if not it will need to be user-overridden for this specific use-case

(temporarily) it may be possible to override the api and store/set the namespace

Reviewing that logic again to see if its safe to either fight for control (suspect it is and that I was just being overly cautious initially). Fighting for control isn't really ideal though because its going to cause flickering without explicit tie-in, so I'm still leaning towards its best to fix in either neovim/satellite.

[TaDaa]

ok for a temporary workaround, this should work:

add to your init.lua (preferably before satellite is loaded, but shouldn't really matter):

local NVIM_WIN_SET_CONFIG = vim.api.nvim_win_set_config
vim.api.nvim_win_set_config = function(win, config)
  local ns = vim.api.nvim_get_hl_ns({winid = win})
  local winhl = vim.wo[win].winhl
  local result = NVIM_WIN_SET_CONFIG(win, config)
  if winhl then
    vim.wo[win].winhl = winhl
  end
  if ns > 0 then
    vim.api.nvim_win_set_hl_ns(win, ns)
  end
  return result
end

In vimade config do the following (assuming lazy.nvim setup):

return {'vimade', {
  opts = {
    link = {
      link_relative_wins = function(win, active)
        if win.win_config.relative == 'win'
          and win.win_config.win == active.winid then
          return true
        end
      end
    },
    blocklist = {
      block_inactive_floats = function (win, active)
        return (win.win_config.relative ~= '' and
        win.win_config.relative ~= 'win')
        and (win ~= active or win.buf_opts.buftype =='terminal') and true or false
      end,
    }
  }
}}

It should pretty much work at that point. I'll ping back here as well after more testing to see if we can change the block_inactive_floats and link_relative_wins to be new defaults