From 0568de43ab60cbf2e13b46c586a38315214d495f Mon Sep 17 00:00:00 2001 From: Ryan Barlow <7389646+ryanbarlow97@users.noreply.github.com> Date: Wed, 23 Sep 2026 08:17:49 +0000 Subject: [PATCH] chore: remove unused gson dependency and abandoned quest stubs Nothing imports com.google.gson. It was the only private JAR, so prepare-release.sh becomes the standard no-private-JARs stub and the checksum file and install script go. The quest feature was never wired: QuestLoader is empty, quests.yml and quest-tiers.yml are never saved or loaded, and MBGUI.QUEST is never constructed or matched. Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/dependencies.sha256 | 1 - .github/scripts/install-local-dependencies.sh | 9 ---- .github/scripts/prepare-release.sh | 6 +-- pom.xml | 6 --- .../marketblock/inventory/holder/MBGUI.java | 1 - .../marketblock/loader/QuestLoader.java | 5 -- src/main/resources/quest-tiers.yml | 51 ------------------- src/main/resources/quests.yml | 1 - 8 files changed, 1 insertion(+), 79 deletions(-) delete mode 100644 .github/dependencies.sha256 delete mode 100644 .github/scripts/install-local-dependencies.sh delete mode 100644 src/main/java/net/tfminecraft/marketblock/loader/QuestLoader.java delete mode 100644 src/main/resources/quest-tiers.yml delete mode 100644 src/main/resources/quests.yml diff --git a/.github/dependencies.sha256 b/.github/dependencies.sha256 deleted file mode 100644 index f8e2719..0000000 --- a/.github/dependencies.sha256 +++ /dev/null @@ -1 +0,0 @@ -4241c14a7727c34feea6507ec801318a3d4a90f070e4525681079fb94ee4c593 libs/gson-2.10.1.jar diff --git a/.github/scripts/install-local-dependencies.sh b/.github/scripts/install-local-dependencies.sh deleted file mode 100644 index b816d9b..0000000 --- a/.github/scripts/install-local-dependencies.sh +++ /dev/null @@ -1,9 +0,0 @@ -#!/usr/bin/env bash -set -euo pipefail -# Run from the repository root after downloading the pinned JARs. -# Hash-qualified versions prevent different private JARs sharing a Maven cache key. -sha256sum --check .github/dependencies.sha256 - -mvn -B --no-transfer-progress org.apache.maven.plugins:maven-install-plugin:3.1.4:install-file \ - -Dfile="libs/gson-2.10.1.jar" -DgroupId="local" -DartifactId="gson" \ - -Dversion="2.10.1-tfmc-4241c14a7727" -Dpackaging=jar -DgeneratePom=true "$@" diff --git a/.github/scripts/prepare-release.sh b/.github/scripts/prepare-release.sh index 3e4c1d6..bc8fa82 100644 --- a/.github/scripts/prepare-release.sh +++ b/.github/scripts/prepare-release.sh @@ -1,7 +1,3 @@ #!/usr/bin/env bash set -euo pipefail -: "${GH_TOKEN:?Set DEPS_TOKEN with Contents read access to TF-Minecraft/ServerAssets}" -ref=883970ddc256f0e4c3bcaee87e6cf33171b9d4a4 -mkdir -p libs -curl --fail --location --silent --show-error --retry 3 -H "Authorization: Bearer $GH_TOKEN" -H "Accept: application/vnd.github.raw+json" "https://api.github.com/repos/TF-Minecraft/ServerAssets/contents/jars/4241c14a7727/gson-2.10.1.jar?ref=$ref" > "libs/gson-2.10.1.jar" -bash .github/scripts/install-local-dependencies.sh "$@" +# Server API dependencies resolve from Maven; no private JARs are needed here. diff --git a/pom.xml b/pom.xml index 4cde198..cfab5a0 100644 --- a/pom.xml +++ b/pom.xml @@ -18,12 +18,6 @@ - - local - gson - 2.10.1-tfmc-4241c14a7727 - provided - me.plugins tlibs diff --git a/src/main/java/net/tfminecraft/marketblock/inventory/holder/MBGUI.java b/src/main/java/net/tfminecraft/marketblock/inventory/holder/MBGUI.java index c9cdc2f..7874505 100644 --- a/src/main/java/net/tfminecraft/marketblock/inventory/holder/MBGUI.java +++ b/src/main/java/net/tfminecraft/marketblock/inventory/holder/MBGUI.java @@ -3,5 +3,4 @@ public enum MBGUI { CATEGORY, TRADE, - QUEST, } diff --git a/src/main/java/net/tfminecraft/marketblock/loader/QuestLoader.java b/src/main/java/net/tfminecraft/marketblock/loader/QuestLoader.java deleted file mode 100644 index 4f2de5e..0000000 --- a/src/main/java/net/tfminecraft/marketblock/loader/QuestLoader.java +++ /dev/null @@ -1,5 +0,0 @@ -package net.tfminecraft.marketblock.loader; - -public class QuestLoader { - -} diff --git a/src/main/resources/quest-tiers.yml b/src/main/resources/quest-tiers.yml deleted file mode 100644 index 3acd674..0000000 --- a/src/main/resources/quest-tiers.yml +++ /dev/null @@ -1,51 +0,0 @@ -common: - name: "#8da88cCommon" - weight: 80.0 - item-factor: 0.1 - scaling: -0.2 - reward-count: 1-2 - rewards: - - money 2-9 - - m.materials.bark 1-2 - - m.materials.salt 2-3 - - v.diamond 1-3 -uncommon: - name: "#43d18aUncommon" - weight: 14.0 - item-factor: 0.3 - reward-count: 1-3 - rewards: - - money 12-29 - - m.materials.bark 6-9 - - m.materials.salt 7-12 - - v.diamond 4-8 -rare: - name: "#6060dbRare" - weight: 4.0 - item-factor: 0.3 - reward-count: 1-3 - rewards: - - money 12-29 - - m.materials.bark 6-9 - - m.materials.salt 7-12 - - v.diamond 4-8 -epic: - name: "#9c27d6§lEpic" - weight: 1.4 - item-factor: 0.3 - reward-count: 1-3 - rewards: - - money 12-29 - - m.materials.bark 6-9 - - m.materials.salt 7-12 - - v.diamond 4-8 -legendary: - name: "#f2992c§lLegendary" - weight: 0.6 - item-factor: 0.3 - reward-count: 1-3 - rewards: - - money 12-29 - - m.materials.bark 6-9 - - m.materials.salt 7-12 - - v.diamond 4-8 \ No newline at end of file diff --git a/src/main/resources/quests.yml b/src/main/resources/quests.yml deleted file mode 100644 index b5e3947..0000000 --- a/src/main/resources/quests.yml +++ /dev/null @@ -1 +0,0 @@ -max-fulfillment: 100 \ No newline at end of file