From 9978c8f3231e17323d0b2be68a84e008fa3ca3d7 Mon Sep 17 00:00:00 2001 From: Ryan Barlow <7389646+ryanbarlow97@users.noreply.github.com> Date: Thu, 24 Sep 2026 20:42:59 +0000 Subject: [PATCH 1/2] ci: pin shared plugin setup to TLibs main The setup-plugins action was pinned to 4f7a354, the head of TLibs PR #19, which is not on any TLibs branch. Pin it to 8ef41de on TLibs main. The action is unchanged; its installer catalogue now also lists GemInfusion. Drop -P'!deploy-live'. No POM defines a deploy-live profile, so the flag does nothing. Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/workflows/build.yml | 8 ++++---- .github/workflows/maven-release.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 47757c7..495c41d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,7 +22,7 @@ jobs: distribution: temurin java-version: '21' - name: Install shared plugin dependencies - uses: TF-Minecraft/TLibs/.github/actions/setup-plugins@4f7a3545063cb2e8d06a034687c817ab863f0835 + uses: TF-Minecraft/TLibs/.github/actions/setup-plugins@8ef41de589f121c98ff892b10696e7c1feb4ca74 with: mode: pinned @@ -38,9 +38,9 @@ jobs: if [[ "$GITHUB_EVENT_NAME" == "pull_request" ]]; then dev_version="DEV-$(date -u +%Y%m%d-%H%M)" fi - mvn -B --no-transfer-progress -P'!deploy-live' org.codehaus.mojo:versions-maven-plugin:2.22.0:set \ + mvn -B --no-transfer-progress org.codehaus.mojo:versions-maven-plugin:2.22.0:set \ -DnewVersion="$dev_version" -DgenerateBackupPoms=false - mvn -B --no-transfer-progress -P'!deploy-live' help:evaluate \ + mvn -B --no-transfer-progress help:evaluate \ -Dexpression=project.build.finalName -Doutput="$RUNNER_TEMP/final-name" final_name=$(cat "$RUNNER_TEMP/final-name") [[ "$final_name" =~ ^[A-Za-z0-9][A-Za-z0-9._-]*$ ]] || exit 1 @@ -49,7 +49,7 @@ jobs: echo "jar=target/$final_name.jar" >> "$GITHUB_OUTPUT" - name: Run unit tests and build - run: mvn -B --no-transfer-progress -P'!deploy-live' clean verify -DskipTests=false -Dmaven.test.skip=false + run: mvn -B --no-transfer-progress clean verify -DskipTests=false -Dmaven.test.skip=false - name: Verify runtime JAR env: diff --git a/.github/workflows/maven-release.yml b/.github/workflows/maven-release.yml index 8a20f22..87d147c 100644 --- a/.github/workflows/maven-release.yml +++ b/.github/workflows/maven-release.yml @@ -47,7 +47,7 @@ jobs: [[ "${TAG^^}" != *SNAPSHOT* ]] || exit 1 - name: Install shared plugin dependencies - uses: TF-Minecraft/TLibs/.github/actions/setup-plugins@4f7a3545063cb2e8d06a034687c817ab863f0835 + uses: TF-Minecraft/TLibs/.github/actions/setup-plugins@8ef41de589f121c98ff892b10696e7c1feb4ca74 with: mode: pinned @@ -64,14 +64,14 @@ jobs: env: TAG: ${{ github.ref_name }} run: | - mvn -B --no-transfer-progress -P'!deploy-live' org.codehaus.mojo:versions-maven-plugin:2.22.0:set \ + mvn -B --no-transfer-progress org.codehaus.mojo:versions-maven-plugin:2.22.0:set \ -DnewVersion="${TAG#v}" -DgenerateBackupPoms=false - mvn -B --no-transfer-progress -P'!deploy-live' help:evaluate \ + mvn -B --no-transfer-progress help:evaluate \ -Dexpression=project.build.finalName -Doutput="$RUNNER_TEMP/final-name" final_name=$(cat "$RUNNER_TEMP/final-name") [[ "$final_name" =~ ^[A-Za-z0-9][A-Za-z0-9._-]*$ ]] || exit 1 echo "jar=target/$final_name.jar" >> "$GITHUB_OUTPUT" - mvn -B --no-transfer-progress -P'!deploy-live' clean verify -DskipTests=false -Dmaven.test.skip=false + mvn -B --no-transfer-progress clean verify -DskipTests=false -Dmaven.test.skip=false - name: Stage only the release JAR env: From 8b1da6e59f327631261adcf33998fae4f6da3350 Mon Sep 17 00:00:00 2001 From: Ryan Barlow <7389646+ryanbarlow97@users.noreply.github.com> Date: Thu, 24 Sep 2026 20:44:11 +0000 Subject: [PATCH 2/2] docs: drop the plugin version drift note from the PR template plugin.yml takes its version from the POM through resource filtering, and release versions come from tags, so the two no longer drift. Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/pull_request_template.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7f4b31d..e0c884a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -15,5 +15,4 @@ ## Notes - Config source is `src/main/resources`. Do not edit `target/`. -- `plugin.yml` version and `pom.xml` version are known drift. Do not mix a version bump into unrelated work. - `cookware.yml` is not loaded.