Skip to content

Commit fe68023

Browse files
committed
fix(test): restore valid Minecraft launch coordinator fixtures
1 parent 03d2650 commit fe68023

2 files changed

Lines changed: 30 additions & 72 deletions

File tree

‎docs/WORKLOG.md‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,34 @@ Every code/build/documentation/CI task must add an entry according to `AGENTS.md
88

99
---
1010

11+
## 2026-10-18 — Repair malformed launch integration test source
12+
13+
**Milestone:** v0.1 — Minimal Vanilla Launcher
14+
**Author/Agent:** ChatGPT
15+
**Status:** Partial
16+
17+
### Completed
18+
- Analyzed GitHub Actions run `39123801750`: production launcher-core and launcher-desktop code compiled, but integration test source was corrupted by a string replacement.
19+
- Recreated `MinecraftLaunchCoordinatorTest.kt` from the last known intact revision, retaining actual Kotlin literal placeholder escaping via `\$` characters.
20+
- Removed the malformed duplicated source fragments rather than attempting incremental repairs.
21+
22+
### Changed files
23+
- `launcher-core/src/test/kotlin/.../launch/MinecraftLaunchCoordinatorTest.kt` — restore tests and valid literal Minecraft arguments.
24+
- `docs/WORKLOG.md` — this entry.
25+
26+
### Verification
27+
- Previous Actions run: production core and desktop Kotlin compiled; test source compilation failed due malformed placeholder string.
28+
- Tests/build: awaiting full CI rerun with corrected source.
29+
- Live Minecraft: NOT RUN.
30+
31+
### Roadmap updates
32+
- CI remains IN PROGRESS pending test and packaging pass.
33+
34+
### Follow-ups / known issues
35+
- Inspect JUnit results after source is compiled.
36+
- Verify platform app package jobs.
37+
- Verify official Gradle wrapper bootstrapped by workflow.
38+
1139
## 2026-10-18 — Fix desktop Ktor dependency and launch test interpolation; bootstrap wrapper
1240

1341
**Milestone:** v0.1 — Minimal Vanilla Launcher

‎launcher-core/src/test/kotlin/pl/syntaxdevteam/syntaxlauncher/core/launch/MinecraftLaunchCoordinatorTest.kt‎

Lines changed: 2 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -124,78 +124,8 @@ class MinecraftLaunchCoordinatorTest {
124124
),
125125
libraries = emptyList(),
126126
arguments = MinecraftArguments(
127-
jvm = listOf(MinecraftArgument(listOf("-cp", "${'"))),
128-
game = listOf(MinecraftArgument(listOf("--username", "${'"))),
129-
),
130-
javaRequirement = JavaRuntimeRequirement("java-runtime-delta", 21),
131-
logging = null,
132-
)
133-
134-
private fun makeLayout(root: Path) = MinecraftInstallationLayout(
135-
gameDir = root.resolve("game"),
136-
versionsDir = root.resolve("cache/versions"),
137-
librariesDir = root.resolve("cache/libraries"),
138-
assetsDir = root.resolve("cache/assets"),
139-
assetIndexesDir = root.resolve("cache/assets/indexes"),
140-
assetObjectsDir = root.resolve("cache/assets/objects"),
141-
loggingConfigsDir = root.resolve("cache/assets/log_configs"),
142-
nativesDir = root.resolve("cache/natives"),
143-
)
144-
}
145-
}{classpath}"))),
146-
game = listOf(MinecraftArgument(listOf("--username", "${auth_player_name}"))),
147-
),
148-
javaRequirement = JavaRuntimeRequirement("java-runtime-delta", 21),
149-
logging = null,
150-
)
151-
152-
private fun makeLayout(root: Path) = MinecraftInstallationLayout(
153-
gameDir = root.resolve("game"),
154-
versionsDir = root.resolve("cache/versions"),
155-
librariesDir = root.resolve("cache/libraries"),
156-
assetsDir = root.resolve("cache/assets"),
157-
assetIndexesDir = root.resolve("cache/assets/indexes"),
158-
assetObjectsDir = root.resolve("cache/assets/objects"),
159-
loggingConfigsDir = root.resolve("cache/assets/log_configs"),
160-
nativesDir = root.resolve("cache/natives"),
161-
)
162-
}
163-
}{auth_player_name}"))),
164-
),
165-
javaRequirement = JavaRuntimeRequirement("java-runtime-delta", 21),
166-
logging = null,
167-
)
168-
169-
private fun makeLayout(root: Path) = MinecraftInstallationLayout(
170-
gameDir = root.resolve("game"),
171-
versionsDir = root.resolve("cache/versions"),
172-
librariesDir = root.resolve("cache/libraries"),
173-
assetsDir = root.resolve("cache/assets"),
174-
assetIndexesDir = root.resolve("cache/assets/indexes"),
175-
assetObjectsDir = root.resolve("cache/assets/objects"),
176-
loggingConfigsDir = root.resolve("cache/assets/log_configs"),
177-
nativesDir = root.resolve("cache/natives"),
178-
)
179-
}
180-
}{classpath}"))),
181-
game = listOf(MinecraftArgument(listOf("--username", "${'"))),
182-
),
183-
javaRequirement = JavaRuntimeRequirement("java-runtime-delta", 21),
184-
logging = null,
185-
)
186-
187-
private fun makeLayout(root: Path) = MinecraftInstallationLayout(
188-
gameDir = root.resolve("game"),
189-
versionsDir = root.resolve("cache/versions"),
190-
librariesDir = root.resolve("cache/libraries"),
191-
assetsDir = root.resolve("cache/assets"),
192-
assetIndexesDir = root.resolve("cache/assets/indexes"),
193-
assetObjectsDir = root.resolve("cache/assets/objects"),
194-
loggingConfigsDir = root.resolve("cache/assets/log_configs"),
195-
nativesDir = root.resolve("cache/natives"),
196-
)
197-
}
198-
}{auth_player_name}"))),
127+
jvm = listOf(MinecraftArgument(listOf("-cp", "\${classpath}"))),
128+
game = listOf(MinecraftArgument(listOf("--username", "\${auth_player_name}"))),
199129
),
200130
javaRequirement = JavaRuntimeRequirement("java-runtime-delta", 21),
201131
logging = null,

0 commit comments

Comments
 (0)