fix(linux): embed MIT AppStream metadata and copyright in native installers

Author: WieszczY85

.github/workflows/build.yml

@@ -182,7 +182,7 @@ jobs:
           python scripts/verify_native_network.py --image "$image" --platform "${{ matrix.artifact }}"
       - name: Install Linux packaging tools
         if: runner.os == 'Linux'
-        run: sudo apt-get update && sudo apt-get install -y rpm fakeroot desktop-file-utils xvfb
+        run: sudo apt-get update && sudo apt-get install -y rpm fakeroot desktop-file-utils xvfb appstream
       - uses: actions/setup-dotnet@v5
         if: runner.os == 'Windows'
         with:

docs/INSTALLATION.md

@@ -26,7 +26,7 @@ Download the five installer formats from [0.9.3-DEV build 188.1](https://github.
 | Fedora/openSUSE and other compatible RPM systems x64 | `syntaxlauncher-linux-x64.rpm` | Install with the distribution's package manager (`sudo dnf install ./syntaxlauncher-linux-x64.rpm` or `sudo zypper install ./syntaxlauncher-linux-x64.rpm`); remove package `syntaxlauncher`. |
 | Other compatible desktop Linux systems x64 | `syntaxlauncher-linux-x64.AppImage` | Mark executable and open; this is a single-file portable application, not a system package. Where FUSE is unavailable, `./syntaxlauncher-linux-x64.AppImage --appimage-extract-and-run` uses temporary extraction. |
 
-Linux DEB/RPM install the launcher under `/opt/syntaxlauncher` and register a desktop menu entry. All formats contain the launcher's Java runtime; Minecraft Java remains managed separately. AppImage does not eliminate native compatibility requirements: this build uses the Ubuntu 24.04 x64 application baseline, requires a compatible glibc desktop/graphics stack, and does not promise Alpine/musl, all historical distributions or Linux ARM64 support. Fedora RPM installation/removal is tested in a Fedora 44 container; a container lifecycle test does not certify graphical gameplay. openSUSE and other distributions require their own native acceptance before being called verified.
+Linux DEB/RPM install the launcher under `/opt/syntaxlauncher` and register a desktop menu entry. Both installers include AppStream metadata under `/usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml` with MIT as the project licence, SyntaxDevTeam as developer, and official project, support and source-code URLs. Debian also includes a machine-readable MIT copyright file under `/usr/share/doc/syntaxlauncher/copyright`; RPM retains its MIT license field. AppImage includes the same component metadata with an AppImage-specific desktop-file reference. Linux CI checks the actual DEB/RPM/AppImage payloads and validates the metadata with `appstreamcli`. Software-center UI behaviour can additionally depend on distribution AppStream catalogs; KDE Discover presentation must be checked separately. All formats contain the launcher's Java runtime; Minecraft Java remains managed separately. AppImage does not eliminate native compatibility requirements: this build uses the Ubuntu 24.04 x64 application baseline, requires a compatible glibc desktop/graphics stack, and does not promise Alpine/musl, all historical distributions or Linux ARM64 support. Fedora RPM installation/removal is tested in a Fedora 44 container; a container lifecycle test does not certify graphical gameplay. openSUSE and other distributions require their own native acceptance before being called verified.
 
 Installer SHA-256 hashes are published as `SHA256SUMS-installers.txt`. The first installer previews are unsigned; Apple notarization and trusted Windows publisher signatures remain open production gates. Installer builds and temporary mount tests do not certify native trust prompts or all clean-machine workflows.
 

packaging/smoke-linux.sh

@@ -25,6 +25,48 @@ test -x /opt/syntaxlauncher/bin/SyntaxLauncher || { dpkg -L syntaxlauncher; exit
 desktop_entry="$(find /usr/share/applications /usr/local/share/applications -iname '*syntaxlauncher*.desktop' -print -quit 2>/dev/null || true)"
 test -n "$desktop_entry"
 desktop-file-validate "$desktop_entry"
+metainfo="/usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml"
+test -r "$metainfo"
+appstreamcli validate --no-net "$metainfo"
+grep -q '<project_license>MIT</project_license>' "$metainfo"
+test -r /usr/share/doc/syntaxlauncher/copyright
+grep -q '^License: MITstartup /opt/syntaxlauncher/bin/SyntaxLauncher deb-startup
+sudo apt-get remove -y syntaxlauncher
+test ! -e /opt/syntaxlauncher/bin/SyntaxLauncher
+grep -qx keep-world "$XDG_DATA_HOME/syntaxlauncher/instances/smoke/saves/marker"
+grep -qx keep-settings "$XDG_CONFIG_HOME/syntaxlauncher/marker"
+# Inspect and install/remove the RPM on an actual RPM distribution, not with --nodeps.
+rpm -qpi "$packages/syntaxlauncher-linux-x64.rpm" > "$evidence/rpm-metadata.txt"
+grep -Eq '^License[[:space:]]*:[[:space:]]*MIT' "$evidence/rpm-metadata.txt"
+rpm -qlp "$packages/syntaxlauncher-linux-x64.rpm" > "$evidence/rpm-contents.txt"
+grep -q '/usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml' "$evidence/rpm-contents.txt"
+docker run --rm -v "$packages:/packages:ro" fedora:44 bash -euc '
+    mkdir -p /root/.local/share/syntaxlauncher/instances/smoke/saves
+    echo keep-world > /root/.local/share/syntaxlauncher/instances/smoke/saves/marker
+    dnf install -y /packages/syntaxlauncher-linux-x64.rpm
+    test -x /opt/syntaxlauncher/bin/SyntaxLauncher
+    test -r /usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml
+    grep -q "<project_license>MIT</project_license>" /usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml
+    dnf remove -y syntaxlauncher
+    test ! -e /opt/syntaxlauncher/bin/SyntaxLauncher
+    grep -qx keep-world /root/.local/share/syntaxlauncher/instances/smoke/saves/marker
+' > "$evidence/fedora-rpm-lifecycle.log" 2>&1
+# Extraction needs no FUSE mount and checks the payload used on other distributions.
+chmod +x "$packages/syntaxlauncher-linux-x64.AppImage"
+pushd "$smoke_root" >/dev/null
+"$packages/syntaxlauncher-linux-x64.AppImage" --appimage-extract > "$evidence/appimage-extract.log"
+test -x squashfs-root/AppRun
+test -L squashfs-root/.DirIcon
+test -r squashfs-root/usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml
+grep -q '<project_license>MIT</project_license>' squashfs-root/usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml
+appstreamcli validate --no-net squashfs-root/usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml
+startup "$smoke_root/squashfs-root/AppRun" appimage-startup
+popd >/dev/null
+ /usr/share/doc/syntaxlauncher/copyright
+dpkg-deb -c "$packages/syntaxlauncher-linux-x64.deb" > "$evidence/deb-contents.txt"
+grep -q 'usr/share/metainfo/pl.syntaxdevteam.syntaxlauncher.metainfo.xml' "$evidence/deb-contents.txt"
+grep -q 'usr/share/doc/syntaxlauncher/copyright' "$evidence/deb-contents.txt"
+dpkg-deb -f "$packages/syntaxlauncher-linux-x64.deb" > "$evidence/deb-control.txt"
 startup /opt/syntaxlauncher/bin/SyntaxLauncher deb-startup
 sudo apt-get remove -y syntaxlauncher
 test ! -e /opt/syntaxlauncher/bin/SyntaxLauncher

scripts/package_installers.py

@@ -21,6 +21,10 @@
 
 ROOT = Path(__file__).resolve().parent.parent
 BRANDING = ROOT / 'launcher-desktop/src/main/resources/branding'
+APPSTREAM_ID = 'pl.syntaxdevteam.syntaxlauncher'
+APPSTREAM_FILENAME = APPSTREAM_ID + '.metainfo.xml'
+PACKAGED_DESKTOP_ID = 'syntaxlauncher-SyntaxLauncher.desktop'
+APPIMAGE_DESKTOP_ID = 'syntaxlauncher.desktop'
 WIX_VERSION = '7.0.0'
 UPGRADE_CODE = 'D64AD1BC-4B59-4C1C-A45C-ABBC92E21739'
 INSTALLERS = {
@@ -38,6 +42,82 @@
 UI_NS = NS + '/ui'
 
 
+def appstream_metadata(desktop_id):
+    """Stable component ID, with a launchable desktop file matching the target format."""
+    if desktop_id not in (PACKAGED_DESKTOP_ID, APPIMAGE_DESKTOP_ID):
+        raise ValueError('Unsupported desktop file ID')
+    return f'''<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop-application">
+  <id>{APPSTREAM_ID}</id>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>MIT</project_license>
+  <name>SyntaxLauncher</name>
+  <summary>Modern Minecraft Java Edition launcher</summary>
+  <description>
+    <p>SyntaxLauncher is an independent desktop launcher for Minecraft Java Edition.
+    It manages game versions, mod loaders, isolated game profiles and game files.
+    Microsoft sign-in and verification of Minecraft Java Edition ownership are
+    required before starting the game.</p>
+  </description>
+  <developer id="pl.syntaxdevteam">
+    <name>SyntaxDevTeam</name>
+  </developer>
+  <categories><category>Game</category></categories>
+  <launchable type="desktop-id">{desktop_id}</launchable>
+  <url type="homepage">https://syntaxdevteam.pl/p/syntaxlauncher</url>
+  <url type="bugtracker">https://github.com/SyntaxDevTeam/SyntaxLauncher/issues</url>
+  <url type="help">https://syntaxdevteam.pl/p/syntaxlauncher-zarzadzanie-usluga</url>
+  <url type="vcs-browser">https://github.com/SyntaxDevTeam/SyntaxLauncher</url>
+</component>
+'''
+
+
+def debian_copyright():
+    """Machine-readable Debian copyright: SPDX MIT plus its exact source text."""
+    lines = (ROOT / 'LICENSE').read_text(encoding='utf-8').splitlines()
+    return (
+        'Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/\n'
+        'Upstream-Name: SyntaxLauncher\n'
+        'Source: https://github.com/SyntaxDevTeam/SyntaxLauncher\n\n'
+        'Files: *\n'
+        'Copyright: 2026 SyntaxDevTeam\n'
+        'License: MIT\n'
+        + '\n'.join((' ' + line) if line else ' .' for line in lines) + '\n'
+    )
+
+
+def rpm_metainfo_template(spec, metadata_path):
+    """Stage metadata before jpackage's automatic RPM file-inventory generation."""
+    marker = '(cd %{buildroot} && find . -path ./lib/systemd'
+    if spec.count(marker) != 1:
+        raise ValueError('Unsupported jpackage RPM template; inventory marker missing')
+    source = str(metadata_path.resolve(strict=True))
+    if any(ch in source for ch in ('"', '\n', '%')):
+        raise ValueError('Unsafe RPM source path')
+    commands = (
+        'install -d -m 755 "%{buildroot}/usr/share/metainfo"\n'
+        f'install -m 644 "{source}" "%{{buildroot}}/usr/share/metainfo/{APPSTREAM_FILENAME}"\n'
+    )
+    return spec.replace(marker, commands + marker, 1)
+
+
+def add_debian_metadata(package, metadata_path):
+    """Place AppStream/copyright in the DEB payload instead of a postinst side effect."""
+    with tempfile.TemporaryDirectory(prefix='syntaxlauncher-deb-meta-') as temporary:
+        work = Path(temporary)
+        root = work / 'root'
+        run(['dpkg-deb', '--raw-extract', package, root])
+        metainfo = root / 'usr/share/metainfo' / APPSTREAM_FILENAME
+        metainfo.parent.mkdir(parents=True, exist_ok=True)
+        shutil.copyfile(metadata_path, metainfo)
+        copyright_file = root / 'usr/share/doc/syntaxlauncher/copyright'
+        copyright_file.parent.mkdir(parents=True, exist_ok=True)
+        copyright_file.write_text(debian_copyright(), encoding='utf-8')
+        rebuilt = work / 'syntaxlauncher.deb'
+        run(['dpkg-deb', '--build', '--root-owner-group', root, rebuilt])
+        os.replace(rebuilt, package)
+
+
 def numeric_version(version):
     parse_launcher_version('launcherVersion=' + version)
     return version.split('-')[0].split('+')[0]
@@ -194,6 +274,10 @@ def appdir(image, destination):
     shutil.copyfile(BRANDING / 'syntaxlauncher-icon.png', destination / 'syntaxlauncher.png')
     (destination / '.DirIcon').symlink_to('syntaxlauncher.png')
     shutil.copyfile(ROOT / 'LICENSE', destination / 'LICENSE')
+    metainfo_directory = destination / 'usr/share/metainfo'
+    metainfo_directory.mkdir(parents=True, exist_ok=True)
+    (metainfo_directory / APPSTREAM_FILENAME).write_text(
+        appstream_metadata(APPIMAGE_DESKTOP_ID), encoding='utf-8')
 
 
 def desktop_template(text, kind):
@@ -205,7 +289,7 @@ def desktop_template(text, kind):
     return text.replace(marker, marker + '\nmkdir -p /usr/share/applications /usr/share/desktop-directories /etc/xdg/menus/applications-merged\n', 1)
 
 
-def linux_resources(work):
+def linux_resources(work, metadata_path):
     executable = Path(shutil.which(jpackage_tool()) or jpackage_tool()).resolve()
     home = Path(os.environ.get('JAVA_HOME', str(executable.parent.parent)))
     module = home / 'jmods/jdk.jpackage.jmod'
@@ -224,12 +308,17 @@ def linux_resources(work):
         base = extracted / 'jdk.jpackage/jdk/jpackage/internal/resources'
         contents = {source: (base / source).read_text(encoding='utf-8') for _, source, _ in templates}
     for kind, source, target in templates:
-        (resources / target).write_text(desktop_template(contents[source], kind), encoding='utf-8')
+        template = desktop_template(contents[source], kind)
+        if kind == 'rpm':
+            template = rpm_metainfo_template(template, metadata_path)
+        (resources / target).write_text(template, encoding='utf-8')
     return resources
 
 
 def linux(image, version, output, work):
-    resources = linux_resources(work)
+    metadata_path = work / APPSTREAM_FILENAME
+    metadata_path.write_text(appstream_metadata(PACKAGED_DESKTOP_ID), encoding='utf-8')
+    resources = linux_resources(work, metadata_path)
     for kind in ('deb', 'rpm'):
         folder = work / kind
         folder.mkdir()
@@ -247,7 +336,10 @@ def linux(image, version, output, work):
         files = list(folder.glob('*.' + kind))
         if len(files) != 1:
             raise ValueError('Expected exactly one ' + kind + ' package')
-        shutil.copyfile(files[0], output / ('syntaxlauncher-linux-x64.' + kind))
+        destination = output / ('syntaxlauncher-linux-x64.' + kind)
+        shutil.copyfile(files[0], destination)
+        if kind == 'deb':
+            add_debian_metadata(destination, metadata_path)
     directory = work / 'SyntaxLauncher.AppDir'
     directory.mkdir()
     appdir(image, directory)

scripts/test_package_installers.py

@@ -7,7 +7,10 @@
 from unittest.mock import patch
 import xml.etree.ElementTree as ET
 
-from package_installers import (NS, UPGRADE_CODE, appdir, native_version, linux_release, desktop_template, validate_image, wix_source, windows)
+from package_installers import (NS, UPGRADE_CODE, APPSTREAM_ID, APPSTREAM_FILENAME,
+    APPIMAGE_DESKTOP_ID, PACKAGED_DESKTOP_ID, appdir, appstream_metadata, add_debian_metadata,
+    rpm_metainfo_template, native_version, linux_release, desktop_template, validate_image,
+    wix_source, windows)
 from verify_installers import NAMES, verify
 from publish_preview import PLATFORMS, publish
 
@@ -36,6 +39,58 @@ def test_linux_preview_revisions_sort_before_stable_and_distinguish_builds(self)
             with self.assertRaises(ValueError):
                 linux_release('0.9.3-DEV', build, attempt)
 
+    def test_appstream_metadata_identifies_license_publisher_and_desktop_file(self):
+        for desktop_id in (PACKAGED_DESKTOP_ID, APPIMAGE_DESKTOP_ID):
+            root = ET.fromstring(appstream_metadata(desktop_id))
+            self.assertEqual('desktop-application', root.attrib['type'])
+            self.assertEqual(APPSTREAM_ID, root.findtext('id'))
+            self.assertEqual('MIT', root.findtext('project_license'))
+            self.assertEqual('CC0-1.0', root.findtext('metadata_license'))
+            self.assertEqual('SyntaxDevTeam', root.findtext('developer/name'))
+            self.assertEqual('Game', root.findtext('categories/category'))
+            self.assertEqual(desktop_id, root.findtext('launchable'))
+            self.assertEqual('desktop-id', root.find('launchable').attrib['type'])
+        with self.assertRaises(ValueError):
+            appstream_metadata('unrelated.desktop')
+
+    def test_rpm_metainfo_staging_is_before_file_list(self):
+        with tempfile.TemporaryDirectory() as directory:
+            meta = Path(directory) / APPSTREAM_FILENAME
+            meta.write_text(appstream_metadata(PACKAGED_DESKTOP_ID))
+            marker = '(cd %{buildroot} && find . -path ./lib/systemd'
+            spec = '%install\nrm -rf %{buildroot}\n' + marker + '\n%files -f %{package_filelist}\n'
+            result = rpm_metainfo_template(spec, meta)
+            self.assertIn(APPSTREAM_FILENAME, result)
+            self.assertLess(result.index('/usr/share/metainfo'), result.index(marker))
+            with self.assertRaises(ValueError):
+                rpm_metainfo_template('broken', meta)
+
+    @unittest.skipUnless(shutil.which('dpkg-deb'), 'dpkg-deb is unavailable')
+    def test_debian_payload_has_mit_metadata_and_copyright(self):
+        with tempfile.TemporaryDirectory() as directory:
+            root = Path(directory)
+            source = root / 'source'
+            (source / 'DEBIAN').mkdir(parents=True)
+            (source / 'DEBIAN/control').write_text(
+                'Package: syntaxlauncher\nVersion: 0.9.3-1\nArchitecture: amd64\n'
+                'Maintainer: SyntaxDevTeam <[email protected]>\n'
+                'Description: Test package\n')
+            archive = root / 'test.deb'
+            subprocess.run(['dpkg-deb', '--build', '--root-owner-group', str(source), str(archive)],
+                           check=True, capture_output=True)
+            metadata = root / APPSTREAM_FILENAME
+            metadata.write_text(appstream_metadata(PACKAGED_DESKTOP_ID))
+            add_debian_metadata(archive, metadata)
+            extracted = root / 'extracted'
+            subprocess.run(['dpkg-deb', '--raw-extract', str(archive), str(extracted)],
+                           check=True, capture_output=True)
+            self.assertEqual('MIT', ET.parse(extracted / 'usr/share/metainfo' / APPSTREAM_FILENAME).findtext('project_license'))
+            notice = (extracted / 'usr/share/doc/syntaxlauncher/copyright').read_text()
+            self.assertIn('License: MIT', notice)
+            self.assertIn('Permission is hereby granted', notice)
+            self.assertEqual('syntaxlauncher', subprocess.check_output(
+                ['dpkg-deb', '-f', str(archive), 'Package'], text=True).strip())
+
     def test_msi_has_stable_identity_full_payload_user_scope_and_menu(self):
         with tempfile.TemporaryDirectory() as temporary:
             root = Path(temporary)
@@ -101,6 +156,9 @@ def test_appdir_preserves_layout_permissions_and_arguments_in_paths_with_spaces(
             self.assertEqual('syntaxlauncher.png', os.readlink(target / '.DirIcon'))
             self.assertTrue((target / 'SyntaxLauncher/relative-link').is_symlink())
             self.assertIn('Categories=Game;', (target / 'syntaxlauncher.desktop').read_text())
+            metadata = ET.parse(target / 'usr/share/metainfo' / APPSTREAM_FILENAME)
+            self.assertEqual('MIT', metadata.findtext('project_license'))
+            self.assertEqual(APPIMAGE_DESKTOP_ID, metadata.findtext('launchable'))
             (image / 'escape').symlink_to(root)
             with self.assertRaises(ValueError):
                 validate_image(image, 'linux-x64')