From 2644ddff5b3641ecbe68e16642f866deab60d120 Mon Sep 17 00:00:00 2001 From: JongChern Date: Fri, 23 Oct 2026 20:22:06 +0800 Subject: [PATCH] DEV-1115 Build against driver 0.11.11_beta by default The default driver was still 0.11.7_beta, so CI, PR dry runs and local builds tested a driver four releases older than the one Release Android API picks (the newest Java API release). 0.11.11_beta brings fixes that reach Android only through the driver, with nothing to port: - DEV-1266: the IO thread and a timer deadlocked on the instruction list and the device, hanging every later call (seen in 5 of 12 Android HIL inStream runs); - DEV-1306: a stop's reply retired the wrong instruction, so a configuration written straight after stopStreaming() lost its sampling-rate chunk; - DEV-1310: deepClone() of a connected device could throw ConcurrentModificationException, or return null while packets waited. AGENTS.md described the pin as two hard-coded versions and an unpublished shimmerbluetoothmanager; it now describes the single default, the release's -PdriverVersion, and that each Java API release publishes both artifacts. Co-Authored-By: Claude Opus 5.5 --- AGENTS.md | 26 ++++++++++----------- ShimmerAndroidInstrumentDriver/build.gradle | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index aa0005f2..b1983d39 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -37,26 +37,26 @@ driver's parser. ## But upstream fixes do not arrive for free The driver comes in as **published Maven artifacts pinned to an exact version**, from GitHub -Packages — not as source, a submodule or a sibling project. The pin is in the repo-root -`ShimmerAndroidInstrumentDriver/build.gradle`, injected into *every* subproject: +Packages — not as source, a submodule or a sibling project. The version is set once in the repo-root +`ShimmerAndroidInstrumentDriver/build.gradle` and injected into *every* subproject: ```groovy +def shimmerDriverVersion = findProperty('driverVersion') ?: '0.11.11_beta' allprojects { subprojects { afterEvaluate { dependencies { - implementation (group: 'com.shimmerresearch', name: 'shimmerbluetoothmanager', version:'0.11.7_beta') - implementation (group: 'com.shimmerresearch', name: 'shimmerdriver', version:'0.11.7_beta') + implementation (group: 'com.shimmerresearch', name: 'shimmerbluetoothmanager', version: shimmerDriverVersion) + implementation (group: 'com.shimmerresearch', name: 'shimmerdriver', version: shimmerDriverVersion) } } } } ``` -So an upstream fix reaches this repo only when it is **published and the pin is bumped** — and a -stream-parser fix not even then (above). As of 2026-09-30 that has not kept up: +- The default is what CI, PR dry runs and local builds use. +- **Release Android API** passes `-PdriverVersion`, by default the newest Java API release, and + records it in the release notes. +- Each Java API release (`API_v…`) publishes both artifacts at the same version, so they always + move together. -| | pinned here | source in Shimmer-Java-Android-API | published | -|---|---|---|---| -| `shimmerdriver` | 0.11.7_beta | 0.11.8_beta | **0.11.8_beta** (2026-08-05) | -| `shimmerbluetoothmanager` | 0.11.7_beta | 0.11.8_beta | 0.11.7_beta only — **0.11.8 was never published** | - -Bumping the pin therefore needs `shimmerbluetoothmanager` 0.11.8_beta published first. Check both -before assuming a driver fix is live on Android. +So an upstream fix reaches this repo only once it is **in a Java API release** — and a +stream-parser fix not even then (above). Bump the default with each Java API release, so CI builds +what a release would. ## Build diff --git a/ShimmerAndroidInstrumentDriver/build.gradle b/ShimmerAndroidInstrumentDriver/build.gradle index 10abd3f2..92adb2a7 100644 --- a/ShimmerAndroidInstrumentDriver/build.gradle +++ b/ShimmerAndroidInstrumentDriver/build.gradle @@ -26,7 +26,7 @@ apply plugin: 'maven-publish' // The shimmerdriver / shimmerbluetoothmanager version (Shimmer-Java-Android-API) that the library and // every example build against. The default is what master builds with; the Release Android API // workflow passes -PdriverVersion, by default the newest Java API release. -def shimmerDriverVersion = findProperty('driverVersion') ?: '0.11.7_beta' +def shimmerDriverVersion = findProperty('driverVersion') ?: '0.11.11_beta' allprojects { repositories {