From 16a9831c93b40d7cce7cb557ae9c24171d093218 Mon Sep 17 00:00:00 2001 From: Po-Han Huang Date: Thu, 1 Oct 2026 23:12:22 -0700 Subject: [PATCH] Exempt Dynamo vLLM/SGLang from engine-first ordering in sign-off verifier Check 6(b) treated every Dynamo variant as an additional framework, so a dynamo-sglang entry failed when the model and SKU had no plain sglang entry. The ordering rule is meant to put open-source engines ahead of vendor-specific frameworks. Treat vllm, dynamo-vllm, sglang, sglang-disagg and dynamo-sglang as open-source engine entries that never need a prior entry. Require one of them before trt, dynamo-trt, atom or atom-disagg entries, keeping the new-hardware and new-architecture exceptions. Co-Authored-By: Claude Opus 5.5 --- .github/codeowner-signoff-verify-prompt.md | 27 ++++++++++++++++------ 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/.github/codeowner-signoff-verify-prompt.md b/.github/codeowner-signoff-verify-prompt.md index ae95864249..f10a4cd12a 100644 --- a/.github/codeowner-signoff-verify-prompt.md +++ b/.github/codeowner-signoff-verify-prompt.md @@ -236,13 +236,26 @@ and read its `framework:`, `runner:`, and `image:` fields. backed by vLLM/SGLang community maintainers). Name the offending image and the missing justification when you FAIL. (Note: some entries write the registry separator as `#`, e.g. `nvcr.io#nvidia/...`. Treat `#` as `/`.) -- (b) ENGINE-FIRST ORDERING: if this PR adds a config entry for a NON-vLLM/SGLang - framework (`framework:` of `trtllm`, `atom`, dynamo variants, etc., including images like - `rocm/atom*` and `nvcr.io...tensorrt-llm...`), check whether `inferencex-e2e/configs/*-master.yaml` - already contains a vLLM or SGLang entry for the same model (`model-prefix`) and SKU - (`runner`). If none exists and no exception is documented in the sign-off, FAIL. - vLLM/SGLang submissions must land before additional frameworks. Otherwise PASS with - the matching entry named. +- (b) ENGINE-FIRST ORDERING: the ordering rule separates open-source engines from + vendor-specific frameworks. Open-source engine entries are every vLLM or SGLang + deployment, whether served directly or through Dynamo or disaggregated serving: + `framework:` of `vllm`, `dynamo-vllm`, `sglang`, `sglang-disagg`, or `dynamo-sglang`. + Dynamo is a deployment layer, not a separate engine, so these entries are never + subject to this ordering rule. Vendor-specific framework entries are every other + engine, including `framework:` of `trt`, `dynamo-trt`, `atom`, or `atom-disagg`, and + images like `rocm/atom*` and `nvcr.io...tensorrt-llm...`. + - If this PR adds a vendor-specific framework entry, check whether + `inferencex-e2e/configs/*-master.yaml` already contains an open-source engine entry + (any of the frameworks listed above) for the same model (`model-prefix`) and SKU + (`runner`). If none exists and the sign-off documents no exception, FAIL. + Open-source engine submissions must land before vendor-specific frameworks. + Otherwise PASS with the matching entry named. + - Valid exceptions are truly new or preview hardware (e.g. Rubin GPUs such as Vera + Rubin NVL72 and Rubin NVL8, or MI455X UALoE72) and new model architectures that + vLLM/SGLang do not fundamentally support yet. + - PASS if the PR adds only open-source engine entries. For example, a + `dynamo-sglang` entry does not need an existing `sglang` entry for the same model + and SKU. - N/A if the PR changes no master-config entries (state that in one line). ## Check 7 — No submissions for deprecated models or scenarios