Repository navigation
Conversation
efric
requested review from
BKP,
artulab,
drprajap,
mawad-amd,
neoblizz and
nirvedhmeshram
as code owners
October 9, 2026 18:25
1 task
Collaborator
Author
|
subsumed by #568 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Iris currently initializes SDMA and creates its host/device queues eagerly when constructing a context, even for workloads that never use SDMA. The issue is that each queue reserves 8 MiB of host/device side memory, with the total allocation growing with the number of local ranks.
Make SDMA opt-in through a new
copy_engineparameter onIrisandiris.iris(), defaulting toNone. The default skips SDMA initialization, queue creation, and queue-context tensor allocation. SDMA users must explicitly passcopy_engine="sdma"to enable the existing host- and device-initiated operations.When disabled,
get_copy_engine_ctx()returnsNone, and host SDMA methods raise an error explaining how to enable SDMA. Update the SDMA examples and tests to opt in, and document the new behavior.Validation: Ruff lint and formatting passed. Targeted tests on two AMD GPUs covered context initialization, symmetric allocation, barriers, SDMA operations, and message passing: 231 passed and 36 existing ROCm graph-capture skips per rank.
Submission Checklist