Skip to content

json/bson encoder/decoder doesn't reflect the latest update #40

Description

@wyuinche

Expected Behavior

JSON, BSON marshalers must reflect the latest update.

Actual Behavior

Some marshalers doesn't reflect the latest update.

For example, approve-item json doesn't have contract and collection.

type ApproveItemJSONMarshaler struct {

type ApproveItemJSONMarshaler struct {
	hint.BaseHinter
	Approved base.Address        `json:"approved"`
	NFT      nft.NFTID           `json:"nft"`
	Currency currency.CurrencyID `json:"currency"`
}

Steps to Reproduce the Problem

omit; the project should be reviewed as a whole.

Specifications

  • commit; 7cb90dc
  • os; macos ventura
  • go version; go1.19

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions