Skip to content

approve set and all on-chain commands ignore --signature-type proxy, send txs from EOA #4

Description

@qtzx06

--signature-type proxy ignored for on-chain txs (approve, ctf), txs go from eoa

repro

  1. polymarket wallet create (gets eoa + proxy)
  2. set signature_type = proxy
  3. deposit usdc to proxy
  4. run polymarket approve set
  5. proxy allowance still 0
  6. polymarket clob balance shows proxy balance, but orders fail for allowance/balance

actual
approve set approves from eoa, not proxy, so contracts have no allowance on proxy funds.

code pointer
in src/main.rs, clob gets signature_type, approve does not:

Commands::Clob(args) => commands::clob::execute(..., cli.signature_type.as_deref())
Commands::Approve(args) => commands::approve::execute(...)

maybe also affected
approve check looks like eoa path too.
ctf subcommands seem same pattern as redeem issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions