Skip to content

Add code formatting (PHP-CS-Fixer) to repository and CI #3208

Description

@adenwuts

What would you like changed about the web client?

RuTorrent has its own 'fun' flavour of PHP styling, and I'm guessing everyone else's IDEs are screaming at them when they open it up. We also don't enforce any particular styling, meaning contributors are free to choose their own flavour of fun with every commit.
Further, we can fix the

Whitespace churn, unrelated reformatting and rewritten vendored files make a patch unreviewable, and a patch nobody can review does not get merged.

from the README.md by making sure there's no weird config to churn.

Describe the solution you'd like and propose possible alternatives.

a PHP-CS-Fixer ruleset in the repository root, a section added to the README.md about its expected use, and a CI check enforcing those checks on PRs.

There are other PHP formatting tools, but i'm less familiar with them.

Provide information and resources about the environment hosting the web client.

N/A

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions