From 31f3c6dee31e799a6cfdf087ff5c51add01dd65b Mon Sep 17 00:00:00 2001 From: t0kubetsu Date: Wed, 12 Aug 2026 14:48:35 +0200 Subject: [PATCH 1/3] ci: add GitHub Actions workflow Runs lint and the test suite on push and pull request to main, across Python 3.11-3.13 (the range pyproject declares via requires-python). Hardening per GitHub's own recommendations: actions pinned to full commit SHAs, permissions: contents: read, persist-credentials: false, concurrency cancellation, fail-fast: false, timeout-minutes. --- .github/workflows/ci.yml | 55 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..236e1ad --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,55 @@ +name: CI + +on: + push: + branches: [main] + pull_request: + branches: [main] + +# A new push supersedes the previous run on the same ref. +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +# Least privilege: this workflow only ever reads the repository. +permissions: + contents: read + +jobs: + test: + name: Python ${{ matrix.python-version }} + runs-on: ubuntu-latest + timeout-minutes: 15 + strategy: + # One failing interpreter must not mask the others. + fail-fast: false + matrix: + # pyproject declares requires-python >= 3.11, so every supported + # interpreter is exercised. + python-version: ["3.11", "3.12", "3.13"] + + steps: + - name: Checkout + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + # No credential is needed after checkout; leaving one in .git/config + # would expose it to anything later in the job. + persist-credentials: false + + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 + with: + python-version: ${{ matrix.python-version }} + cache: pip + cache-dependency-path: pyproject.toml + + - name: Install (editable, with dev extras) + run: python -m pip install -e ".[dev]" + + - name: Lint + run: ruff check subdomainenum/ + + - name: Test + # Network I/O is isolated in the *_utils modules and mocked there, so + # the suite needs neither a live network nor any external binary. + run: pytest --tb=short -q From ad5ed4101cbf378a8b0a549bb868a2b3602cbdda Mon Sep 17 00:00:00 2001 From: t0kubetsu Date: Wed, 12 Aug 2026 15:00:42 +0200 Subject: [PATCH 2/3] ci: declare the ruff rule set and provision ruff in dev extras MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The first CI run failed on every module, in two ways tracing to one root cause: lint was never actually pinned down. 1. 'ruff: command not found' — ruff is required by the before-commit checklist but was absent from the dev extras, so pip install -e '.[dev]' never provided it. It passed locally only because developer venvs had it installed by hand. 2. Lint failures on a clean checkout — with no [tool.ruff] section the linted rule set is whatever the installed ruff defaults to, and that widens each release, so a green local run and a red CI run could disagree purely by version. Copies the pattern portscanner already used (the only module that passed): pin target-version, state select = [E4, E7, E9, F] explicitly, add ruff>=0.6 to dev. No source change needed — every module passes this rule set as-is. --- pyproject.toml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 29b1bef..f4ea3d3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -55,7 +55,17 @@ where = ["."] include = ["subdomainenum*"] [project.optional-dependencies] -dev = ["pytest>=8", "pytest-cov>=5", "pytest-mock>=3.12"] +dev = ["pytest>=8", "pytest-cov>=5", "ruff>=0.6", "pytest-mock>=3.12"] + +[tool.ruff] +target-version = "py311" + +[tool.ruff.lint] +# Ruff's default rule set as of 0.6, made explicit. Without this the linted +# rule set is whatever the installed ruff defaults to, which widens on every +# release — so a green local run and a red CI run can disagree purely by +# version. Pinning it here makes the bar reviewable and stable. +select = ["E4", "E7", "E9", "F"] [tool.pytest.ini_options] pythonpath = ["."] From ffe40708a20c71e74fb50ddc901a50f3216cffb2 Mon Sep 17 00:00:00 2001 From: t0kubetsu Date: Wed, 12 Aug 2026 15:06:33 +0200 Subject: [PATCH 3/3] ci: enforce the documented coverage floor; correct the CI statement MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review caught two gaps. The guide claimed 'No CI config currently present', now false. And pytest reported coverage without enforcing the 80% minimum CLAUDE.md documents, so a drop below it would still pass — CI would have looked green while the documented bar was breached. Actual coverage is 99%, so the gate has ample headroom. --- CLAUDE.md | 3 ++- pyproject.toml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index df35423..04cc9ad 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -118,7 +118,8 @@ Environment variables for wordlist paths: `DEFAULT_DNS_WORDLIST`, `DEFAULT_VHOST - Sphinx-style docstrings: `:param name:`, `:returns:`, `:rtype:` (no `:type:` — type annotations on signatures are sufficient) - Conventional commits: `fix:`, `feat:`, `fix(scope):`, `refactor:`, `test:`, `docs:` - All external calls (subprocess, HTTP, TLS, DNS) are wrapped to never raise — errors captured in `ToolResult.error` -- No CI config currently present +- CI: `.github/workflows/ci.yml` runs `ruff check` and the full suite on + push and PR to `main`, across Python 3.11-3.13 ## Before Every Commit diff --git a/pyproject.toml b/pyproject.toml index f4ea3d3..01b50ac 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -70,4 +70,4 @@ select = ["E4", "E7", "E9", "F"] [tool.pytest.ini_options] pythonpath = ["."] testpaths = ["tests"] -addopts = "--cov=subdomainenum --cov-report=term-missing" +addopts = "--cov=subdomainenum --cov-report=term-missing --cov-fail-under=80"