From 034b2c7c460d4208b22bb8c5d168940a6b94fd7b Mon Sep 17 00:00:00 2001 From: t0kubetsu Date: Wed, 12 Aug 2026 14:48:30 +0200 Subject: [PATCH 1/3] ci: add GitHub Actions workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Runs lint and the test suite on push and pull request to main, across Python 3.11-3.13 (the range pyproject declares via requires-python). Hardening per GitHub's own recommendations: actions pinned to full commit SHAs, permissions: contents: read, persist-credentials: false, concurrency cancellation, fail-fast: false, timeout-minutes. Also adds `.github/dependabot.yml`, which this repo lacked entirely — pip plus **github-actions**. The actions ecosystem matters here specifically: pinning to SHAs is only safe if something bumps them, otherwise the pins silently rot. --- .github/dependabot.yml | 22 ++++++++++++++++ .github/workflows/ci.yml | 55 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 77 insertions(+) create mode 100644 .github/dependabot.yml create mode 100644 .github/workflows/ci.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml new file mode 100644 index 0000000..aab293c --- /dev/null +++ b/.github/dependabot.yml @@ -0,0 +1,22 @@ +version: 2 +updates: + - package-ecosystem: "pip" + directory: "/" + schedule: + interval: "daily" + labels: + - "dependencies" + commit-message: + prefix: "chore" + include: "scope" + open-pull-requests-limit: 10 + + - package-ecosystem: "github-actions" + directory: "/" + schedule: + interval: "daily" + labels: + - "dependencies" + commit-message: + prefix: "chore" + include: "scope" diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..21eff9c --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,55 @@ +name: CI + +on: + push: + branches: [main] + pull_request: + branches: [main] + +# A new push supersedes the previous run on the same ref. +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +# Least privilege: this workflow only ever reads the repository. +permissions: + contents: read + +jobs: + test: + name: Python ${{ matrix.python-version }} + runs-on: ubuntu-latest + timeout-minutes: 15 + strategy: + # One failing interpreter must not mask the others. + fail-fast: false + matrix: + # pyproject declares requires-python >= 3.11, so every supported + # interpreter is exercised. + python-version: ["3.11", "3.12", "3.13"] + + steps: + - name: Checkout + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + # No credential is needed after checkout; leaving one in .git/config + # would expose it to anything later in the job. + persist-credentials: false + + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 + with: + python-version: ${{ matrix.python-version }} + cache: pip + cache-dependency-path: pyproject.toml + + - name: Install (editable, with dev extras) + run: python -m pip install -e ".[dev]" + + - name: Lint + run: ruff check fileanalyzer/ + + - name: Test + # Network I/O is isolated in the *_utils modules and mocked there, so + # the suite needs neither a live network nor any external binary. + run: pytest --tb=short -q From 738d3b546c72435c3ed87394b92d488d76aba19a Mon Sep 17 00:00:00 2001 From: t0kubetsu Date: Wed, 12 Aug 2026 15:00:52 +0200 Subject: [PATCH 2/3] ci: declare the ruff rule set and provision ruff in dev extras MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The first CI run failed on every module, in two ways tracing to one root cause: lint was never actually pinned down. 1. 'ruff: command not found' — ruff is required by the before-commit checklist but was absent from the dev extras, so pip install -e '.[dev]' never provided it. It passed locally only because developer venvs had it installed by hand. 2. Lint failures on a clean checkout — with no [tool.ruff] section the linted rule set is whatever the installed ruff defaults to, and that widens each release, so a green local run and a red CI run could disagree purely by version. Copies the pattern portscanner already used (the only module that passed): pin target-version, state select = [E4, E7, E9, F] explicitly, add ruff>=0.6 to dev. No source change needed — every module passes this rule set as-is. --- pyproject.toml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pyproject.toml b/pyproject.toml index 96c3b45..89b0ed8 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -60,6 +60,16 @@ include = ["fileanalyzer*"] [project.optional-dependencies] dev = ["pytest>=8", "pytest-cov>=5", "pytest-mock>=3.12", "ruff>=0.4"] +[tool.ruff] +target-version = "py311" + +[tool.ruff.lint] +# Ruff's default rule set as of 0.6, made explicit. Without this the linted +# rule set is whatever the installed ruff defaults to, which widens on every +# release — so a green local run and a red CI run can disagree purely by +# version. Pinning it here makes the bar reviewable and stable. +select = ["E4", "E7", "E9", "F"] + [tool.pytest.ini_options] pythonpath = ["."] testpaths = ["tests"] From 60c14612abf6c0c7dc8964c76dc851bd9a129d11 Mon Sep 17 00:00:00 2001 From: t0kubetsu Date: Wed, 12 Aug 2026 15:06:38 +0200 Subject: [PATCH 3/3] ci: lint tests/ as well, per the repo's own standard MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The lint step covered only fileanalyzer/, while this repo's documented lint standard includes tests/ — violations in test code bypassed the new gate. Verified clean over both paths. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 21eff9c..0980ec7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,7 +47,7 @@ jobs: run: python -m pip install -e ".[dev]" - name: Lint - run: ruff check fileanalyzer/ + run: ruff check fileanalyzer/ tests/ - name: Test # Network I/O is isolated in the *_utils modules and mocked there, so