The intention of pull #121 from @imerr was to have the callback client.OnDisconnected being called within the client even in case of socket errors or different exceptions.
I think that intention was fulfilled. This can be verified for example by calling client.Connect("localhost", 13378888); which uses an invalid port.
On the other hand I think that the change had unintended side effects. In my project I can see that within the client during regular, error-free use the callback client.OnDisconnected is always called twice. It does not matter whether the client or the server initiated the disconnect.
In my opinion that callback should only be called once (not twice).
My knowledge about Telepathy is not good enough to suggest an improvement or even create a pull request, sorry.
The intention of pull #121 from @imerr was to have the callback
client.OnDisconnectedbeing called within the client even in case of socket errors or different exceptions.I think that intention was fulfilled. This can be verified for example by calling
client.Connect("localhost", 13378888);which uses an invalid port.On the other hand I think that the change had unintended side effects. In my project I can see that within the client during regular, error-free use the callback
client.OnDisconnectedis always called twice. It does not matter whether the client or the server initiated the disconnect.In my opinion that callback should only be called once (not twice).
My knowledge about Telepathy is not good enough to suggest an improvement or even create a pull request, sorry.