Repository navigation
feat: task due date - #197
Merged
Merged
Conversation
Co-authored-by: MessiasLima <[email protected]>
7 tasks
Owner
|
/oc fix detekt issues |
Co-authored-by: MessiasLima <[email protected]>
Contributor
Author
|
Done. Detekt is now clean and the focused JVM tests pass. Changes made to
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implemented the optional due date feature for Create Task.
What changed
New component:
FoliaryDatePickerModalBottomSheetwith aDatePicker.kotlin.time.Instant) usingTimeZone.currentSystemDefault().Lucide.Xclear button when a date is selected; tapping it emitsonDateSelected(null)and does not open the sheet.FoliaryDatePicker:Card,FoliaryDatePicker:Value,FoliaryDatePicker:ClearButton.CreateTaskScreenFoliaryDatePickerbetween the description field and the save button.CreateTaskEvent.DueDateChanged.CreateTaskScreen:DueDatePicker.CreateTaskViewModeldueDate: Instant? = nulltoCreateTaskViewData.CreateTaskEvent.DueDateChanged.state.dueDateinstead ofnull.String resources added to
strings.xml:create_task_due_date_labelcreate_task_due_date_placeholdercreate_task_due_date_clear_a11ydate_picker_confirmdate_picker_cancelTests
CreateTaskViewModelTest: defaultdueDatenull, update/clear events, save persists selected date and persistsnullwhen untouched.CreateTaskScreenTest: placeholder visibility, selected-date display, clear button visibility, clear emitsDueDateChanged(null).FoliaryDatePickerTest: placeholder/selected states, clear button behavior, card opens the bottom sheet.No new third-party libraries were added.
Verification
Ran the focused JVM tests:
All passed.
Design review
Per the acceptance criteria, the visual design still needs explicit review before the ticket is closed. Recommended checklist:
Closes #122
opencode session | github run