In #1, @aldalahmeh adds the option to include active and reactive load as measurements, along with other changes/new features. We are splitting this into separate threads to more easily track the discussion.
So, this proposed change is fine for loads at buses without generators. But, for loads at generator buses, this is not consistent with the assumption in the existing code, which assumes the load is a known quantity. To handle that case, we need more discussion and design work.
I'm ok with moving ahead with simply adding load measurements as in #1 if we also include a README that clearly documents that load measurements assume zero generation at the bus, and generator measurements assume known (possibly 0) load at the bus, and no multiple generators per bus. In fact, it should throw an error in the case of multiple injections (load and gen, or multiple gens) at a bus, until we can implement a more rational way of handling those cases.
If and when we decide to attempt to go toward a more general design that handles multiple injection measurements at a bus, this comment describes the cases I think we need to handle.
What do you think @aldalahmeh?
If you are in agreement, could you create a new PR that just adds the active and reactive load measurements, throws an error for the multiple injection measurements per bus, and adds a README.md as described above?
In #1, @aldalahmeh adds the option to include active and reactive load as measurements, along with other changes/new features. We are splitting this into separate threads to more easily track the discussion.
So, this proposed change is fine for loads at buses without generators. But, for loads at generator buses, this is not consistent with the assumption in the existing code, which assumes the load is a known quantity. To handle that case, we need more discussion and design work.
I'm ok with moving ahead with simply adding load measurements as in #1 if we also include a README that clearly documents that load measurements assume zero generation at the bus, and generator measurements assume known (possibly 0) load at the bus, and no multiple generators per bus. In fact, it should throw an error in the case of multiple injections (load and gen, or multiple gens) at a bus, until we can implement a more rational way of handling those cases.
If and when we decide to attempt to go toward a more general design that handles multiple injection measurements at a bus, this comment describes the cases I think we need to handle.
What do you think @aldalahmeh?
If you are in agreement, could you create a new PR that just adds the active and reactive load measurements, throws an error for the multiple injection measurements per bus, and adds a
README.mdas described above?