Skip to content

Remove the shared HDF5 compat entry from test/Project.toml - #17

Merged
michakraus merged 1 commit into
mainfrom
testsuites/part-r10
Sep 29, 2026
Merged

michakraus merged 1 commit into
mainfrom
testsuites/part-r10

Conversation

@michakraus

Copy link
Copy Markdown
Member

Removes the shared [compat] entry HDF5 = "0.16, 0.17" from test/Project.toml. HDF5 is a root dependency, so its root bound governs the test environment. Part R10 of the plan to unify the test suites: test and docs projects keep [compat] entries only for their own dependencies (the compat rule of the test-layout check).

  • test-layout.jl --check (Environment 35418dd): on the base it reports the HDF5 entry. On the branch it reports no violation.
  • docs/Project.toml is unchanged. Plots and StatsBase are docs-only dependencies.
  • The full suite gives 81 pass on both trees (Aqua 11, Particles 14, Particle Lists 44, Defects 12). The resolved versions are the same.
  • There is no open Dependabot or CompatHelper PR.

Pre-PR verification

  • Fixed: nothing needed a fix.
  • Unresolved: none. .github/dependabot.yml still describes the copy rule and differs from the canonical copy by a line wrap. The dependabot rollout covers it, and this PR does not edit .github/.
  • Pre-existing: .github/dependabot.yml:12-15 is not byte-identical to the canonical copy. The only difference is a line wrap (quality, not from this branch).
  • Checked and clean: correctness. On the base, test-layout.jl --check reports the shared HDF5 [compat] entry, and on head it passes. A narrowed root bound shows in the test resolve as "restricted to versions 0.16 by ParticleMethods". No other file describes the removed entry. No comment is stale. History appears only in CHANGELOG.md, and its [Unreleased] entry is present and matches the diff. NFC and git diff --check are clean.
  • Not checked: piracy, type stability and allocations, because the change has no executable line. Pkg.test() is left to CI. The HDF5 0.16 floor was not resolved; it is unchanged, and the Downgrade job covers it.

Critic

Verdict: PASS, round 1, at 09f35c1 (origin/main = 1f01cb4)

clause verdict
Removal 1: test-layout.jl --check gives no violation PASS. Base: [compat] test/Project.toml has a [compat] entry for HDF5, a dependency of Project.toml. Branch: no output, exit 0.
Removal 2a: exactly the shared entries are removed PASS. Only HDF5 = "0.16, 0.17" is removed.
Removal 2b: no other line changes PASS. The test-only entries are unchanged, and docs/Project.toml is unchanged.
Removal 2c: a comment that names the removed bound is removed PASS. No comment names the bound.
Removal 3a: the full suite is green and no test is lost PASS. The totals are the same on both trees.
Removal 3b: the resolution does not change PASS. HDF5 v0.17.4, Aqua v0.8.18 and StaticArrays v1.9.22 on both trees.
Removal 3c: CI is green not verified. This PR's CI answers it before the merge.
Removal 4: the CHANGELOG entry PASS. The entry is in CHANGELOG.md:28-32.
Removal Tests catch: the mutant CAUGHT.
Plan rule: nothing under src/ changes PASS.
Edge: open Dependabot or CompatHelper PRs PASS. There is none.

Known issues added

none

Advisor decisions

none for this part

Unresolved

  • The dependabot comment named under Pre-PR verification. The rollout covers it.

🤖 Generated with Claude Code

The root Project.toml bound governs the test environment; a test
project keeps compat entries only for its own dependencies.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Copilot AI lite review requested due to automatic review settings September 28, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (1f01cb4) to head (09f35c1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files           4        4           
  Lines         100      100           
=======================================
  Hits           86       86           
  Misses         14       14           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michakraus
michakraus merged commit 1e63706 into main Sep 29, 2026
13 checks passed
@michakraus
michakraus deleted the testsuites/part-r10 branch September 29, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants