Repository navigation
Remove the shared HDF5 compat entry from test/Project.toml - #17
Merged
Merged
Conversation
The root Project.toml bound governs the test environment; a test project keeps compat entries only for its own dependencies. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 4 4
Lines 100 100
=======================================
Hits 86 86
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the shared
[compat]entryHDF5 = "0.16, 0.17"fromtest/Project.toml. HDF5 is a root dependency, so its root bound governs the test environment. Part R10 of the plan to unify the test suites: test and docs projects keep[compat]entries only for their own dependencies (the compat rule of the test-layout check).test-layout.jl --check(Environment 35418dd): on the base it reports the HDF5 entry. On the branch it reports no violation.docs/Project.tomlis unchanged. Plots and StatsBase are docs-only dependencies.Pre-PR verification
.github/dependabot.ymlstill describes the copy rule and differs from the canonical copy by a line wrap. The dependabot rollout covers it, and this PR does not edit.github/..github/dependabot.yml:12-15is not byte-identical to the canonical copy. The only difference is a line wrap (quality, not from this branch).test-layout.jl --checkreports the shared HDF5[compat]entry, and on head it passes. A narrowed root bound shows in the test resolve as "restricted to versions 0.16 by ParticleMethods". No other file describes the removed entry. No comment is stale. History appears only inCHANGELOG.md, and its[Unreleased]entry is present and matches the diff. NFC andgit diff --checkare clean.Pkg.test()is left to CI. The HDF5 0.16 floor was not resolved; it is unchanged, and the Downgrade job covers it.Critic
Verdict: PASS, round 1, at 09f35c1 (origin/main = 1f01cb4)
test-layout.jl --checkgives no violation[compat] test/Project.toml has a [compat] entry for HDF5, a dependency of Project.toml. Branch: no output, exit 0.HDF5 = "0.16, 0.17"is removed.src/changesKnown issues added
none
Advisor decisions
none for this part
Unresolved
🤖 Generated with Claude Code