Skip to content

Raise floors to Julia 1.11 and GeometricBase 0.15 - #31

Merged
michakraus merged 4 commits into
mainfrom
floor/part-w3
Oct 2, 2026
Merged

michakraus merged 4 commits into
mainfrom
floor/part-w3

Conversation

@michakraus

Copy link
Copy Markdown
Member

Raises the floors to Julia 1.11, GeometricBase 0.15.0, CompactBasisFunctions 0.4.2 and QuadratureRules 0.2.2, because GeometricBase 0.15 declares its stubs public and requires Julia 1.11. The version goes from 0.3.0 to 0.3.1. This is part W3 of the plan to make the GeometricBase stubs public, for SimpleSplines.

The PR title has 50 characters or fewer. Three of the commit subjects are longer than 50 characters. A squash merge under this title keeps the house limit, with no rewrite of the branch history.

Pre-PR verification

Fixed: nothing. No defect needed a change.

Unresolved (nits):

  • In CHANGELOG.md, ### Bug Fixes comes before ### New Features under [Unreleased]. The released sections use the other order. Fixed in c26e041: ### Bug Fixes now comes after ### New Features.
  • The three commit subjects are longer than 50 characters. A squash-merge under a short PR title fixes this.

Pre-existing: none.

Checked and clean:

  • The floors match the registered gate releases: GeometricBase 0.15.0, CompactBasisFunctions 0.4.2, QuadratureRules 0.2.2, Julia 1.11. Each of these releases requires julia = "1.11.0 - 1".
  • test/ and docs/ have no bound that needs a change.
  • No VERSION gate against 1.10 or 1.11 remains.
  • The package resolves and loads on Julia 1.11.9 and 1.13.1.
  • On 1.11.9, both the local function and the closure form of the kernel = :project call infer a concrete CirculantMass. So the deleted comment in test/mass.jl described only Julia 1.10.
  • Aqua.test_piracies and test_ambiguities pass on 1.13.1.
  • test/mass.jl is formatted.
  • No stale or historical prose was found.
  • The CHANGELOG entry is present.

Not checked:

  • Allocations and inference beyond the probe above, because no .jl source line changed.
  • Aqua on 1.11.
  • The CI test matrix (§F clause 6) and the full suite, which CI runs.

Critic

Critic 1a: Verdict: PASS. Clauses 1–5 met, no blocking defect; clause 6 open until the PR's CI. Evidence (clause: result): §F 1 julia "1.10" → "1.11" in the root, none added in test/ or docs/ — PASS; §F 2 GeometricBase "0.14.8" → "0.15.0", CompactBasisFunctions "0.3, 0.4" → "0.4.2", QuadratureRules "0.2" → "0.2.2", each the latest registered gate version, other bounds unchanged — PASS; §F 2 fresh resolve on Julia 1.11 (GeometricBase 0.15.0, CompactBasisFunctions 0.4.2, QuadratureRules 0.2.2, ContinuumArrays 0.21.5, JET 0.9.20; loads on 1.11.9) — PASS; §F 3 0.3.0 → 0.3.1 — PASS; §F 4 CHANGELOG entry present — PASS; §F 5 no VERSION gate — PASS; §F 6 open, local substitute run-tests.jl affected PASS in 75 s; named mutants for clauses 1 and 2 CAUGHT.

Critic 1b: Verdict: PASS. Evidence: §F 1 PASS; §F 2 PASS (registry has 0.15.0, 0.4.2 and 0.2.2); fresh resolve on 1.11 PASS; §F 3 PASS; §F 4 PASS; §F 5 PASS; §F 6 open, local proxy on 1.13 PASS in 74 s (Aqua 11/11, JET 10/10, Meshes 62/62, Boundary conditions 68/68, Periodic B-spline bases 4586/4586, Clamped and recombined bases 58142/58142, Mass operators 1041/1041, Spline quadrature 340/340, Tensor products 408/408, Polar splines 454/454, Doctests 1/1); named mutants for clauses 1 and 2 CAUGHT (the clause-2 mutant also fails a fresh resolve); docs class rule does not apply (docs env needs no unreleased package); scope is Project.toml and CHANGELOG.md only.

Both critics' Other defects (the stale test/mass.jl comment, and the three-sentence CHANGELOG entry) are fixed in cf76666 and 344f293.

Suite counts

  • Julia 1.13.1, Pkg.test(), check-bounds auto: 64723 passed, 0 failed. GeometricBase v0.15.0, CompactBasisFunctions v0.4.2, QuadratureRules v0.2.2.
  • Julia 1.11.9, Pkg.test(), check-bounds yes: 64723 passed, 0 failed, same versions.

Both runs are at 1a75969. The later commits change only a CHANGELOG entry, the order of its sections, and a two-line comment in test/mass.jl.

Known issues added

None.

Advisor decisions

None for SimpleSplines.

🤖 Generated with Claude Code

michakraus and others added 4 commits October 2, 2026 09:05
CompactBasisFunctions becomes 0.4.2 and QuadratureRules 0.2.2, the
releases of the earlier gates. The version becomes 0.3.1.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ference

The floor is now Julia 1.11, so the comment in test/mass.jl names 1.10 as a
version, not as the compat floor.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
… use a house CHANGELOG heading

The verifier measured the closure forms on Julia 1.11.9, 1.12.7 and 1.13.1:
each infers a concrete CirculantMass, so the 1.10 reason applies to no
supported version. The CHANGELOG entry moves from Changed to Bug Fixes, as
the 0.3.0 compat change did.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Bug Fixes now follows New Features, as in the released sections.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 07:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The compatibility, versioning, documentation, and test-comment updates are consistent and complete.

Review effort: Balanced
Findings: None

What changed in this PR

Raises minimum supported Julia and dependency versions for GeometricBase’s public stubs.

Changes:

  • Raises Julia and dependency compatibility floors.
  • Bumps SimpleSplines to 0.3.1.
  • Updates the changelog and removes a Julia 1.10-specific test comment.
File Description
Project.toml Updates package version and compatibility floors.
CHANGELOG.md Documents the new minimum versions.
test/​mass.jl Removes obsolete Julia 1.10 guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.42%. Comparing base (83db500) to head (c26e041).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   91.89%   91.42%   -0.48%     
==========================================
  Files          10        9       -1     
  Lines        1185     1178       -7     
==========================================
- Hits         1089     1077      -12     
- Misses         96      101       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michakraus
michakraus merged commit b78c259 into main Oct 2, 2026
13 of 14 checks passed
@michakraus
michakraus deleted the floor/part-w3 branch October 2, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants