Repository navigation
Raise floors to Julia 1.11 and GeometricBase 0.15 - #31
Merged
Merged
Conversation
CompactBasisFunctions becomes 0.4.2 and QuadratureRules 0.2.2, the releases of the earlier gates. The version becomes 0.3.1. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ference The floor is now Julia 1.11, so the comment in test/mass.jl names 1.10 as a version, not as the compat floor. Co-Authored-By: Claude Opus 5.5 <[email protected]>
… use a house CHANGELOG heading The verifier measured the closure forms on Julia 1.11.9, 1.12.7 and 1.13.1: each infers a concrete CirculantMass, so the 1.10 reason applies to no supported version. The CHANGELOG entry moves from Changed to Bug Fixes, as the 0.3.0 compat change did. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Bug Fixes now follows New Features, as in the released sections. Co-Authored-By: Claude Opus 5.5 <[email protected]>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The compatibility, versioning, documentation, and test-comment updates are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Raises minimum supported Julia and dependency versions for GeometricBase’s public stubs.
Changes:
- Raises Julia and dependency compatibility floors.
- Bumps SimpleSplines to 0.3.1.
- Updates the changelog and removes a Julia 1.10-specific test comment.
| File | Description |
|---|---|
Project.toml |
Updates package version and compatibility floors. |
CHANGELOG.md |
Documents the new minimum versions. |
test/mass.jl |
Removes obsolete Julia 1.10 guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 91.89% 91.42% -0.48%
==========================================
Files 10 9 -1
Lines 1185 1178 -7
==========================================
- Hits 1089 1077 -12
- Misses 96 101 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the floors to Julia 1.11, GeometricBase 0.15.0, CompactBasisFunctions 0.4.2 and QuadratureRules 0.2.2, because GeometricBase 0.15 declares its stubs public and requires Julia 1.11. The version goes from 0.3.0 to 0.3.1. This is part W3 of the plan to make the GeometricBase stubs public, for SimpleSplines.
The PR title has 50 characters or fewer. Three of the commit subjects are longer than 50 characters. A squash merge under this title keeps the house limit, with no rewrite of the branch history.
Pre-PR verification
Fixed: nothing. No defect needed a change.
Unresolved (nits):
CHANGELOG.md,### Bug Fixescomes before### New Featuresunder[Unreleased]. The released sections use the other order. Fixed in c26e041:### Bug Fixesnow comes after### New Features.Pre-existing: none.
Checked and clean:
julia = "1.11.0 - 1".test/anddocs/have no bound that needs a change.VERSIONgate against 1.10 or 1.11 remains.kernel = :projectcall infer a concreteCirculantMass. So the deleted comment intest/mass.jldescribed only Julia 1.10.Aqua.test_piraciesandtest_ambiguitiespass on 1.13.1.test/mass.jlis formatted.Not checked:
.jlsource line changed.Critic
Critic 1a: Verdict: PASS. Clauses 1–5 met, no blocking defect; clause 6 open until the PR's CI. Evidence (clause: result): §F 1 julia "1.10" → "1.11" in the root, none added in test/ or docs/ — PASS; §F 2 GeometricBase "0.14.8" → "0.15.0", CompactBasisFunctions "0.3, 0.4" → "0.4.2", QuadratureRules "0.2" → "0.2.2", each the latest registered gate version, other bounds unchanged — PASS; §F 2 fresh resolve on Julia 1.11 (GeometricBase 0.15.0, CompactBasisFunctions 0.4.2, QuadratureRules 0.2.2, ContinuumArrays 0.21.5, JET 0.9.20; loads on 1.11.9) — PASS; §F 3 0.3.0 → 0.3.1 — PASS; §F 4 CHANGELOG entry present — PASS; §F 5 no VERSION gate — PASS; §F 6 open, local substitute
run-tests.jl affectedPASS in 75 s; named mutants for clauses 1 and 2 CAUGHT.Critic 1b: Verdict: PASS. Evidence: §F 1 PASS; §F 2 PASS (registry has 0.15.0, 0.4.2 and 0.2.2); fresh resolve on 1.11 PASS; §F 3 PASS; §F 4 PASS; §F 5 PASS; §F 6 open, local proxy on 1.13 PASS in 74 s (Aqua 11/11, JET 10/10, Meshes 62/62, Boundary conditions 68/68, Periodic B-spline bases 4586/4586, Clamped and recombined bases 58142/58142, Mass operators 1041/1041, Spline quadrature 340/340, Tensor products 408/408, Polar splines 454/454, Doctests 1/1); named mutants for clauses 1 and 2 CAUGHT (the clause-2 mutant also fails a fresh resolve); docs class rule does not apply (docs env needs no unreleased package); scope is Project.toml and CHANGELOG.md only.
Both critics' Other defects (the stale
test/mass.jlcomment, and the three-sentence CHANGELOG entry) are fixed in cf76666 and 344f293.Suite counts
Pkg.test(), check-bounds auto: 64723 passed, 0 failed. GeometricBase v0.15.0, CompactBasisFunctions v0.4.2, QuadratureRules v0.2.2.Pkg.test(), check-bounds yes: 64723 passed, 0 failed, same versions.Both runs are at 1a75969. The later commits change only a CHANGELOG entry, the order of its sections, and a two-line comment in
test/mass.jl.Known issues added
None.
Advisor decisions
None for SimpleSplines.
🤖 Generated with Claude Code