Skip to content

Insufficient buffer truncates AMI response #2

Description

@InterLinked1

Not really surprising, but a static buffer that is too small to fit a single entire AMI response will result in a truncated response being processed.

While this could be fixed easily by simply increasing the buffer to something reasonably large, like from 4096 to 1048576 (which is what I've done in production at the moment), long term we should really be using a dynamic buffer, resizing if necessary, e.g. using realloc, in order to handle any arbitrarily long AMI response. Then we can do away with the fixed buffer altogether, and this should provide maximal resiliency.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions