Repository navigation
Update factoriotools/factorio Docker tag to v2.1.24 - #508
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
| # docker pull --platform linux/amd64 factoriotools/factorio:2.1.23 | ||
| # docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23 | ||
| FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f | ||
| FROM factoriotools/factorio:2.1.24@sha256:fb83f98b901688d101e2f12d9a2109b085b216790012324f04320cdc01a069d4 |
There was a problem hiding this comment.
This changes the tag to 2.1.24 but leaves the other places that name the version on 2.1.23, so the image build and dockerfile.test.mjs will fail:
preview-service/container/Dockerfile:27still runsfactorio --version | grep -q "Version: 2.1.23". The image build fails on the 2.1.24 base.preview-service/worker/wrangler.jsonc:23still has"FACTORIO_VERSION": "2.1.23". That value is part of the render cache key, andpnpm run types:synchas to be rerun after changing it.- The comments on lines 9 and 16-17 still say 2.1.23.
The PR description lists these steps as required in the same commit as a tag change. CLAUDE.md also says dockerfile.test.mjs fails if the three disagree.
Update those spots, run pnpm run types:sync, and run pnpm --filter @fmw/preview-container run test:integration before merging.
7402015 to
d577170
Compare
| # docker pull --platform linux/amd64 factoriotools/factorio:2.1.23 | ||
| # docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23 | ||
| FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f | ||
| FROM factoriotools/factorio:2.1.24@sha256:fb83f98b901688d101e2f12d9a2109b085b216790012324f04320cdc01a069d4 |
There was a problem hiding this comment.
The tag moves to 2.1.24, but two other places still say 2.1.23:
- The build-time assertion at
Dockerfile:27,grep -q "Version: 2.1.23", fails against a 2.1.24 image. That breaks the image build. FACTORIO_VERSIONinpreview-service/worker/wrangler.jsonc:23and its generated type inworker-configuration.d.ts:6still read2.1.23.
dockerfile.test.mjs checks that the tag, the version assertion and FACTORIO_VERSION agree, so preview:test (and the required verify check) should fail on this PR as it stands.
The PR body says what to do. Update the assertion and FACTORIO_VERSION in the same commit, then run pnpm run types:sync. Also update the 2.1.23 refresh-command comments at lines 9 and 16-17.
CLAUDE.md, "Preview service" section: "dockerfile.test.mjs ... asserts ... the tag agrees with the version assertion below it".
d577170 to
a4f2c72
Compare
| # docker pull --platform linux/amd64 factoriotools/factorio:2.1.23 | ||
| # docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23 | ||
| FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f | ||
| FROM factoriotools/factorio:2.1.24@sha256:fb83f98b901688d101e2f12d9a2109b085b216790012324f04320cdc01a069d4 |
There was a problem hiding this comment.
This tag bump is incomplete, so the container tests will fail.
The FROM now pins 2.1.24, but the rest of the repo still says 2.1.23:
preview-service/container/Dockerfile:27still hasRUN ... factorio --version | grep -q "Version: 2.1.23". The image build would fail on it.preview-service/worker/wrangler.jsonc:23still has"FACTORIO_VERSION": "2.1.23".- The comments at lines 9 and 16-17 still name
2.1.23.
The PR body says a tag change needs the assertion and FACTORIO_VERSION updated in the same commit, followed by pnpm run types:sync. It also says dockerfile.test.mjs fails if the three disagree. This PR changes only the FROM line.
Please update all of them together, rerun types:sync, and run the test:integration image build. Alternatively, close this PR and hold at 2.1.23 until the move is deliberate. See the Preview service section of CLAUDE.md.
a4f2c72 to
e46428f
Compare
| # docker pull --platform linux/amd64 factoriotools/factorio:2.1.23 | ||
| # docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23 | ||
| FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f | ||
| FROM factoriotools/factorio:2.1.24@sha256:a0c019b7608975a58f1694de54a2326e13a5aa2d123c18f48e5396181e366e28 |
There was a problem hiding this comment.
This changes the tag to 2.1.24, but the other places that name the version still say 2.1.23:
preview-service/container/Dockerfile:27still hasRUN ... factorio --version | grep -q "Version: 2.1.23". The image build would fail at that step against a 2.1.24 base.FACTORIO_VERSIONinpreview-service/worker/wrangler.jsonc:23is still"2.1.23". That value is part of the render cache key.- The refresh-command comments on lines 16-17 still name
2.1.23.
dockerfile.test.mjs asserts that the FROM tag, the --version assertion and FACTORIO_VERSION agree, so preview:test and the required verify check should fail on this commit. The PR body lists the same steps (update the assertion and FACTORIO_VERSION, run pnpm run types:sync) as required before merging a tag change; see CLAUDE.md, "Preview service".
Please update all three in this PR, run pnpm run types:sync, and run pnpm --filter @fmw/preview-container run test:integration to build the image.
fd7ef52 to
989ef6b
Compare
Renovate moved only the FROM line. The build-time `--version` assertion, the refresh comments and the worker's FACTORIO_VERSION must move with it, which test/dockerfile.test.mjs checks. Worker types regenerated with `pnpm run types:sync` for the new var value. The registry check in that test confirms the pinned digest is a Factorio 2.1.24 image. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Kd6o1aFcJ4CmpGhDgPionn
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
2.1.23→2.1.24A digest re-pin of the SAME tag is routine. A tag change is not - it changes the game that local preview renders use (the container is now a local tool for agents), and the app advertises a Factorio version of its own (
FACTORIO_TARGET_VERSION) that would then disagree with the container.Before merging a tag change: (1) in the same commit, update the
RUN factorio --version | grep -qassertion andFACTORIO_VERSIONinpreview-service/worker/wrangler.jsonc(part of the render cache key), then runpnpm run types:sync-dockerfile.test.mjsfails if any of the three disagree; (2) build the image, which no CI job does (#183) -pnpm --filter @fmw/preview-container run test:integrationbuilds it and renders both a Nauvis and a non-Nauvis preview; (3) runpnpm refs:sync --checkandpnpm refs:sync --fixturesto see which oracle fixtures now predate the game.Note the local Factorio binary is what
refs:syncpins to, and Steam moves it without asking - so the container and the dev machine can drift apart in either direction. Check which one actually moved before assuming the container is stale.Configuration
📅 Schedule: (in timezone America/Los_Angeles)
* 12-23 * * 0)* 0-11 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.