Skip to content

Update factoriotools/factorio Docker tag to v2.1.24 - #508

Merged
wormeyman merged 2 commits into
mainfrom
renovate/factoriotools-factorio-2.x
Nov 8, 2026
Merged

wormeyman merged 2 commits into
mainfrom
renovate/factoriotools-factorio-2.x

Conversation

@renovate

@renovate renovate Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
factoriotools/factorio final patch 2.1.23 → 2.1.24

A digest re-pin of the SAME tag is routine. A tag change is not - it changes the game that local preview renders use (the container is now a local tool for agents), and the app advertises a Factorio version of its own (FACTORIO_TARGET_VERSION) that would then disagree with the container.

Before merging a tag change: (1) in the same commit, update the RUN factorio --version | grep -q assertion and FACTORIO_VERSION in preview-service/worker/wrangler.jsonc (part of the render cache key), then run pnpm run types:sync - dockerfile.test.mjs fails if any of the three disagree; (2) build the image, which no CI job does (#183) - pnpm --filter @fmw/preview-container run test:integration builds it and renders both a Nauvis and a non-Nauvis preview; (3) run pnpm refs:sync --check and pnpm refs:sync --fixtures to see which oracle fixtures now predate the game.

Note the local Factorio binary is what refs:sync pins to, and Steam moves it without asking - so the container and the dev machine can drift apart in either direction. Check which one actually moved before assuming the container is stale.


Configuration

📅 Schedule: (in timezone America/Los_Angeles)

  • Branch creation
    • Between 12:00 PM and 11:59 PM, only on Sunday (* 12-23 * * 0)
    • Between 12:00 AM and 11:59 AM, only on Monday (* 0-11 * * 1)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b1684a8a-4b93-4c51-9207-93fcbc5af3cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Comment thread preview-service/container/Dockerfile Outdated
# docker pull --platform linux/amd64 factoriotools/factorio:2.1.23
# docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23
FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f
FROM factoriotools/factorio:2.1.24@sha256:fb83f98b901688d101e2f12d9a2109b085b216790012324f04320cdc01a069d4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the tag to 2.1.24 but leaves the other places that name the version on 2.1.23, so the image build and dockerfile.test.mjs will fail:

  • preview-service/container/Dockerfile:27 still runs factorio --version | grep -q "Version: 2.1.23". The image build fails on the 2.1.24 base.
  • preview-service/worker/wrangler.jsonc:23 still has "FACTORIO_VERSION": "2.1.23". That value is part of the render cache key, and pnpm run types:sync has to be rerun after changing it.
  • The comments on lines 9 and 16-17 still say 2.1.23.

The PR description lists these steps as required in the same commit as a tag change. CLAUDE.md also says dockerfile.test.mjs fails if the three disagree.

Update those spots, run pnpm run types:sync, and run pnpm --filter @fmw/preview-container run test:integration before merging.

@renovate
renovate Bot force-pushed the renovate/factoriotools-factorio-2.x branch from 7402015 to d577170 Compare November 2, 2026 10:26
Comment thread preview-service/container/Dockerfile Outdated
# docker pull --platform linux/amd64 factoriotools/factorio:2.1.23
# docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23
FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f
FROM factoriotools/factorio:2.1.24@sha256:fb83f98b901688d101e2f12d9a2109b085b216790012324f04320cdc01a069d4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag moves to 2.1.24, but two other places still say 2.1.23:

  • The build-time assertion at Dockerfile:27, grep -q "Version: 2.1.23", fails against a 2.1.24 image. That breaks the image build.
  • FACTORIO_VERSION in preview-service/worker/wrangler.jsonc:23 and its generated type in worker-configuration.d.ts:6 still read 2.1.23.

dockerfile.test.mjs checks that the tag, the version assertion and FACTORIO_VERSION agree, so preview:test (and the required verify check) should fail on this PR as it stands.

The PR body says what to do. Update the assertion and FACTORIO_VERSION in the same commit, then run pnpm run types:sync. Also update the 2.1.23 refresh-command comments at lines 9 and 16-17.

CLAUDE.md, "Preview service" section: "dockerfile.test.mjs ... asserts ... the tag agrees with the version assertion below it".

@renovate
renovate Bot force-pushed the renovate/factoriotools-factorio-2.x branch from d577170 to a4f2c72 Compare November 2, 2026 12:56
Comment thread preview-service/container/Dockerfile Outdated
# docker pull --platform linux/amd64 factoriotools/factorio:2.1.23
# docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23
FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f
FROM factoriotools/factorio:2.1.24@sha256:fb83f98b901688d101e2f12d9a2109b085b216790012324f04320cdc01a069d4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag bump is incomplete, so the container tests will fail.

The FROM now pins 2.1.24, but the rest of the repo still says 2.1.23:

  • preview-service/container/Dockerfile:27 still has RUN ... factorio --version | grep -q "Version: 2.1.23". The image build would fail on it.
  • preview-service/worker/wrangler.jsonc:23 still has "FACTORIO_VERSION": "2.1.23".
  • The comments at lines 9 and 16-17 still name 2.1.23.

The PR body says a tag change needs the assertion and FACTORIO_VERSION updated in the same commit, followed by pnpm run types:sync. It also says dockerfile.test.mjs fails if the three disagree. This PR changes only the FROM line.

Please update all of them together, rerun types:sync, and run the test:integration image build. Alternatively, close this PR and hold at 2.1.23 until the move is deliberate. See the Preview service section of CLAUDE.md.

@renovate
renovate Bot force-pushed the renovate/factoriotools-factorio-2.x branch from a4f2c72 to e46428f Compare November 6, 2026 04:05
# docker pull --platform linux/amd64 factoriotools/factorio:2.1.23
# docker inspect --format='{{index .RepoDigests 0}}' factoriotools/factorio:2.1.23
FROM factoriotools/factorio:2.1.23@sha256:1e1773337f5be1d93f61d1d64757f18c19c8eb345c96acc57e0d3567a4fd4c3f
FROM factoriotools/factorio:2.1.24@sha256:a0c019b7608975a58f1694de54a2326e13a5aa2d123c18f48e5396181e366e28

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the tag to 2.1.24, but the other places that name the version still say 2.1.23:

  • preview-service/container/Dockerfile:27 still has RUN ... factorio --version | grep -q "Version: 2.1.23". The image build would fail at that step against a 2.1.24 base.
  • FACTORIO_VERSION in preview-service/worker/wrangler.jsonc:23 is still "2.1.23". That value is part of the render cache key.
  • The refresh-command comments on lines 16-17 still name 2.1.23.

dockerfile.test.mjs asserts that the FROM tag, the --version assertion and FACTORIO_VERSION agree, so preview:test and the required verify check should fail on this commit. The PR body lists the same steps (update the assertion and FACTORIO_VERSION, run pnpm run types:sync) as required before merging a tag change; see CLAUDE.md, "Preview service".

Please update all three in this PR, run pnpm run types:sync, and run pnpm --filter @fmw/preview-container run test:integration to build the image.

@renovate
renovate Bot force-pushed the renovate/factoriotools-factorio-2.x branch from fd7ef52 to 989ef6b Compare November 8, 2026 20:30
Renovate moved only the FROM line. The build-time `--version` assertion,
the refresh comments and the worker's FACTORIO_VERSION must move with it,
which test/dockerfile.test.mjs checks. Worker types regenerated with
`pnpm run types:sync` for the new var value. The registry check in that
test confirms the pinned digest is a Factorio 2.1.24 image.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Kd6o1aFcJ4CmpGhDgPionn
@renovate

renovate Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@wormeyman
wormeyman merged commit 875cea3 into main Nov 8, 2026
16 checks passed
@wormeyman
wormeyman deleted the renovate/factoriotools-factorio-2.x branch November 8, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant