This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Bump minimatch to 3.1.5 to address ReDoS advisories - #52
Merged
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
@MelvinBot merged main |
grgia
approved these changes
Oct 26, 2026
grgia
left a comment
There was a problem hiding this comment.
Dev-only, it's under eslint and the babel build tooling, nothing in the shipped code uses it. Lint, typecheck and build pass on the branch. No QA needed.
|
recheck |
melvin-bot
Bot
requested review from
chiragsalian
and removed request for
a team
October 26, 2026 16:34
chiragsalian
approved these changes
Oct 26, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Bumps transitive
minimatch3.1.2 → 3.1.5 (lockfile only) to fix GHSA-3ppc-4f35-3m26, GHSA-7r86-cg39-jmmj, GHSA-23c5-xmqv-rm74 (ReDoS).Usage: Dev tooling only, never imported by
srcor shipped indist. Pulled in byeslintand its plugins (config/file globbing),@babel/cli→glob(build file matching), andreact-native→jscodeshift→node-dir.Change Log
*characters**, improve perfRelated Issues
$ https://github.com/Expensify/Expensify/issues/695897
Manual Tests
Steps I ran on the branch:
npm ci, thennpm ls minimatch --allshows only 3.1.5.npm run lint,npm run ts,npm run buildpass.No QA, dev-only dependency.
Linked PRs