Skip to content

Bump @playwright/test to 1.64.1 - #813

Closed
MelvinBot wants to merge 3 commits into
mainfrom
claude-bumpPlaywright
Closed

MelvinBot wants to merge 3 commits into
mainfrom
claude-bumpPlaywright

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Details

Bumps @playwright/test ^1.43.1 → ^1.64.1 (playwright/playwright-core 1.51.1 → 1.64.1) to fix GHSA-7mvr-c777-76hp (browser downloads skipped SSL cert checks; patched in 1.55.1).

Usage: Dev-only. Runs the web E2E tests in WebExample/__tests__ (npm run test) against the Expo web example, in CI via web-e2e-test.yml. Not shipped in the library.

Lockfile was updated by hand (npm ci validated; all three packages resolve to 1.64.1). No listed breaking changes affect our tests (they use page.click/evaluate/goto/waitForTimeout).

Change Log
  • 1.52: toContainClass(), failOnFlakyTests; glob ?/[] dropped in page.route.
  • 1.53: Trace Viewer/HTML reporter steps, locator.describe().
  • 1.54: cookie.partitionKey, --user-data-dir CLI; Node 16 dropped.
  • 1.55 / 1.55.1: testStepInfo.titlePath; Chromium MV2 extensions dropped; SSL fix for browser downloads.
  • 1.56: Playwright Agents; backgroundpage deprecated.
  • 1.57: Chrome for Testing builds; wait for webServer output; page.accessibility removed.
  • 1.58: UI Mode/Trace Viewer timeline; _react/_vue selectors and devtools launch option removed.
  • 1.59: Screencast API, await using; WebKit macOS 14 dropped.
  • 1.60: HAR on tracing, test.abort(); deprecated APIs removed (videosPath, etc.).
  • 1.61: WebAuthn passkeys, Web Storage APIs.
  • 1.62: AbortSignal, WebP screenshots, isolated retries.
  • 1.63: Test locks, cross-frame and visible-only locators.
  • 1.64 / 1.64.1: locator.within(), better videos; device screen now emulated; Node ≥20 required (repo uses 24).

Related Issues

$ https://github.com/Expensify/Expensify/issues/695659

Manual Tests

  1. npm ci at repo root.
  2. npx playwright --version → 1.64.1.
  3. npx playwright install --with-deps succeeds.
  4. cd WebExample && npm run test → all specs pass on Chromium, Firefox, WebKit.
  5. Confirm the Test web E2E CI check passes on this PR.

Linked PRs

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@arosiclair

Copy link
Copy Markdown

@MelvinBot why is Test web E2E / test failing here?

@arosiclair

Copy link
Copy Markdown

I have read the CLA Document and I hereby sign the CLA

exfy-clabot Bot added a commit to Expensify/CLA that referenced this pull request Oct 28, 2026
@jmusial

jmusial commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Hey @arosiclair I took @ look on why this is failing - this bump moves playwright to use newer browsers (Chromium 156, Firefox 157, WebKit 27). They interpret styles differently and that broke E2E tests.

But this also showed 1 real bug on Firefox 157, so I'd suggest fixing the bug first in a separate PR, then bumping the playwright. I have fixes ready I can do it if you're ok with it ?

The bug:

firefox-157-codeblock-bug.mp4

@arosiclair

Copy link
Copy Markdown

Thanks for taking a look! That plan sounds good to me. I assigned you to the issue as well

@jmusial

jmusial commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

resolved via #820

@jmusial

jmusial commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@arosiclair can I close this one ?

@arosiclair

Copy link
Copy Markdown

Oh I see we did the bump in the other PR. Closing this

@arosiclair arosiclair closed this Nov 4, 2026
@jmusial

jmusial commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Oh I see we did the bump in the other PR. Closing this

yeah I wanted them separate but turns out old playright wasn't working on CI's ubuntu so had to do them together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants