Repository navigation
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
@MelvinBot why is |
…n into claude-bumpPlaywright
|
I have read the CLA Document and I hereby sign the CLA |
|
Hey @arosiclair I took @ look on why this is failing - this bump moves playwright to use newer browsers (Chromium 156, Firefox 157, WebKit 27). They interpret styles differently and that broke E2E tests. But this also showed 1 real bug on Firefox 157, so I'd suggest fixing the bug first in a separate PR, then bumping the playwright. I have fixes ready I can do it if you're ok with it ? The bug: firefox-157-codeblock-bug.mp4 |
|
Thanks for taking a look! That plan sounds good to me. I assigned you to the issue as well |
|
resolved via #820 |
…n into claude-bumpPlaywright
|
@arosiclair can I close this one ? |
|
Oh I see we did the bump in the other PR. Closing this |
yeah I wanted them separate but turns out old playright wasn't working on CI's ubuntu so had to do them together |
Details
Bumps
@playwright/test^1.43.1→^1.64.1(playwright/playwright-core1.51.1 → 1.64.1) to fix GHSA-7mvr-c777-76hp (browser downloads skipped SSL cert checks; patched in 1.55.1).Usage: Dev-only. Runs the web E2E tests in
WebExample/__tests__(npm run test) against the Expo web example, in CI viaweb-e2e-test.yml. Not shipped in the library.Lockfile was updated by hand (
npm civalidated; all three packages resolve to 1.64.1). No listed breaking changes affect our tests (they usepage.click/evaluate/goto/waitForTimeout).Change Log
toContainClass(),failOnFlakyTests; glob?/[]dropped inpage.route.locator.describe().cookie.partitionKey,--user-data-dirCLI; Node 16 dropped.testStepInfo.titlePath; Chromium MV2 extensions dropped; SSL fix for browser downloads.backgroundpagedeprecated.page.accessibilityremoved._react/_vueselectors anddevtoolslaunch option removed.await using; WebKit macOS 14 dropped.test.abort(); deprecated APIs removed (videosPath, etc.).locator.within(), better videos; devicescreennow emulated; Node ≥20 required (repo uses 24).Related Issues
$ https://github.com/Expensify/Expensify/issues/695659
Manual Tests
npm ciat repo root.npx playwright --version→1.64.1.npx playwright install --with-depssucceeds.cd WebExample && npm run test→ all specs pass on Chromium, Firefox, WebKit.Test web E2ECI check passes on this PR.Linked PRs