From 72419cc037643a1c14efacf987498ed59803ffbe Mon Sep 17 00:00:00 2001 From: Krishna Chaitanya Date: Thu, 22 Oct 2026 08:17:39 +0530 Subject: [PATCH] Fix typecheck on main Top-level attendees is no longer a Search row field, so it is dropped from the row-only field list. Exact Online is only a waitlist listing with no Connections entry, so the settlement page test leaves it out of the connections it iterates. --- src/libs/getTransactionFromTransactionListItem.ts | 1 - tests/ui/DynamicWorkspaceSettlementAccountPageTest.tsx | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libs/getTransactionFromTransactionListItem.ts b/src/libs/getTransactionFromTransactionListItem.ts index 22b4b1da7aaa..7be736d4dfa2 100644 --- a/src/libs/getTransactionFromTransactionListItem.ts +++ b/src/libs/getTransactionFromTransactionListItem.ts @@ -63,7 +63,6 @@ const SEARCH_TRANSACTION_ROW_ONLY_FIELDS: Record { {connection: undefined, enabled: true, active: true, visible: false}, {connection: CONST.POLICY.CONNECTIONS.NAME.QBO, enabled: false, active: true, visible: false}, {connection: CONST.POLICY.CONNECTIONS.NAME.QBO, enabled: true, active: false, visible: false}, - ...Object.values(CONST.POLICY.CONNECTIONS.NAME).map((connection) => ({connection, enabled: true, active: true, visible: !!getRouteParamForConnection(connection)})), + // Exact Online is only listed for its waitlist, so it is not a connection a policy can reconcile against. + ...Object.values(CONST.POLICY.CONNECTIONS.NAME) + .filter((connection): connection is PolicyConnectionName => connection !== CONST.POLICY.CONNECTIONS.NAME.EXACT_ONLINE) + .map((connection) => ({connection, enabled: true, active: true, visible: !!getRouteParamForConnection(connection)})), ] satisfies Array<{connection: PolicyConnectionName | undefined; enabled: boolean; active: boolean; visible: boolean}>)( 'preserves reconciliation link visibility for $connection, enabled=$enabled, active=$active', async ({connection, enabled, active, visible}) => {