[MelvinBot]

Explanation of Change

Users with phone numbers in newer US area codes, such as 983 (Colorado), can't save them in Wallet or Profile > Personal details. The App rejects the number in the browser before sending any request.

Why: awesome-phonenumber 5.4.0 bundles libphonenumber 8.13.9 (April 2023). Its metadata doesn't include 983, so parsePhoneNumber returns possible: false. Both isValidPhoneNumber and isValidUSPhone depend on possible.

What this PR changes:

• Upgrades awesome-phonenumber from ^5.4.0 to exactly 6.11.0, which bundles libphonenumber 8.13.43. The 983 exchanges first validate in 8.13.30.
• Adds an npm override so expensify-common uses the same copy. Without it, npm installs a nested 5.4.0 for expensify-common, so Str.isValidPhoneNumber keeps the old metadata and doesn't get the worklet patch.
• Ports the existing worklet patch to 6.11.0. Only the ESM hunk offset and file hashes changed. git apply applies it cleanly to a fresh 6.11.0 install.
• Adds unit tests for a 983 number and for an invalid US number.

Why the version is pinned to 6.11.0: 6.11.1 reverted upstream's change that marks invalid numbers as possible: false (grantila/awesome-phonenumber#103). On 6.11.1 and later, possible checks only length, so +11234567890 would pass isValidPhoneNumber. 6.11.0 is the newest release that keeps today's strict behavior. A caret range would let a future lockfile update pick 6.12.0, so the version is exact.

Results from Jest, comparing the current version with this PR:

Input	5.4.0 (main)	6.11.0 (this PR)
+19833330123	rejected	accepted
+1-(983)-333-0123	rejected	accepted
+12018675309	accepted	accepted
+11234567890 (invalid area code)	rejected	rejected
+115005550009 (App's custom rule)	rejected	rejected

AI Tests

The runner had Node 24.19.0, not the required 26.5.0, and Bun's postinstall couldn't run.

• Passed: Jest PhoneNumberTest, LoginUtilsTest, LocalePhoneNumberTest, useHasPhoneNumberTest, and useWalletPhoneMagicCodeTest (68 tests). A temporary Jest test produced the table above on 5.4.0 and 6.11.0 by calling isValidPhoneNumber, isValidUSPhone, and the raw library.
• Passed: npm run spell-changed, scripts/validatePatches.sh checks (the patch is referenced in details.md), and git apply of the ported patch against a clean 6.11.0 install.
• Couldn't load on this runner: ValidationUtilsTest, UserUtilsTest, PersonalDetailsUtilsTest, OptionsListUtilsTest, and SuggestionMentionTest. Each fails with Must use import to load ES Module: @react-navigation/core because of Node 24, before any test runs. CI on Node 26 will run them, including the new tests.
• Not run (needs Bun): npm run lint, npm run typecheck, oxfmt, and scripts/applyPatches.ts.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/689351
PROPOSAL: N/A

Tests

Automated tests

Covered by added/updated automated tests

Manual tests

1. Open Personal information under profile settings.
2. Complete the other required fields with valid test data of US address.
3. In the phone field, enter 9833330123.
4. Press Save, and verify/confirm the form advances without a phone-number validation error.
5. Repeat steps 2–3 with +19833330123 and +1-(983)-333-0123; verify both formats are accepted.
6. Repeat steps 2–3 with +11234567890; verify an invalid-phone-number error blocks progress.

Upgrade.number.test.mp4

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as manual test steps above.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Upgrade.number.test.mp4

[MelvinBot]

I fixed the verify check and pushed the fix in 9148552. The ESLint check failure is unrelated to this PR.

• verify: The upgrade changed the bundled awesome-phonenumber code in isDeployChecklistLocked/index.js and proposalPoliceComment/index.js. I ran npm run gh-actions-build and committed the rebuilt bundles. They match the output CI expected.
• ESLint check: It reports an unused max-lines directive in src/libs/Navigation/types.ts. This PR does not touch that file. The same error fails lint on many other branches today. [No QA] Split SettingsNavigatorParamList out of Navigation/types.ts to fix max-lines lint fixes it on main. Merge main after that PR lands.

Check independent approval needs a reviewer approval. Code changes can't fix it.

[MelvinBot]

I merged main into this branch in 6829ec3 to fix the ESLint check failure.

• ESLint check: The max-lines error in src/libs/Navigation/types.ts came from main. [No QA] Split SettingsNavigatorParamList out of Navigation/types.ts to fix max-lines lint fixed it on main. The previous ESLint run started before that fix merged, so it tested the old code. ESLint now passes on that file locally.
• verify: It now passes after the rebuilt action bundles from my last commit.
• Check independent approval: This check passes only after a reviewer approves the PR.

[melvin-bot]

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-20T08:16:03.969267Z	34ee787	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[melvin-bot]

@daledah @inimaga One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104372.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a36e60d-193220d-40349267df9e187c5fd0e05c5ecec8fbfb06f085/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a36e60d-193220d-85e903944d82cbf5fa6c09eba0ad25c4f02b824d/index.html

Web 🕸️
https://104372.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[inimaga]

Bump @Ollyws

[Ollyws]

@inimaga In the phone field, enter 9833330123. this only works if countryCode is set to the US (1) in Onyx otherwise the form will throw an error unless there's a country code prepended, perhaps we should update this step

[inimaga]

@Ollyws I've updated the steps to specify using a US address.

[Ollyws]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: HybridApp

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

[Ollyws]

LGTM.

[Ollyws]

I've updated the steps to specify using a US address.

I think ONYXKEYS.COUNTRY_CODE is set by the backend based on IP. It's not hugely important but the step might confuse the QA team as it won't work without the +1 if they have an IP outside the US.

[melvin-bot]

🎯 @Ollyws, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/689351.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

[melvin-bot]

@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]