Skip to content

Canonical EC signature check against r value in the signature might be unnecessary. #238

Description

@islamaminBitGo

bool public_key::is_canonical( const compact_signature& c ) {

For canonical signature checks most standard ec libraries only enforce a low_s however the code referenced in this issue is enforcing a low_r (r being less than half of the curve order) as well. I'm wondering why that check is needed? Checking low_s should be enough to protect against signature malleability.

A clarification on why a low_r is being checked would be greatly appreciated, and if there is no need for it can that check be removed?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions