diff --git a/CHANGELOG.md b/CHANGELOG.md index 24198c8..b0443ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- Align GitHub updater `tested` metadata with plugin header and `readme.txt` (7.1). + ### Fixed - Load the `rank-math-api-manager` textdomain on `init` and read plugin headers without early translation, fixing the WordPress 6.7+ `_load_textdomain_just_in_time` notice (GitHub Issue #5). diff --git a/build-result.md b/build-result.md index 3a17853..278fc31 100644 --- a/build-result.md +++ b/build-result.md @@ -1,40 +1,34 @@ # Build Result ## Task -Ignore live `.mat.env` / `.env*` credential files in `.gitignore` and `.cursorignore` while keeping samples tracked. +v1.0.9.2 verification reconcile — PHPCS hygiene and updater `tested` metadata alignment. ## Status PASS ## Changes Made -- `.gitignore`: Broadened Environment files to `.env`, `.env.*`, `.mat.env`, `.mat.env.local`, `.mat.env.*`; added sample negations `!.mat.env.sample` / `!**/.mat.env.sample` (kept `!.env.sample` / `!**/.env.sample`). -- `.cursorignore`: Mirrored live-env ignores (`.mat.env`, `.mat.env.*`) plus sample negations alongside existing `.env` / `.env.*` rules. -- `docs/current-plan.md`: In-plan checklist markers advanced through Steps 1–5; stripped header trailing whitespace that failed artifact validation. +- `tests/integration/TextdomainLoadingTest.php`: Capitalized PHPCS docblock short descriptions (lines 35, 86). +- `rank-math-api-manager.php`: Set updater response `tested` to `7.1` in `check_for_update()` and `plugin_info()` to match plugin header and `readme.txt`. +- `CHANGELOG.md`: Documented updater `tested` alignment under `[Unreleased]`. +- `docs/architecture/long-run-state.md`: Mission state for v1.0.9.2 verification closeout. +- `docs/current-plan.md`: Active slice plan and acceptance criteria. ## Acceptance Criteria -- AC-1: PASS — `git check-ignore -v .mat.env` → `.gitignore:53:.mat.env`; `.mat.env.sample` tracked (`git ls-files`) and not ignored (`check-ignore` exit 1). -- AC-2: PASS — `.cursorignore` lists `.mat.env` / `.mat.env.*` with `!.mat.env.sample` / `!**/.mat.env.sample` (and `.env` / `.env.*` + sample negations). -- AC-3: PASS — Matching ignore rule for `.mat.env`; `git ls-files --error-unmatch .mat.env` fails (not in index); no `git rm --cached` needed; local file left on disk. -- AC-4: PASS — `bash scripts/doctor.sh` exit 0. `bash scripts/phase1-verify.sh` still exits non-zero solely on out-of-scope pre-existing artifacts (`verify-result.md` stale Issue #5 AC-5 triad; `docs/architecture/long-run-state.md` mission-level `execution_mode` / `Last updated` format). No ignore-related phase1 failures; ignore proofs + doctor green for this slice. +- [x] AC-1: PASS — `vendor/bin/phpcs --standard=phpcs.xml.dist` exit 0. +- [x] AC-2: PASS — `./scripts/run-phpunit-local.sh` exit 0 (9 tests, 1 skip WooCommerce). +- [x] AC-3: PASS — `grep tested rank-math-api-manager.php` shows `7.1` in updater arrays. +- [x] AC-4: PASS — Icons, page in `get_allowed_post_types()`, `qa.yml`, `scripts/package-plugin.sh`, integration tests, and `v1.0.9.2` GitHub release verified on `main` before this slice. ## Linting / Type-Check PASS -Ignore/config hygiene only — no PHP/TS changes. Evidence: `git check-ignore -v .mat.env`, `git ls-files .mat.env.sample`, `bash scripts/doctor.sh` (PASS). +`vendor/bin/phpcs --standard=phpcs.xml.dist` — no violations reported. ## Issues / Blockers -None for this slice. Residual phase1 noise is parent-owned (`verify-result.md` rewrite after verify) / long-run-state format (orchestrator), not caused by ignore edits. +None ## Notes for Verifier -- Proof commands: `git check-ignore -v .mat.env`; `git check-ignore -v .mat.env.sample` (expect non-zero / no rule); `git ls-files --stage -- .mat.env .mat.env.sample .env.sample`. -- Local `.mat.env` remains on disk and untracked; do not delete it. -- Stale root `verify-result.md` still describes Issue #5 (AC-1…AC-5); parent should replace it after this verify pass. -- `CURSOR_MAT_LOOP_POLICY=1` via `.mat.env` → Loop Iteration Log included below. +- Product v1.0.9.2 features were already merged (PR #4) and released; this PR is hygiene only. +- Do not expect version bump beyond 1.0.9.2 unless operator requests a patch release for `tested` metadata. ## Closeout (2026-11-05) -env-secrets-ignore ignore surfaces updated and proven; doctor green; ready for parent-owned verify / PR #6 push. - -## Loop Iteration Log - -| iter | action | failure_class | fingerprint | note | -|------|--------|---------------|-------------|------| -| 1 | continue | none | env-ignore-v1 | Initial ignore edits + doctor PASS; phase1 residual is out-of-scope stale verify/long-run format only | +Local PHPCS, PHPUnit, and package script green after two-line test doc fixes and updater metadata alignment. diff --git a/docs/architecture/long-run-state.md b/docs/architecture/long-run-state.md index a10491d..47ceaee 100644 --- a/docs/architecture/long-run-state.md +++ b/docs/architecture/long-run-state.md @@ -1,4 +1,4 @@ -# Long-run mission state — MAT env ignore + upstream SHA pin issue +# Long-run mission state — v1.0.9.2 verification closeout **Last updated:** 2026-11-05 @@ -6,64 +6,61 @@ ## Mission -- **Goal:** (1) Stop tracking/indexing live env credential files (`.mat.env` and `.env*` live variants) so PR #6 can merge green; (2) file an upstream MAT issue so approve/bootstrap pins to the planned `resolved_sha` (operator re-syncs later — no local `mat-sync.sh` fork). +- **Goal:** Execute the approved v1.0.9.2 upgrade plan (icons, page support, CI/QA, packaging alignment, verification docs). Re-verify against `main` before changing product code; land only gaps found during verification. - **execution_mode:** `long-run` -- **Success signals:** `.mat.env` ignored by git + Cursor; doctor/phase1 green for the slice; PR #6 CI green and merged; upstream GitHub issue created in `Devora-AS/multi-agent-workflow`. -- **Notes:** Parent-orchestrated in this chat; no nested parent-orchestrator subagent. +- **Success signals:** All plan acceptance criteria evidenced on branch; local QA green; GitHub QA workflow green on PR; honest mission gate when product work was already shipped as `v1.0.9.2`. +- **Notes:** Parent-orchestrated in this chat (no nested `parent-orchestrator` subagent). Product features and release tag `v1.0.9.2` already exist on `main`; this run focuses on reconciliation, PHPCS hygiene, and MAT artifact closeout. ## Scope / hard constraints / non-goals -- **Hard constraints:** Keep local `.mat.env` on disk; never commit secrets; no force-push; do not implement `resolved_sha` pin in this product repo — issue only upstream. -- **Non-goals:** Local patch to `scripts/mat-sync.sh` for SHA pinning; broad cleanup of unrelated dirty trees; v1.0.9.2 packaging tasks. +- **Hard constraints:** No force-push; no secrets in git; do not re-release `v1.0.9.2` without operator GO; preserve GitHub-only updater behavior. +- **Non-goals:** Re-implementing icons/pages/CI from scratch; TASK-005 main-file PHPCS baseline; unrelated MAT env-ignore work. ## Slice preflight decision (active) -- **execution_mode:** `inline` -- **execution_rationale:** Mission complete — no active implementation slice. +- **execution_mode:** `builder_plus_verifier` +- **execution_rationale:** Small PHPCS fix plus documentation/MAT state updates; builder implements, verifier read-only checks. ## Ordered slice queue -| # | Slice id | Summary | execution_mode | execution_rationale | Status | -|---|----------|---------|----------------|---------------------|--------| -| 1 | `env-secrets-ignore` | Ignore live `.mat.env` / `.env*` in `.gitignore` + `.cursorignore`; doctor + phase1; PR #6 CI + merge | `builder_plus_verifier` | Config + CI closeout | `done` | -| 2 | `upstream-resolved-sha-issue` | Create GitHub issue in `Devora-AS/multi-agent-workflow` | `inline` | Single `gh issue create` | `done` | +| # | Slice id | Summary | execution_mode | Status | +|---|----------|---------|----------------|--------| +| 1 | `v1092-verify-reconcile` | Re-verify plan vs tree; fix PHPCS in `TextdomainLoadingTest`; align updater `tested` with readme `7.1` if drift | `builder_plus_verifier` | `done` | +| 2 | `v1092-mat-closeout` | Update `docs/current-plan.md`, session summary, serialize verify/build handoffs | `inline` | `done` | ## Active slice -- **Slice id:** _(none — mission complete)_ -- **Pointer:** `docs/session-summary.md` +- **Slice id:** `v1092-verify-reconcile` +- **Pointer:** `docs/current-plan.md` ## Completed slices -| Slice id | Outcome | `verify-result.md` reference | Notes | -|----------|---------|------------------------------|-------| -| `env-secrets-ignore` | PASS | `verify-result.md` (PR #6 era) | Merged via #6 squash `61ee90d` | -| `upstream-resolved-sha-issue` | PASS | n/a (inline) | https://github.com/Devora-AS/multi-agent-workflow/issues/10 | +| Slice id | Outcome | Notes | +|----------|---------|-------| +| _(product v1.0.9.2)_ | Shipped on `main` | Tag `v1.0.9.2`, PR #4 merged 2026-06-24 | ## Continuation policy -- Mission complete; no further slices queued. +- After slice 1 PASS and PR merge (if code changes), run slice 2 MAT closeout and classify `mission_complete`. ## Stop-reason policy | Stop reason | Meaning | |-------------|---------| -| `mission_complete` | Both slices done (PR #6 merged + upstream issue filed). | -| `hard_blocker` | Cannot ignore files, CI blocked, or `gh` cannot open upstream issue. | -| `approval_needed` | Design conflict beyond approved GO. | -| `planning_gap` | Queue empty with work remaining. | +| `mission_complete` | Verification done; gaps fixed or documented; PR merged when required. | +| `hard_blocker` | CI/env cannot run; tests fail without root cause. | +| `approval_needed` | New release or scope beyond verification. | +| `planning_gap` | — | | `unexpected_termination` | Abnormal end. | --- ## Parent mission gate compliance (per verifier PASS) -- [x] Gate questions answered or one explicit stop reason recorded. -- [x] Slice PASS is not mislabeled as mission success while slice 2 remains. - ---- +- [ ] Gate questions answered or one explicit stop reason recorded. +- [ ] Slice PASS is not mislabeled as mission success while slice 2 remains. ## Current stop / continuation (living) -- **Last classified stop reason:** `mission_complete` -- **Continue:** `no` +- **Last classified stop reason:** _(in progress)_ +- **Continue:** `yes` — slice 1 active diff --git a/docs/current-plan.md b/docs/current-plan.md index 496fc61..f39a058 100644 --- a/docs/current-plan.md +++ b/docs/current-plan.md @@ -1,71 +1,54 @@ -# Current plan — Ignore live MAT/env secrets (PR #6 Codex finding 1) +# Current plan — v1.0.9.2 verification reconcile (slice 1) -**Status:** Active orchestration slice -**Tier:** standard (execution projection) -**Contract:** v0.1 — [`.mat/docs/plan-contract.md`](../.mat/docs/plan-contract.md) -**Preflight:** `builder_plus_verifier` -**Last updated:** 2026-11-05 -**Branch:** `chore/mat-env-secrets-ignore` -**Mission:** `docs/architecture/long-run-state.md` slice `env-secrets-ignore` -**PR target:** Update https://github.com/Devora-AS/rank-math-api-manager/pull/6 then merge when green +**Status:** Active orchestration slice +**Tier:** standard (execution projection) +**Contract:** v0.1 — [`.mat/docs/plan-contract.md`](../.mat/docs/plan-contract.md) +**Preflight:** `builder_plus_verifier` +**Last updated:** 2026-11-05 +**Branch:** `chore/v1.0.9.2-mat-verification-closeout` +**Mission:** `docs/architecture/long-run-state.md` slice `v1092-verify-reconcile` --- ## Task -Make live environment credential files untracked and unindexed: add `.mat.env` (and related live `.env*` / `.mat.env*` variants) to root `.gitignore` and `.cursorignore`, keep samples (`.mat.env.sample`, `.env.sample`) tracked/visible, confirm with `git check-ignore -v .mat.env`, remove from index with `git rm --cached` only if ever tracked (do **not** delete the local file), then re-run `bash scripts/doctor.sh` and `bash scripts/phase1-verify.sh`. Parent owns push to PR #6 head, CI loop, and merge. +Re-verify the approved v1.0.9.2 plan against `main`. Product scope (icons, pages, QA workflow, packaging script, integration tests, verification matrix) is **already shipped** at tag `v1.0.9.2`. This slice lands only verified gaps: -## Verified root cause (re-checked) - -- `.mat.env.sample` line 2 claims `.mat.env` is gitignored. -- Root `.gitignore` lists several `.env*` names but **not** `.mat.env` / `.mat.env.local`. -- Root `.cursorignore` has `.env` and `.env.*` (with `!.env.sample`) but **not** `.mat.env` (filename does not match `.env.*`). -- `git ls-files` / history: `.mat.env` was **never** committed on this branch; local `?? .mat.env` is expected until ignore rules land. -- PR #6 prior Plugin Check failure (`outdated_tested_upto_header` 7.0 < 7.1) and early textdomain notice are addressed by already-merged `main` (Issue #5 / PR #7); this branch already contains `merge(main)` at `3c1b540`. - -## Non-goals - -- Implementing `resolved_sha` pin in `scripts/mat-sync.sh` (slice 2 = upstream issue only) -- Deleting or rewriting local `.mat.env` contents -- Broad `/cleanup` purge of unrelated artifacts -- Changing WordPress plugin PHP beyond what `main` already provides for CI +1. PHPCS doc-comment capitalization in `tests/integration/TextdomainLoadingTest.php` (local `vendor/bin/phpcs` currently fails). +2. Align GitHub updater `tested` metadata with plugin header / `readme.txt` (`7.1`, not `6.9.3`). ## Context | Anchor | Role | |--------|------| -| PR #6 Codex review | Finding 1 — unignored `.mat.env` | -| `.gitignore` / `.cursorignore` | Ignore surfaces | -| `.mat.env.sample` | Sample must remain tracked | -| `scripts/doctor.sh` / `scripts/phase1-verify.sh` | Validation | -| PR #6 | Merge target after green CI | +| Approved user plan | Icons, page, CI, packaging, docs | +| `main` @ `62029d8` | Contains 1.0.9.2 product code; release published | +| `scripts/run-phpunit-local.sh` | Local PHPUnit mirror of `qa.yml` | +| `.github/workflows/qa.yml` | Authoritative CI gate | ## Implementation steps -- [x] **Step 1 — Extend `.gitignore`** - - Under Environment files (and/or MAT section): ignore live `.mat.env`, `.mat.env.local`, and keep broad live env coverage (e.g. `.env`, `.env.*`, `.mat.env.*`) with negations so `.env.sample`, `.mat.env.sample`, and `**/.mat.env.sample` stay trackable. - -- [x] **Step 2 — Extend `.cursorignore`** - - Mirror live-env ignores for indexing: `.mat.env`, `.mat.env.*` (and existing `.env` / `.env.*`), with `!.env.sample` and `!.mat.env.sample` (and `!**/.mat.env.sample` if needed). +- [wip] **Step 1 — Fix PHPCS in textdomain integration test** + - Capitalize short descriptions on affected `@` docblocks in `tests/integration/TextdomainLoadingTest.php`. -- [x] **Step 3 — Index hygiene** - - If `git ls-files --error-unmatch .mat.env` succeeds: `git rm --cached .mat.env` (keep working tree file). - - Confirm: `git check-ignore -v .mat.env` prints a matching rule. +- [] **Step 2 — Align updater tested version** + - Set `'tested' => '7.1'` in `check_for_update()` and `plugin_info()` response arrays in `rank-math-api-manager.php`. -- [x] **Step 4 — Validation** - - `bash scripts/doctor.sh` +- [] **Step 3 — Validation** + - `vendor/bin/phpcs --standard=phpcs.xml.dist` + - `./scripts/run-phpunit-local.sh` + - `./scripts/package-plugin.sh` (confirm icons in ZIP) - `bash scripts/phase1-verify.sh` - - Low-risk slice-related `/update-docs` note only if README/CHANGELOG truly need a one-line hygiene mention; skip drive-by docs. -- [x] **Step 5 — Handoff** - - Write `build-result.md` per workflow artifact contract; mutate plan markers to `[x]`/`[f]` as appropriate. +- [] **Step 4 — Handoff** + - `build-result.md` per workflow artifact contract. -## Binary acceptance criteria (verifier) +## Acceptance criteria -- [x] **AC-1:** `.gitignore` ignores live `.mat.env` (and documented live variants) while `.mat.env.sample` remains tracked / not ignored. -- [x] **AC-2:** `.cursorignore` ignores live `.mat.env` (and documented live variants) while sample negations keep samples visible to indexing policy. -- [x] **AC-3:** `git check-ignore -v .mat.env` succeeds with an explicit matching rule; `.mat.env` is not in the git index. -- [x] **AC-4:** `bash scripts/doctor.sh` and `bash scripts/phase1-verify.sh` exit successfully (or doctor advisory-only warnings documented honestly without FAIL on this slice’s ignore changes). +- [] **AC-1:** PHPCS exits 0 on the repository standard (`phpcs.xml.dist`). +- [] **AC-2:** PHPUnit integration suite passes (WooCommerce skip allowed). +- [] **AC-3:** Updater `tested` fields match `7.1` in both update transient and plugin info paths. +- [] **AC-4:** Re-verification documents that icons, page support, QA workflow, and packaging script already satisfy the approved v1.0.9.2 plan on `main` (no duplicate feature work). ## Verification plan @@ -73,35 +56,21 @@ Make live environment credential files untracked and unindexed: add `.mat.env` ( | Phase | Command | Loop until pass | |-------|---------|-----------------| -| Ignore proof | `git check-ignore -v .mat.env` | Must print a rule; fix patterns until it does | -| Sample still trackable | `git check-ignore -v .mat.env.sample`; `git ls-files .mat.env.sample` | Sample must NOT be ignored; must remain tracked | -| Doctor | `bash scripts/doctor.sh` | Re-run until exit 0 or only documented advisories | -| Phase1 | `bash scripts/phase1-verify.sh` | Re-run until exit 0 | -| Optional local CI job | `gh act -j php-lint --container-architecture linux/amd64` (or repo job id) | Prefer before push if Docker healthy | +| PHPCS | `vendor/bin/phpcs --standard=phpcs.xml.dist` | Fix until exit 0 | +| PHPUnit | `./scripts/run-phpunit-local.sh` | Fix until exit 0 | +| Package | `./scripts/package-plugin.sh` && unzip -l rank-math-api-manager.zip \| grep icon | Icons present | +| Phase1 | `bash scripts/phase1-verify.sh` | Exit 0 | ### Global validation commands (before handoff) -1. `git check-ignore -v .mat.env` -2. `git ls-files --stage -- .mat.env .mat.env.sample .env.sample` -3. `bash scripts/doctor.sh` -4. `bash scripts/phase1-verify.sh` +1. `bash scripts/doctor.sh` +2. `bash scripts/phase1-verify.sh` +3. `gh act -j phpcs --container-architecture linux/amd64` (optional pre-push if Docker healthy) -## Expected output artifacts - -- `build-result.md` — builder handoff -- `verify-result.md` — parent-serialized after verifier payload -- Updated PR #6 (parent push + CI + merge) — post-verify closeout - -## Parent closeout (after verify PASS — not builder) +## Amendments -- [ ] Low-risk `/update-docs` + `/cleanup` for slice-related hygiene only -- [ ] Commit slice (no force-push) -- [ ] Push to update PR #6 (`chore/mat-sync-refresh` or retarget) -- [ ] `/loop-on-ci` until green -- [ ] Merge PR #6 when green -- [ ] Advance long-run queue to slice 2 +- 2026-11-05T10:05:00Z — orchestrator — Slice scoped to verification gaps after confirming v1.0.9.2 already released on GitHub. -## Amendments +## Recommended Next Command -- 2026-11-05T07:36:09Z — orchestrator — Initial execution plan for env-secrets-ignore; branch `chore/mat-env-secrets-ignore` from `chore/mat-sync-refresh` + merge(main) for Plugin Check; preflight `builder_plus_verifier`. -- 2026-11-05T08:02:37Z — orchestrator — Verifier PASS; parent re-proof + serialized verify-result.md; phase1 exit 0; proceeding to commit/push PR #6. +After build handoff: `/mat-review` (verifier) with `docs/current-plan.md` and `build-result.md`. diff --git a/docs/session-summary.md b/docs/session-summary.md index 20e5e8c..62d4f80 100644 --- a/docs/session-summary.md +++ b/docs/session-summary.md @@ -1,25 +1,30 @@ -# Session summary — MAT env ignore + upstream SHA issue +# Session summary — v1.0.9.2 MAT long-run verification **Date:** 2026-11-05 -**Stop reason:** `mission_complete` +**Branch:** `chore/v1.0.9.2-mat-verification-closeout` +**Stop reason:** `mission_complete` (after PR merge) -## Outcomes +## What happened -1. **Slice `env-secrets-ignore`:** Live `.mat.env` / `.env*` ignored in `.gitignore` and `.cursorignore`; samples stay tracked. Doctor + phase1 green. PR [#6](https://github.com/Devora-AS/rank-math-api-manager/pull/6) CI all green; squash-merged as `61ee90d`. -2. **Slice `upstream-resolved-sha-issue`:** Filed [Devora-AS/multi-agent-workflow#10](https://github.com/Devora-AS/multi-agent-workflow/issues/10) — *mat-sync: pin approve/bootstrap to plan resolved_sha*. No local `mat-sync.sh` fork. +The approved v1.0.9.2 plan (icons, pages, CI, packaging, verification docs) was **already implemented, tagged, and released** on `main` as `v1.0.9.2`. This MAT long-run session re-verified the tree and landed only reconciliation gaps: + +- PHPCS docblock capitalization in `TextdomainLoadingTest.php` +- GitHub updater `tested` metadata aligned to `7.1` +- MAT mission state and handoff artifacts updated ## Validation -- `git check-ignore -v .mat.env` → `.gitignore:53:.mat.env` -- Local `.mat.env` preserved (never indexed) -- QA: PHP Lint, PHPCS, PHPUnit, Plugin Check, Package smoke — all SUCCESS +- Local: PHPCS, PHPUnit (`run-phpunit-local.sh`), `phase1-verify.sh`, `doctor.sh` +- CI: QA workflow on PR (see PR link in chat closeout) ## Intentionally untouched -- Product PHP beyond what `main` already had for Issue #5 / Tested up to 7.1 -- Local implementation of `resolved_sha` pinning (await upstream, then operator re-sync) +- No version bump to 1.0.9.3 / no new GitHub release in this session unless operator requests +- TASK-005 main-file PHPCS baseline deferred +- Legacy agent worktrees under doctor output (informational only) -## Next (operator) +## Next recommended work (priority) -1. Fix and merge upstream #10 in MAT-tools. -2. Re-run mat-sync in this product repo when upstream ships the pin. +1. **Optional patch release 1.0.9.3** — ship updater `tested` + PHPCS test doc fix if operators want it on production update channels. +2. **TASK-005** — WPCS on `rank-math-api-manager.php` when ready for a dedicated hygiene slice. +3. **Upstream MAT issue #10** — `resolved_sha` pin (from prior mission); no product code. diff --git a/rank-math-api-manager.php b/rank-math-api-manager.php index df96081..ca06ac0 100644 --- a/rank-math-api-manager.php +++ b/rank-math-api-manager.php @@ -1586,7 +1586,7 @@ public function check_for_update( $transient ) { ), 'banners' => array(), 'banners_rtl' => array(), - 'tested' => '6.9.3', + 'tested' => '7.1', 'requires_php' => '7.4', ); @@ -1748,7 +1748,7 @@ public function plugin_info( $res, $action, $args ) { 'author' => '' . esc_html( isset( $this->plugin_data['AuthorName'] ) ? $this->plugin_data['AuthorName'] : 'Devora AS' ) . '', 'homepage' => isset( $this->plugin_data['PluginURI'] ) ? $this->plugin_data['PluginURI'] : '', 'requires' => '5.0', - 'tested' => '6.9.3', + 'tested' => '7.1', 'requires_php' => '7.4', 'last_updated' => $release_data['published_at'], 'download_link' => $release_data['download_url'], diff --git a/tests/integration/TextdomainLoadingTest.php b/tests/integration/TextdomainLoadingTest.php index a2f6b95..ac86cbb 100644 --- a/tests/integration/TextdomainLoadingTest.php +++ b/tests/integration/TextdomainLoadingTest.php @@ -32,7 +32,7 @@ class_exists( 'Rank_Math_API_Manager_Extended', false ), } /** - * init priority 0 must register load_textdomain on the plugin instance. + * Init priority 0 must register load_textdomain on the plugin instance. */ public function test_init_registers_load_textdomain_at_priority_zero() { $instance = $this->plugin_instance(); @@ -83,7 +83,7 @@ static function ( $function_name, $message ) use ( &$jit_notices ) { } /** - * load_textdomain callback registers the plugin languages path with WordPress. + * Load_textdomain callback registers the plugin languages path with WordPress. */ public function test_load_textdomain_callback_loads_domain_on_init() { global $wp_textdomain_registry; diff --git a/verify-result.md b/verify-result.md index 725e96e..c7c1eca 100644 --- a/verify-result.md +++ b/verify-result.md @@ -11,28 +11,28 @@ PASS ## Criteria Review -### Criterion 1: AC-1 — `.gitignore` ignores live `.mat.env` (and variants); `.mat.env.sample` remains tracked / not ignored -**Result:** PASS -**Evidence:** `.gitignore:51-55` live ignores; `.gitignore:120-123` sample negations. Parent re-ran `git check-ignore -v .mat.env` → `.gitignore:53:.mat.env`. `git check-ignore -v .mat.env.sample` exit 1 (not ignored). `git ls-files` lists `.mat.env.sample` and `.env.sample`. +### Criterion 1: PHPCS exits 0 on the repository standard +**Result:** PASS +**Evidence:** `tests/integration/TextdomainLoadingTest.php:35,86` — docblock short descriptions capitalized; orchestrator re-ran `vendor/bin/phpcs --standard=phpcs.xml.dist` with exit 0 after build. -### Criterion 2: AC-2 — `.cursorignore` ignores live `.mat.env` (and variants); sample negations keep samples visible -**Result:** PASS -**Evidence:** `.cursorignore:28-35` — `.env` / `.env.*` / `.mat.env` / `.mat.env.*` with `!.env.sample`, `!**/.env.sample`, `!.mat.env.sample`, `!**/.mat.env.sample`. +### Criterion 2: PHPUnit integration suite passes +**Result:** PASS +**Evidence:** `./scripts/run-phpunit-local.sh` — 9 tests, 54 assertions, 1 skipped (WooCommerce inactive); exit 0. -### Criterion 3: AC-3 — `git check-ignore -v .mat.env` matches; `.mat.env` not in index; local file kept -**Result:** PASS -**Evidence:** Parent: `git check-ignore -v .mat.env` → `.gitignore:53:.mat.env`. `git ls-files --stage -- .mat.env` empty (not in index). `test -f .mat.env` true. +### Criterion 3: Updater `tested` fields match `7.1` +**Result:** PASS +**Evidence:** `rank-math-api-manager.php` — `'tested' => '7.1'` in update transient object (~1589) and `plugin_info()` return (~1751); plugin header `Tested up to: 7.1` at line 14. -### Criterion 4: AC-4 — doctor / phase1 for ignore slice -**Result:** PASS -**Evidence:** Parent: `bash scripts/doctor.sh` exit 0. Fresh verify-result replaces Issue #5 triad; long-run-state mission `execution_mode` list line fixed. Ignore changes introduce no phase1 failures. +### Criterion 4: Re-verification that v1.0.9.2 plan already satisfied on main +**Result:** PASS +**Evidence:** `get_allowed_post_types()` includes `page` (line 210); `icons` arrays populated in updater (~1582–1586, ~1755–1759); `assets/images/icon-*` present; `.github/workflows/qa.yml` jobs for lint/PHPCS/Plugin Check/package/phpunit; `scripts/package-plugin.sh` used by CI; GitHub release `v1.0.9.2` asset `rank-math-api-manager.zip` exists. ## Issues Found -None for this slice. +None blocking this slice. ## Recommendations -- Push to update PR #6; loop CI; merge when green. -- Slice 2: file upstream `resolved_sha` issue (no local mat-sync fork). +- Ship updater `tested` alignment in a future patch release (e.g. 1.0.9.3) if operator wants live sites to see metadata without waiting for next feature release. +- Optional follow-up: TASK-005 — remove main file from PHPCS exclude list. ## Closeout (2026-11-05) -env-secrets-ignore verified PASS. Parent serialized this handoff after shell re-proof. +Verification slice PASS; product v1.0.9.2 scope was pre-shipped; branch adds hygiene only.