From 7dbc897dc6bfacc1be873eb38be98187069996e0 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Tue, 10 Nov 2026 11:23:05 +0000 Subject: [PATCH 1/2] fix: extract ExcursionReview save into isolated Writer component Extracted the `save` operation from `ExcursionReviewRepository` into a dedicated `ExcursionReviewWriter` component that uses `@Transactional(propagation = Propagation.REQUIRES_NEW)` and `saveAndFlush`. This correctly enforces transaction isolation and immediately triggers database constraint checks (like idempotency key violations), allowing the calling service to catch `DataIntegrityViolationException` rather than relying on an overridden repository method whose transaction settings were ignored by Spring AOP. Co-authored-by: huytran2005 <126896896+huytran2005@users.noreply.github.com> --- .../repository/ExcursionReviewRepository.java | 4 ---- .../service/ExcursionReviewService.java | 3 ++- .../service/ExcursionReviewWriter.java | 20 +++++++++++++++++++ .../ExcursionReviewAndAnalyticsTest.java | 16 +++++++++------ 4 files changed, 32 insertions(+), 11 deletions(-) create mode 100644 cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewWriter.java diff --git a/cruise-activity-service/src/main/java/com/cruise/activity/repository/ExcursionReviewRepository.java b/cruise-activity-service/src/main/java/com/cruise/activity/repository/ExcursionReviewRepository.java index ce3fcd31..95d93863 100644 --- a/cruise-activity-service/src/main/java/com/cruise/activity/repository/ExcursionReviewRepository.java +++ b/cruise-activity-service/src/main/java/com/cruise/activity/repository/ExcursionReviewRepository.java @@ -16,10 +16,6 @@ @Repository public interface ExcursionReviewRepository extends JpaRepository { - @Override - @Transactional(propagation = Propagation.REQUIRES_NEW) - S save(S entity); - Optional findByExcursionIdAndPassengerId(Long excursionId, Long passengerId); boolean existsByExcursionIdAndPassengerId(Long excursionId, Long passengerId); diff --git a/cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewService.java b/cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewService.java index 1e90d5d3..7e8b8e1c 100644 --- a/cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewService.java +++ b/cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewService.java @@ -36,6 +36,7 @@ public class ExcursionReviewService { ); private final ExcursionReviewRepository reviewRepository; + private final ExcursionReviewWriter reviewWriter; private final ShoreExcursionRepository excursionRepository; private final ExcursionPassengerRepository passengerRepository; @@ -84,7 +85,7 @@ public ExcursionReviewResponse submitReview(Long excursionId, ExcursionReviewReq .build(); try { - ExcursionReview saved = reviewRepository.save(review); + ExcursionReview saved = reviewWriter.saveReview(review); log.info("Excursion review submitted: excursionId={}, passengerId={}, overallRating={}, flagged={}", excursionId, request.passengerId(), request.ratingOverall(), isNegativeOrSafetyConcern); return mapToResponse(saved); diff --git a/cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewWriter.java b/cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewWriter.java new file mode 100644 index 00000000..14859eb6 --- /dev/null +++ b/cruise-activity-service/src/main/java/com/cruise/activity/service/ExcursionReviewWriter.java @@ -0,0 +1,20 @@ +package com.cruise.activity.service; + +import com.cruise.activity.entity.ExcursionReview; +import com.cruise.activity.repository.ExcursionReviewRepository; +import lombok.RequiredArgsConstructor; +import org.springframework.stereotype.Service; +import org.springframework.transaction.annotation.Propagation; +import org.springframework.transaction.annotation.Transactional; + +@Service +@RequiredArgsConstructor +public class ExcursionReviewWriter { + + private final ExcursionReviewRepository reviewRepository; + + @Transactional(propagation = Propagation.REQUIRES_NEW) + public ExcursionReview saveReview(ExcursionReview review) { + return reviewRepository.saveAndFlush(review); + } +} diff --git a/cruise-activity-service/src/test/java/com/cruise/activity/service/ExcursionReviewAndAnalyticsTest.java b/cruise-activity-service/src/test/java/com/cruise/activity/service/ExcursionReviewAndAnalyticsTest.java index c38e9a2c..15568584 100644 --- a/cruise-activity-service/src/test/java/com/cruise/activity/service/ExcursionReviewAndAnalyticsTest.java +++ b/cruise-activity-service/src/test/java/com/cruise/activity/service/ExcursionReviewAndAnalyticsTest.java @@ -51,6 +51,9 @@ class ExcursionReviewAndAnalyticsTest { @Mock private ExcursionReviewRepository reviewRepository; + @Mock + private ExcursionReviewWriter reviewWriter; + @Mock private ShoreExcursionRepository excursionRepository; @@ -76,6 +79,7 @@ class ExcursionReviewAndAnalyticsTest { @BeforeEach void setUp() { fleetAggregator = new FleetOccupancyAggregator(excursionRepository, vehicleRepository); + reviewService = new ExcursionReviewService(reviewRepository, reviewWriter, excursionRepository, passengerRepository); opsAnalyticsService = new ExcursionOpsAnalyticsService(excursionRepository, reviewRepository, guideRepository); mockExcursion = ShoreExcursion.builder() @@ -139,14 +143,14 @@ void submitReview_WhenAttended_ShouldSucceed() { .build(); saved.setId(99L); - when(reviewRepository.save(any(ExcursionReview.class))).thenReturn(saved); + when(reviewWriter.saveReview(any(ExcursionReview.class))).thenReturn(saved); ExcursionReviewResponse response = reviewService.submitReview(1L, req, "IDEM-1"); assertThat(response).isNotNull(); assertThat(response.ratingOverall()).isEqualTo(5); assertThat(response.isFlagged()).isFalse(); - verify(reviewRepository, times(1)).save(any(ExcursionReview.class)); + verify(reviewWriter, times(1)).saveReview(any(ExcursionReview.class)); } @Test @@ -161,7 +165,7 @@ void submitReview_WhenNotAttended_ShouldThrowAccessDenied() { .isInstanceOf(AccessDeniedException.class) .hasMessageContaining("ATTENDED"); - verify(reviewRepository, never()).save(any()); + verify(reviewWriter, never()).saveReview(any()); } @Test @@ -182,7 +186,7 @@ void submitReview_WhenOneStarOrDangerous_ShouldFlagReview() { .build(); saved.setId(100L); - when(reviewRepository.save(any(ExcursionReview.class))).thenReturn(saved); + when(reviewWriter.saveReview(any(ExcursionReview.class))).thenReturn(saved); ExcursionReviewResponse response = reviewService.submitReview(1L, req, null); @@ -208,7 +212,7 @@ void submitReview_IdempotentKey_ReturnsExisting() { ExcursionReviewResponse response = reviewService.submitReview(1L, req, "KEY-123"); assertThat(response.id()).isEqualTo(50L); - verify(reviewRepository, never()).save(any()); + verify(reviewWriter, never()).saveReview(any()); } @Test @@ -237,7 +241,7 @@ void submitReview_DataIntegrityViolation_Fallback() { when(excursionRepository.findById(1L)).thenReturn(Optional.of(mockExcursion)); when(passengerRepository.findByExcursionIdAndActiveTrue(1L)).thenReturn(List.of(attendedPassenger)); when(reviewRepository.existsByExcursionIdAndPassengerId(1L, 201L)).thenReturn(false); - when(reviewRepository.save(any())).thenThrow(new DataIntegrityViolationException("duplicate key")); + when(reviewWriter.saveReview(any())).thenThrow(new DataIntegrityViolationException("duplicate key")); ExcursionReview existing = ExcursionReview.builder() .excursionId(1L) From 80cc12f4bc3dbbefc24938229e69de293e28ed2e Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Tue, 10 Nov 2026 11:35:14 +0000 Subject: [PATCH 2/2] fix: update GitHub CI to use Java 21 LTS Updated `.github/workflows/ci.yml` to specify `java-version: '21'` instead of `25`. This resolves a CI failure caused by the non-LTS Java 25 version conflicting with the project's strict Java 21 LTS requirement and failing the SonarCloud analysis bootstrapping. Co-authored-by: huytran2005 <126896896+huytran2005@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 223be11d..e1629211 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: uses: actions/setup-java@v6 with: distribution: 'temurin' - java-version: '25' + java-version: '21' cache: 'maven' - name: Cache SonarCloud Packages