From 824584faa864bc71e06324a12b3968bec0ed8a91 Mon Sep 17 00:00:00 2001 From: oczoske Date: Thu, 22 Oct 2026 07:25:56 +0200 Subject: [PATCH] Flip Boolean and test IS factor decreases with more open ports --- scopesim/effects/metis_wcu/metis_wcu.py | 2 +- scopesim/tests/tests_effects/test_MetisWCU.py | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/scopesim/effects/metis_wcu/metis_wcu.py b/scopesim/effects/metis_wcu/metis_wcu.py index 725ed9230..e22415bfc 100644 --- a/scopesim/effects/metis_wcu/metis_wcu.py +++ b/scopesim/effects/metis_wcu/metis_wcu.py @@ -560,7 +560,7 @@ def is_multiplication(self, wavelength, nport=2): area_out = (self.d_is_out**2 * (1 - np.cos(np.arcsin(self.d_is_out / self.d_is)))) area_is = np.pi * self.d_is**2 - if nport == 0: + if nport > 0: frac = ((area_in + (nport - 1) * area_out) / area_is).decompose().value else: frac = 0 diff --git a/scopesim/tests/tests_effects/test_MetisWCU.py b/scopesim/tests/tests_effects/test_MetisWCU.py index d97c92726..fc889c187 100644 --- a/scopesim/tests/tests_effects/test_MetisWCU.py +++ b/scopesim/tests/tests_effects/test_MetisWCU.py @@ -211,6 +211,13 @@ def test_bb_aperture_does_not_change_background_emission(self, bbsource, bbsource.set_bb_aperture(newvalue) npt.assert_equal(bbsource.intens_bg, ref_bg) + def test_open_is_ports_decrease_multiplication(self, bbsource): + lam = 5 * u.um + nports = np.arange(1, 10) + is_mult = [bbsource.is_multiplication(lam, nport) + for nport in nports] + assert np.all(np.diff(is_mult) < 0) + def test_laser_brighter_with_fibre_transmission(self, bbsource): bbsource.set_lamp("laser") ft_1 = bbsource.fibre_trans