Skip to content

Commit ebdc83f

Browse files
docs: the #1275 change entry
Co-Authored-By: Claude Fable 5.1 <[email protected]>
1 parent 4e1d04b commit ebdc83f

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
---
2+
kind: fixed
3+
title: no run answers done while a finished piece of work has had no review
4+
pr: 1275
5+
surface: [engine, chat]
6+
invalidates:
7+
- "A run could answer `done` with a finished task never checked, and only under load. A worker writes its own done to the plan store and comes home a moment later; its return is what adds its check. The run read the store row as the landing, so when a root finished, or was woken, in that moment, the check was added too late or refused, and the refusal was dropped without a word. #1233 closed the first of these orders for a root that did the work alone; the others stayed open."
8+
- "A landing is now a return the run has absorbed, not a store row. The root's completion, a parent's wake and the run's own answer all wait for the worker of a done task to come home. The wait is bounded by the worker: it reads its own row when the command it is in ends, at most 600 seconds (the belt's ceiling on one command)."
9+
- "A check can now be seated beneath a task that already reads done: `Store.AddReviewCheck` (it was `AddRootCheck`, for a childless done root only) adds the check and moves every done task above it back to waiting on it, each keeping the result it earned. Nothing but a check comes in that way. A root reopened like this is owed the wake any parent is owed for a landing it was never given."
10+
- "A review the store will not seat ends the run as `incomplete`. It used to be dropped, and the run answered done with the round silently absent."
11+
- "A return already waiting in the run's channel is absorbed before a pass looks at the root's ending, and the root's row is read after that, never before."
12+
---
13+
14+
A person sees no new word. The manual's section on who checks a task's work says
15+
what the run waits for and for how long.

0 commit comments

Comments
 (0)