From 86a19d352a434c35092799beae38b738a70ba245 Mon Sep 17 00:00:00 2001 From: jehrr <79864894+jehrr@users.noreply.github.com> Date: Fri, 16 Oct 2026 11:56:33 +0000 Subject: [PATCH] Run every canary job weekly on Mondays The canary now has a single Monday cron. The daily cron is removed, and so is the gating that held the paid job or secret back to the Monday run: a scheduled run and a manual dispatch now run every job the same way, with each secret mapped plainly. A job that needs a secret still fails, naming it, when the secret is missing. Wording that said the canary (or its free half) runs daily now says weekly (Mondays). Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01CKsd7q25N19WzUZjrAdzx8 --- .github/workflows/canary.yml | 14 +++++--------- CHANGELOG.md | 4 +--- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index 16d3db1..3a51b68 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -24,12 +24,8 @@ name: canary # so the same two lines are correct with and without them. on: schedule: - # Once a day, off the hour, so it is not competing with everyone else's + # Once a week (Mondays), off the hour, so it is not competing with everyone else's # on-the-hour cron jobs for runner availability. - - cron: "37 7 * * *" - # Mondays: the same jobs, WITH the paid secrets (proxy, Scraping Browser, - # captcha key). On the daily run above those secrets read as empty, so - # it takes the free no-secret route and bills nothing. - cron: "37 7 * * 1" workflow_dispatch: @@ -40,8 +36,8 @@ jobs: # `secrets` is not available in a job-level `if`, so presence is tested # here, once, and read from each step's `if` and shell below. These are # the strings "true"/"false", never the secret itself. - HAVE_CDP: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.GIVENCHY_CDP_ENDPOINT != '' }} - HAVE_PROXY: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.GIVENCHY_PROXY != '' }} + HAVE_CDP: ${{ secrets.GIVENCHY_CDP_ENDPOINT != '' }} + HAVE_PROXY: ${{ secrets.GIVENCHY_PROXY != '' }} steps: - uses: actions/checkout@v4 @@ -79,8 +75,8 @@ jobs: # Through the environment, never argv (see the header). Unset # secrets arrive as "" and env_config.py treats that as unset, so # these lines are correct in both configurations. - GIVENCHY_CDP_ENDPOINT: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.GIVENCHY_CDP_ENDPOINT || '' }} - GIVENCHY_PROXY: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.GIVENCHY_PROXY || '' }} + GIVENCHY_CDP_ENDPOINT: ${{ secrets.GIVENCHY_CDP_ENDPOINT }} + GIVENCHY_PROXY: ${{ secrets.GIVENCHY_PROXY }} run: | set +e python3 playwright_scraper.py \ diff --git a/CHANGELOG.md b/CHANGELOG.md index 1718eac..539617f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,9 +10,7 @@ from a bill or an empty output file. ### Changed -- CI only: the canary's optional paid secrets `GIVENCHY_CDP_ENDPOINT`, `GIVENCHY_PROXY` now reach it only on a new weekly - run (Mondays 07:37 UTC) and on a manual dispatch. The daily run keeps its - schedule and takes the free route without them, so it bills nothing. +- CI only: the canary now runs weekly (Mondays 07:37 UTC) and on a manual dispatch, with its optional secrets `GIVENCHY_CDP_ENDPOINT`, `GIVENCHY_PROXY` passed on every run; the daily schedule is removed. ## [1.1.0] — 2026-10-15